Skip to content

Support REST Assured 4 #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue Aug 14, 2019 · 9 comments
Closed

Support REST Assured 4 #635

wilkinsona opened this issue Aug 14, 2019 · 9 comments
Labels
status: superseded Superseded by another issue type: enhancement Enhancement that adds a new feature

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: enhancement Enhancement that adds a new feature label Aug 14, 2019
@wilkinsona wilkinsona added this to the 2.1.0.RC1 milestone Aug 14, 2019
@bric3
Copy link
Contributor

bric3 commented Sep 2, 2019

For reference, while we are probably not using all REST-Assured features or APIs, we are already using REST Assured 4.0.0 and Spring Restdocs 2.0.3.RELEASE together without any visible issues.

@wilkinsona
Copy link
Member Author

Thank you, @bric3. That's useful info. This may turn into a just adding some compatibility testing. It may also make sense to do some repackaging as the current REST Assured support is in a restassured3 package.

@bric3
Copy link
Contributor

bric3 commented Sep 2, 2019

Ah yes I forgot to say that indeed we are using the API that lives under restassured3.

@wilkinsona
Copy link
Member Author

wilkinsona commented Sep 13, 2019

I've added some compatibility testing against both 4.0.0 and 4.1.1 (#640). I'll keep this issue open to deal with the restassured3 package. At the moment, I'm undecided between a couple of options:

  • deprecate the restassured3 package and provide the functionality in a restassured package
  • provide a restassured4 package with the same functionality

The first option is cleaner, but backs us into a corner if there's a REST Assured 5 with breaking changes in the future. The second avoids that problem but at the cost of some duplication. I think I'm leaning towards the first option at the moment.

@bric3
Copy link
Contributor

bric3 commented Sep 13, 2019

Isn't there already a restassured package that target RestAssured 2 ?
Also thinking further ahead, if it's not restassured 5 it might be restassured 6 that break compatibility.

@wilkinsona
Copy link
Member Author

Isn't there already a restassured package that target RestAssured 2 ?

There is in 1.2 where it's deprecated. It was removed in 2.0.

@asaikali
Copy link

On SpringBoot 2.3.1 I updated rest assured to 4.3.1 and groovy to 3.0.4 and things seem to be working just fine. I don't have a lot of tests yet that are using RestDocs just a few as I have just started using RestDocs on this project.

@wilkinsona
Copy link
Member Author

Thanks, @asaikali. #688 has expanded the REST Assured compatibility testing to cover 4.2 and 4.3 and didn't reveal any problems.

@wilkinsona
Copy link
Member Author

wilkinsona commented Sep 28, 2021

This has been superseded by #752 where the package will be renamed from restassured3 to restassured.

@wilkinsona wilkinsona removed this from the 2.1.0-RC1 milestone Sep 28, 2021
@wilkinsona wilkinsona added the status: superseded Superseded by another issue label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded Superseded by another issue type: enhancement Enhancement that adds a new feature
Projects
None yet
Development

No branches or pull requests

3 participants