Skip to content

Expand test coverage for AsciidoctorJ 2.x #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahus1 opened this issue Aug 2, 2019 · 1 comment
Closed

Expand test coverage for AsciidoctorJ 2.x #630

ahus1 opened this issue Aug 2, 2019 · 1 comment
Labels
type: task Non user-facing work
Milestone

Comments

@ahus1
Copy link
Contributor

ahus1 commented Aug 2, 2019

When experimenting with Spring REST docs and Asciidoctor, I found that the dependency asciidoctorj20Version in gradle.properties points to 2.0.0-RC.3. The current version of AsciidoctorJ is is 2.1.0 that includes Asciidoctor 2.0.10.

I'd suggest upgrading to 2.1.0. I've run all tests locally and they complete without error.

Maybe the variable should be renamed as well (and I am not sure about the library version upgrade policy here), so I didn't create a PR.

Please advise, and I'll create a pull request.

@wilkinsona
Copy link
Member

wilkinsona commented Aug 13, 2019

The use of asciidoctorj20Version was introduced as part of testing compatibility with AsciidoctorJ 2.0. It should be updated to 2.0.0.

Compatibility with 2.1 is probably also worth testing. If there are any breaking changes from 2.0, then a new spring-restdocs-asciidoctor-2.1 module would be needed. If there are no breaking changes then it may be appropriate to rename spring-restdocs-asciidoctor-2.1 to spring-restdocs-asciidoctor-2.x. The module's not exposed to users (it's merged into spring-restdocs-asciidoctor so the name can be changed without worrying about breaking backwards compatibility.

@wilkinsona wilkinsona changed the title AsciidoctorJ dependency out of date Expand test coverage for AsciidoctorJ 2.x Sep 13, 2019
@wilkinsona wilkinsona added type: task Non user-facing work and removed status: waiting-for-triage Untriaged issue labels Sep 13, 2019
@wilkinsona wilkinsona added this to the 2.0.4.RELEASE milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task Non user-facing work
Projects
None yet
Development

No branches or pull requests

3 participants