Skip to content

Commit 513a0e9

Browse files
committed
Tolerate breaking change in MockHttpServletRequestBuilder
Closes gh-675
1 parent 22c6475 commit 513a0e9

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

spring-restdocs-mockmvc/src/test/java/org/springframework/restdocs/mockmvc/MockMvcRestDocumentationIntegrationTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ public void linksSnippet() throws Exception {
275275
public void pathParametersSnippet() throws Exception {
276276
MockMvc mockMvc = MockMvcBuilders.webAppContextSetup(this.context)
277277
.apply(documentationConfiguration(this.restDocumentation)).build();
278-
mockMvc.perform(get("{foo}", "/").accept(MediaType.APPLICATION_JSON)).andExpect(status().isOk())
278+
mockMvc.perform(get("/{foo}", "").accept(MediaType.APPLICATION_JSON)).andExpect(status().isOk())
279279
.andDo(document("links", pathParameters(parameterWithName("foo").description("The description"))));
280280
assertExpectedSnippetFilesExist(new File("build/generated-snippets/links"), "http-request.adoc",
281281
"http-response.adoc", "curl-request.adoc", "path-parameters.adoc");

spring-restdocs-mockmvc/src/test/java/org/springframework/restdocs/mockmvc/RestDocumentationRequestBuildersTests.java

+11-11
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public class RestDocumentationRequestBuildersTests {
5151

5252
@Test
5353
public void getTemplate() {
54-
assertTemplate(get("{template}", "t"), HttpMethod.GET);
54+
assertTemplate(get("/{template}", "t"), HttpMethod.GET);
5555
}
5656

5757
@Test
@@ -61,7 +61,7 @@ public void getUri() {
6161

6262
@Test
6363
public void postTemplate() {
64-
assertTemplate(post("{template}", "t"), HttpMethod.POST);
64+
assertTemplate(post("/{template}", "t"), HttpMethod.POST);
6565
}
6666

6767
@Test
@@ -71,7 +71,7 @@ public void postUri() {
7171

7272
@Test
7373
public void putTemplate() {
74-
assertTemplate(put("{template}", "t"), HttpMethod.PUT);
74+
assertTemplate(put("/{template}", "t"), HttpMethod.PUT);
7575
}
7676

7777
@Test
@@ -81,7 +81,7 @@ public void putUri() {
8181

8282
@Test
8383
public void patchTemplate() {
84-
assertTemplate(patch("{template}", "t"), HttpMethod.PATCH);
84+
assertTemplate(patch("/{template}", "t"), HttpMethod.PATCH);
8585
}
8686

8787
@Test
@@ -91,7 +91,7 @@ public void patchUri() {
9191

9292
@Test
9393
public void deleteTemplate() {
94-
assertTemplate(delete("{template}", "t"), HttpMethod.DELETE);
94+
assertTemplate(delete("/{template}", "t"), HttpMethod.DELETE);
9595
}
9696

9797
@Test
@@ -101,7 +101,7 @@ public void deleteUri() {
101101

102102
@Test
103103
public void optionsTemplate() {
104-
assertTemplate(options("{template}", "t"), HttpMethod.OPTIONS);
104+
assertTemplate(options("/{template}", "t"), HttpMethod.OPTIONS);
105105
}
106106

107107
@Test
@@ -111,7 +111,7 @@ public void optionsUri() {
111111

112112
@Test
113113
public void headTemplate() {
114-
assertTemplate(head("{template}", "t"), HttpMethod.HEAD);
114+
assertTemplate(head("/{template}", "t"), HttpMethod.HEAD);
115115
}
116116

117117
@Test
@@ -121,7 +121,7 @@ public void headUri() {
121121

122122
@Test
123123
public void requestTemplate() {
124-
assertTemplate(request(HttpMethod.GET, "{template}", "t"), HttpMethod.GET);
124+
assertTemplate(request(HttpMethod.GET, "/{template}", "t"), HttpMethod.GET);
125125
}
126126

127127
@Test
@@ -131,7 +131,7 @@ public void requestUri() {
131131

132132
@Test
133133
public void fileUploadTemplate() {
134-
assertTemplate(fileUpload("{template}", "t"), HttpMethod.POST);
134+
assertTemplate(fileUpload("/{template}", "t"), HttpMethod.POST);
135135
}
136136

137137
@Test
@@ -142,8 +142,8 @@ public void fileUploadUri() {
142142
private void assertTemplate(MockHttpServletRequestBuilder builder, HttpMethod httpMethod) {
143143
MockHttpServletRequest request = builder.buildRequest(this.servletContext);
144144
assertThat((String) request.getAttribute(RestDocumentationGenerator.ATTRIBUTE_NAME_URL_TEMPLATE))
145-
.isEqualTo("{template}");
146-
assertThat(request.getRequestURI()).isEqualTo("t");
145+
.isEqualTo("/{template}");
146+
assertThat(request.getRequestURI()).isEqualTo("/t");
147147
assertThat(request.getMethod()).isEqualTo(httpMethod.name());
148148
}
149149

0 commit comments

Comments
 (0)