Skip to content

Commit d01cc8e

Browse files
eliminate the usage of StringBuffer (#2909)
1 parent 1082614 commit d01cc8e

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
import java.util.Properties;
2323
import java.util.Set;
2424
import java.util.function.BiConsumer;
25+
import java.util.stream.Collectors;
26+
import java.util.stream.StreamSupport;
2527

2628
import org.apache.kafka.clients.consumer.Consumer;
2729
import org.apache.kafka.clients.consumer.ConsumerConfig;
@@ -189,12 +191,9 @@ private static void listen(List<RetryListener> listeners, ConsumerRecords<?, ?>
189191
* @return the String.
190192
*/
191193
public static String recordsToString(ConsumerRecords<?, ?> records) {
192-
StringBuffer sb = new StringBuffer();
193-
records.spliterator().forEachRemaining(rec -> sb
194-
.append(KafkaUtils.format(rec))
195-
.append(','));
196-
sb.deleteCharAt(sb.length() - 1);
197-
return sb.toString();
194+
return StreamSupport.stream(records.spliterator(), false)
195+
.map(KafkaUtils::format)
196+
.collect(Collectors.joining(","));
198197
}
199198

200199
/**

spring-kafka/src/main/java/org/springframework/kafka/support/LoggingProducerListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void setMaxContentLogged(int maxContentLogged) {
6969
@Override
7070
public void onError(ProducerRecord<K, V> record, @Nullable RecordMetadata recordMetadata, Exception exception) {
7171
this.logger.error(exception, () -> {
72-
StringBuffer logOutput = new StringBuffer();
72+
StringBuilder logOutput = new StringBuilder();
7373
logOutput.append("Exception thrown when sending a message");
7474
if (this.includeContents) {
7575
logOutput.append(" with key='")

0 commit comments

Comments
 (0)