Skip to content

Commit 5101b17

Browse files
committed
GH-2286: Doc Fixes
Resolves #2286 Remove `ackOnError` and fix error handler type.
1 parent 07e4bc8 commit 5101b17

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

spring-kafka-docs/src/main/asciidoc/kafka.adoc

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2437,10 +2437,6 @@ When creating the `TopicPartitionOffset` s for the request, only positive, absol
24372437
|BATCH
24382438
|Controls how often offsets are committed - see <<committing-offsets>>.
24392439

2440-
|[[ackOnError]]<<ackOnError,`ackOnError`>>
2441-
|`false`
2442-
|[DEPRECATED in favor of `ErrorHandler.isAckAfterHandle()`]
2443-
24442440
|[[ackTime]]<<ackTime,`ackTime`>>
24452441
|5000
24462442
|The time in milliseconds after which pending offsets are committed when the `ackMode` is `TIME` or `COUNT_TIME`.
@@ -5106,7 +5102,6 @@ For example, with the `@KafkaListener` container factory, you can add `DefaultEr
51065102
public ConcurrentKafkaListenerContainerFactory<String, String> kafkaListenerContainerFactory() {
51075103
ConcurrentKafkaListenerContainerFactory<String, String> factory = new ConcurrentKafkaListenerContainerFactory();
51085104
factory.setConsumerFactory(consumerFactory());
5109-
factory.getContainerProperties().setAckOnError(false);
51105105
factory.getContainerProperties().setAckMode(AckMode.RECORD);
51115106
factory.setCommonErrorHandler(new DefaultErrorHandler(new FixedBackOff(1000L, 2L)));
51125107
return factory;
@@ -5586,7 +5581,7 @@ DeadLetterPublishingRecoverer recoverer = new DeadLetterPublishingRecoverer(temp
55865581
return new TopicPartition(r.topic() + ".other.failures", r.partition());
55875582
}
55885583
});
5589-
ErrorHandler errorHandler = new DefaultErrorHandler(recoverer, new FixedBackOff(0L, 2L));
5584+
CommonErrorHandler errorHandler = new DefaultErrorHandler(recoverer, new FixedBackOff(0L, 2L));
55905585
----
55915586
====
55925587

0 commit comments

Comments
 (0)