Skip to content

Commit 4924f4c

Browse files
committed
Fix Tests for Latest Spring Milestone
NestedException messages no longer traverse causes.
1 parent b9f7c73 commit 4924f4c

File tree

5 files changed

+8
-6
lines changed

5 files changed

+8
-6
lines changed

spring-kafka/src/test/java/org/springframework/kafka/core/DefaultKafkaProducerFactoryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ protected Producer createRawProducer(Map configs) {
107107
return null;
108108
});
109109
})
110-
.withMessageContaining("Invalid transition");
110+
.withStackTraceContaining("Invalid transition");
111111

112112
assertThat(queue).hasSize(0);
113113

spring-kafka/src/test/java/org/springframework/kafka/listener/ErrorHandlingDeserializerTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ public String deserialize(String topic, Headers headers, byte[] data) {
131131
ehd.deserialize("foo", headers, new byte[1]);
132132
DeserializationException dex = ListenerUtils.byteArrayToDeserializationException(null,
133133
headers.lastHeader(SerializationUtils.VALUE_DESERIALIZER_EXCEPTION_HEADER).value());
134-
assertThat(dex.getMessage())
134+
assertThat(dex.getCause().getMessage())
135135
.contains("Could not serialize")
136136
.contains("original exception message");
137137
}

spring-kafka/src/test/java/org/springframework/kafka/listener/MissingGroupIdTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void testContextFailsWithKafkaListener() {
6060
new AnnotationConfigApplicationContext(Config1.class);
6161
})
6262
.withCauseInstanceOf(IllegalStateException.class)
63-
.withMessageContaining("No group.id found in consumer config");
63+
.withStackTraceContaining("No group.id found in consumer config");
6464
}
6565

6666
@Test
@@ -69,7 +69,7 @@ public void testContextFailsWithSubscribedContainer() {
6969
new AnnotationConfigApplicationContext(Config2.class);
7070
})
7171
.withCauseInstanceOf(IllegalStateException.class)
72-
.withMessageContaining("No group.id found in consumer config");
72+
.withStackTraceContaining("No group.id found in consumer config");
7373
}
7474

7575
@Test

spring-kafka/src/test/java/org/springframework/kafka/listener/TransactionalContainerTests.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -752,8 +752,10 @@ public void accept(ConsumerRecord<?, ?> record, Consumer<?, ?> consumer, Excepti
752752
assertThat(new String(headers.get(KafkaHeaders.DLT_EXCEPTION_CAUSE_FQCN, byte[].class)))
753753
.isEqualTo("java.lang.RuntimeException");
754754
assertThat(headers.get(KafkaHeaders.DLT_EXCEPTION_MESSAGE, byte[].class))
755-
.contains("fail for max failures".getBytes());
755+
.contains("Listener failed".getBytes());
756756
assertThat(headers.get(KafkaHeaders.DLT_EXCEPTION_STACKTRACE)).isNotNull();
757+
assertThat(headers.get(KafkaHeaders.DLT_EXCEPTION_STACKTRACE, byte[].class))
758+
.contains("fail for max failures".getBytes());
757759
assertThat(headers.get(KafkaHeaders.DLT_ORIGINAL_OFFSET, byte[].class)[3]).isEqualTo((byte) 0);
758760
assertThat(headers.get(KafkaHeaders.DLT_ORIGINAL_PARTITION, byte[].class)[3]).isEqualTo((byte) 0);
759761
assertThat(headers.get(KafkaHeaders.DLT_ORIGINAL_TIMESTAMP, byte[].class)).isNotNull();

spring-kafka/src/test/java/org/springframework/kafka/listener/adapter/MessagingMessageListenerAdapterTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ void testMissingAck() throws NoSuchMethodException, SecurityException {
7777
assertThatExceptionOfType(ListenerExecutionFailedException.class).isThrownBy(() -> adapter.onMessage(
7878
new ConsumerRecord<>("foo", 0, 0L, null, "foo"), null, null))
7979
.withCauseExactlyInstanceOf(IllegalStateException.class)
80-
.withMessageContaining("MANUAL");
80+
.withStackTraceContaining("MANUAL");
8181
}
8282

8383
public void test(Acknowledgment ack) {

0 commit comments

Comments
 (0)