Add dedicated IDE templates for Spring Integration Framework Code Style

[xak2000]

• There is Spring Integration Framework Code Style that documents import statements.
• There is also Spring Framework Code Style that also documents import statements.

And they are different. Is this intended?

Maybe this is not a problem in itself, but the same document suggests:

Some code conventions you can pick up for your IDE from the Spring Framework templates: InteglliJ IDEA or Eclipse.

I tried to import the template into InteglliJ IDEA and found out that imports are really in different order. For example static imports are last according to this commit (and it looks like this is right for Spring Framework Code Style, but wrong for Spring Integration Framework Code Style).

Maybe it's worth to add dedicated templates for IDEs with Spring Integration Framework Code Style? Or change the code style to match Spring Framework Code Style, I don't know.

[artembilan]

Thank you for bringing this again, @xak2000 !

I think it really a time for the current new major release to revise our code style with Spring Framework and Spring Boot style.
I can't recall right now when, but Spring Framework had changed its imports order many years ago and there was no any template back in those days yet.
So we left with our own style just because we really don't cross with Spring Framework & Spring Boot development too much.

But I understand your concern as end-user contributor you really don't care what Spring project you are opening: they have to look alike.

I don't mind to change the import order in the next 6.0 version and really rely on the IDE template from Spring Framework.
Then we would need to change the Checkstyle rule for imports.
And looks like IDEA has now option to Optimize Imports for the whole project 😄 :

So, stay tuned or feel free to try to fix it on the 6.0-WIP branch!

[xak2000]

Thanks, @artembilan !

I just want to clarify why I raised this topic.

But I understand your concern as end-user contributor you really don't care what Spring project you are opening: they have to look alike.

The primary concern is not about the fact that I'm, as an end-user contributor, don't care what Spring project I'm opening. It's ofc also true to some degree 😄. But not much, as IDE could remember Style config for each project separately.

The real concern is that to start contributing you need to carefully read full style guide and configure the IDE manually or try to rearrange imports manually, ignoring the order that IDE puts them in, and removing your dirty hands from CTRL-ALT-O. And I speak only about imports. I didn't check what else is different to be honest.

Importing a prepared IDE config is much more simple and fast for new contributors.

Also because Spring Integration Contribution guide recommends importing Spring Framework's IDE configs, some people could just import and think that it's done. But nope. After importing they need to configure some more options according to style guide.