Skip to content

Commit 50fa345

Browse files
committed
Fix new Sonar smell
1 parent c36b759 commit 50fa345

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

spring-integration-core/src/main/java/org/springframework/integration/config/MessageHandlerMethodFactoryCreatingFactoryBean.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import org.springframework.beans.BeansException;
2323
import org.springframework.beans.factory.BeanFactory;
2424
import org.springframework.beans.factory.BeanFactoryAware;
25+
import org.springframework.beans.factory.BeanInitializationException;
2526
import org.springframework.beans.factory.FactoryBean;
2627
import org.springframework.beans.factory.InitializingBean;
2728
import org.springframework.integration.handler.support.CollectionArgumentResolver;
@@ -54,7 +55,7 @@ class MessageHandlerMethodFactoryCreatingFactoryBean
5455

5556
private final boolean listCapable;
5657

57-
MessageConverter argumentResolverMessageConverter;
58+
private MessageConverter argumentResolverMessageConverter;
5859

5960
private BeanFactory beanFactory;
6061

@@ -77,7 +78,7 @@ public Class<?> getObjectType() {
7778
}
7879

7980
@Override
80-
public MessageHandlerMethodFactory getObject() throws Exception {
81+
public MessageHandlerMethodFactory getObject() {
8182
DefaultMessageHandlerMethodFactory handlerMethodFactory = new DefaultMessageHandlerMethodFactory();
8283
handlerMethodFactory.setBeanFactory(this.beanFactory);
8384
handlerMethodFactory.setMessageConverter(this.argumentResolverMessageConverter);
@@ -86,7 +87,7 @@ public MessageHandlerMethodFactory getObject() throws Exception {
8687
return handlerMethodFactory;
8788
}
8889

89-
private List<HandlerMethodArgumentResolver> buildArgumentResolvers(boolean listCapable) throws Exception {
90+
private List<HandlerMethodArgumentResolver> buildArgumentResolvers(boolean listCapable) {
9091
List<HandlerMethodArgumentResolver> resolvers = new ArrayList<>();
9192
resolvers.add(new PayloadExpressionArgumentResolver());
9293
resolvers.add(new NullAwarePayloadArgumentResolver(this.argumentResolverMessageConverter));
@@ -100,7 +101,12 @@ private List<HandlerMethodArgumentResolver> buildArgumentResolvers(boolean listC
100101
((BeanFactoryAware) resolver).setBeanFactory(this.beanFactory);
101102
}
102103
if (resolver instanceof InitializingBean) {
103-
((InitializingBean) resolver).afterPropertiesSet();
104+
try {
105+
((InitializingBean) resolver).afterPropertiesSet();
106+
}
107+
catch (Exception ex) {
108+
throw new BeanInitializationException("Cannot initialize 'HandlerMethodArgumentResolver'", ex);
109+
}
104110
}
105111
}
106112
return resolvers;

0 commit comments

Comments
 (0)