Some improvements for SMB module

* Improve permission information returned in `SmbFileInfo`
* Improve documentation for `SmbFileInfo.getPermissions()`
* Add Junit tests to verify all outbound gateway functionality
* Clean test directory of mistakenly migrated SMB extension code

Author: GregBragg

spring-integration-smb/src/main/java/org/springframework/integration/smb/session/SmbFileInfo.java

@@ -17,7 +17,6 @@
 package org.springframework.integration.smb.session;
 
 import java.io.IOException;
-import java.util.Arrays;
 
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
@@ -91,23 +90,70 @@ public String getFilename() {
 	}
 
 	/**
-	 * An Access Control Entry (ACE) is an element in a security descriptor
-	 * such as those associated with files and directories. The Windows OS
-	 * determines which users have the necessary permissions to access objects
-	 * based on these entries.
-	 * @return a list of Access Control Entry (ACE) objects representing
-	 * the security descriptor associated with this file or directory.
+	 * An Access Control Entry (ACE) is an element in a security descriptor such as
+	 * those associated with files and directories. The Windows OS determines which
+	 * users have the necessary permissions to access objects based on these entries.
+	 * A readable, formatted list of security descriptor entries and associated
+	 * permissions will be returned by this implementation.
+	 *
+	 * <pre>
+	 * WNET\alice - Deny Write, Deny Modify, Direct - This folder only
+	 * SYSTEM - Allow Read, Allow Write, Allow Modify, Allow Execute, Allow Delete, Inherited - This folder only
+	 * WNET\alice - Allow Read, Allow Write, Allow Modify, Allow Execute, Allow Delete, Inherited - This folder only
+	 * Administrators - Allow Read, Allow Write, Allow Modify, Allow Execute, Allow Delete, Inherited - This folder only
+	 * </pre>
+	 *
+	 * @return a list of Access Control Entry (ACE) objects representing the security
+	 * descriptor entry and permissions associated with this file or directory.
+	 * @see jcifs.ACE
+	 * @see jcifs.SID
 	 */
 	@Override
 	public String getPermissions() {
-		ACE[] aceArray = null;
+		ACE[] aces = null;
 		try {
-			aceArray = this.smbFile.getSecurity(true);
+			aces = this.smbFile.getSecurity(true);
 		}
-		catch (IOException se) {
-			logger.error("Unable to determine security descriptor information for this SmbFile", se);
+		catch (IOException ioe) {
+			logger.error("Unable to determine security descriptor information for this SmbFile", ioe);
+			return null;
 		}
-		return (aceArray == null) ? null : Arrays.toString(aceArray);
+
+		StringBuilder sb = new StringBuilder();
+		for (ACE ace : aces) {
+			sb.append(ace.getSID().toDisplayString());
+			sb.append(" - ");
+
+			if ((ace.getAccessMask() & ACE.FILE_READ_DATA) != 0) {
+				sb.append(ace.isAllow() ? "Allow " : "Deny ");
+				sb.append("Read, ");
+			}
+			if ((ace.getAccessMask() & ACE.FILE_WRITE_DATA) != 0) {
+				sb.append(ace.isAllow() ? "Allow " : "Deny ");
+				sb.append("Write, ");
+			}
+			if ((ace.getAccessMask() & ACE.FILE_APPEND_DATA) != 0) {
+				sb.append(ace.isAllow() ? "Allow " : "Deny ");
+				sb.append("Modify, ");
+			}
+			if ((ace.getAccessMask() & ACE.FILE_EXECUTE) != 0) {
+				sb.append(ace.isAllow() ? "Allow " : "Deny ");
+				sb.append("Execute, ");
+			}
+			if ((ace.getAccessMask() & ACE.FILE_DELETE) != 0
+					|| (ace.getAccessMask() & ACE.DELETE) != 0) {
+				sb.append(ace.isAllow() ? "Allow " : "Deny ");
+				sb.append("Delete, ");
+			}
+
+			sb.append(ace.isInherited() ? "Inherited - " : "Direct - ");
+			sb.append(ace.getApplyToText());
+			sb.append("\n");
+		}
+		logger.debug(this.getFilename());
+		logger.debug("\n" + sb.toString());
+
+		return sb.toString();
 	}
 
 	@Override