Skip to content

Deprecate ContentCachingRequestWrapper constructors without contentCacheLimit #33914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rstoyanchev opened this issue Nov 19, 2024 · 2 comments
Closed

Deprecate ContentCachingRequestWrapper constructors without contentCacheLimit #33914

rstoyanchev opened this issue Nov 19, 2024 · 2 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Milestone
6.2.1

Comments

@rstoyanchev
Copy link
Contributor

ContentCachingRequestWrapper can be configured with a limit. It was introduced a long time ago as an optional parameter, but arguably should be a required decision.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task labels Nov 19, 2024
@rstoyanchev rstoyanchev added this to the 6.2.1 milestone Nov 19, 2024
@rstoyanchev rstoyanchev self-assigned this Nov 19, 2024
@ngocnhan-tran1996
Copy link
Contributor

May I work on this?

@rstoyanchev
Copy link
Contributor Author

The actual deprecation is very minor, but I plan to review the initialization code and some Javadoc guidance, so I'll handle this myself. Thanks for reaching out in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: task A general task
Projects
None yet
Milestone
6.2.1
Development

No branches or pull requests
2 participants
@rstoyanchev @ngocnhan-tran1996