Skip to content

Add micrometer instrumentation for transactions to spring-tx #33751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edudar opened this issue Oct 18, 2024 · 1 comment
Closed

Add micrometer instrumentation for transactions to spring-tx #33751

edudar opened this issue Oct 18, 2024 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@edudar
Copy link

edudar commented Oct 18, 2024

With the migration from Spring Cloud Sleuth to Micrometer Tracing, the direction was to move instrumentation support to respective projects. Looking through the code, it doesn't look like support for transactions has been migrated to spring-tx.

The original tx support in Sleuth: https://github.com/spring-cloud/spring-cloud-sleuth/tree/3.1.x/spring-cloud-sleuth-instrumentation/src/main/java/org/springframework/cloud/sleuth/instrument/tx that supports imperative and reactive transaction managers.

@bclozel
Copy link
Member

bclozel commented Oct 19, 2024

This was considered and declined in #28156 (comment)

@bclozel bclozel added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 19, 2024
@bclozel bclozel closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants