Skip to content

CRaC support: Checkpoint failing with CheckpointOpenSocketException #33103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shanmuk256 opened this issue Jun 26, 2024 · 3 comments
Closed

CRaC support: Checkpoint failing with CheckpointOpenSocketException #33103

shanmuk256 opened this issue Jun 26, 2024 · 3 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression)

Comments

@shanmuk256
Copy link

shanmuk256 commented Jun 26, 2024

Trying to create check point in spring boot application but failing with the below error

jdk.crac.impl.CheckpointOpenSocketException: tcp6 localAddr :: localPort 8088 remoteAddr :: remotePort 0
at java.base/jdk.crac.Core.translateJVMExceptions(Core.java:88)
at java.base/jdk.crac.Core.checkpointRestore1(Core.java:142)
at java.base/jdk.crac.Core.checkpointRestore(Core.java:237)
at java.base/jdk.crac.Core.lambda$checkpointRestoreInternal$3(Core.java:259)
at java.base/java.lang.Thread.run(Thread.java:833)

I used the spring.context.checkpoint=onRefresh in application.yml file.

Implemented beforeCheckpoint method and close the connection opened by application.
However spring web server is not being closed and throwing exception.

jdk : openjdk-17-crac+3_linux-x64
springBootVersion = "3.3.0"

Appreciate any pointer and solution on this

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 26, 2024
@sdeleuze sdeleuze self-assigned this Jun 27, 2024
@sdeleuze
Copy link
Contributor

sdeleuze commented Jun 27, 2024

spring.context.checkpoint=onRefresh is not a Spring Boot property you should set in application.yml but a JVM system property as documented here. I suggest you fix your use case accordingly by using java -Dspring.context.exit=onRefresh ..., you should not have to implement beforeCheckpoint to close the connection opened by the application. https://github.com/spring-projects/spring-lifecycle-smoke-tests/ provides addition guidance for database etc.

if you still reproduce, please provide a self contained reproducer as a link to a repository or an attached project with the steps to reproduce. If you don't, please close this issue.

@bclozel bclozel added status: waiting-for-feedback We need additional information before we can continue in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 27, 2024
@spring-projects-issues
Copy link
Collaborator

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Jul 4, 2024
@spring-projects-issues
Copy link
Collaborator

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

@spring-projects-issues spring-projects-issues closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@spring-projects-issues spring-projects-issues removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged or decided on labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Projects
None yet
Development

No branches or pull requests

4 participants