Skip to content

BeanDefinitionPropertyValueCodeGenerator#orderForConsistency expects values to be Comparable #31419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Oct 12, 2023 · 1 comment
Closed

BeanDefinitionPropertyValueCodeGenerator#orderForConsistency expects values to be Comparable #31419

snicoll opened this issue Oct 12, 2023 · 1 comment
Assignees
@snicoll
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Milestone
6.1.0-RC2

Comments

@snicoll
Copy link
Member

snicoll commented Oct 12, 2023 •
edited
Loading

As reported in #29074, the map generator expects any value to implement Comparable as it puts them in a TreeMap so that the generated code is reproductible.

Most values are basic but TypeStringValue does not implement Comparable. We could fix that but that's probably a workaround of the underlying problem.
@snicoll snicoll added type: bug A general bug theme: aot An issue related to Ahead-of-time processing labels Oct 12, 2023
@snicoll snicoll self-assigned this Oct 12, 2023
@snicoll snicoll added this to the 6.1.x milestone Oct 12, 2023
@snicoll
Copy link
Member Author

snicoll commented Oct 12, 2023 •
edited
Loading

Actually we're handling this in a certain way for Set so it's about aligning for Map there.

@snicoll snicoll modified the milestones: 6.1.x, 6.1.0-RC2 Oct 12, 2023
@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
6.1.0-RC2
Development

No branches or pull requests
2 participants
@snicoll @jhoeller