Skip to content

Improve Coroutines transaction API #23627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdeleuze opened this issue Sep 12, 2019 · 0 comments
Closed

Improve Coroutines transaction API #23627

sdeleuze opened this issue Sep 12, 2019 · 0 comments
Assignees
@sdeleuze
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task
Milestone
5.2 GA

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 12, 2019 •
edited
Loading

As a follow-up of #22915, the purpose of this issue is to improve Coroutines programmatic transaction API to make it more consistent with the Java one.

For suspending functions, we currently have TransactionalOperator.transactional extension with a suspending lambda parameter which is conceptually closer to TransactionalOperator.execute Java API, so it would probably make sense to rename it TransactionalOperator.executeAndAwait and add a ReactiveTransaction parameter to the lambda.

For Flow the TransactionalOperator.transactional is correct but would be more idiomatic as a Flow extension.
@sdeleuze sdeleuze added in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task labels Sep 12, 2019
@sdeleuze sdeleuze added this to the 5.2 GA milestone Sep 12, 2019
@sdeleuze sdeleuze self-assigned this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: task A general task
Projects
None yet
Milestone
5.2 GA
Development

No branches or pull requests
1 participant
@sdeleuze