Skip to content

Improve RSocketRequester.ResponseSpec Kotlin extensions #23164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
juergenzimmermann opened this issue Jun 20, 2019 · 1 comment
Closed

Improve RSocketRequester.ResponseSpec Kotlin extensions #23164

juergenzimmermann opened this issue Jun 20, 2019 · 1 comment
Assignees
@sdeleuze
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone
5.2 RC1

Comments

@juergenzimmermann
Copy link

Affects: Spring Framework 5.2.0-M3

It would be nice to have Kotlin extension functions for RSocketRequester.ResponseSpec so that one could write in Kotlin style, e.g.:

requester.route("find-by-id")
    .data(CustomerIdRequest(id))
    .retrieveMono<Customer>()

instead of

requester.route("find-by-id")
    .data(CustomerIdRequest(id))
    .retrieveMono(Customer::class.java)

In the same way it would be nice to have .retrieveFlux<T>()
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jun 20, 2019
@sdeleuze sdeleuze self-assigned this Jun 20, 2019
@sdeleuze sdeleuze added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 20, 2019
@sdeleuze sdeleuze added this to the 5.2 RC1 milestone Jun 20, 2019
@sdeleuze sdeleuze changed the title Kotlin extension functions for RSocketRequester.ResponseSpec Improve RSocketRequester.ResponseSpec Kotlin extensions Jun 21, 2019
@sdeleuze
Copy link
Contributor

Another improvement I will make is to leverage d6b5c20 to replace dataFlow(flow: Flow) extension by a general purpose reified data(producer: Any) one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 RC1
Development

No branches or pull requests
3 participants
@sdeleuze @juergenzimmermann @spring-projects-issues