Skip to content

Commit f2b3263

Browse files
committed
Polishing
1 parent 1d890a8 commit f2b3263

File tree

3 files changed

+19
-20
lines changed

3 files changed

+19
-20
lines changed

spring-aop/src/main/java/org/springframework/aop/scope/ScopedProxyBeanRegistrationAotProcessor.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,9 @@ public CodeBlock generateSetBeanDefinitionPropertiesCode(
134134
}
135135

136136
@Override
137-
public CodeBlock generateInstanceSupplierCode(GenerationContext generationContext,
138-
BeanRegistrationCode beanRegistrationCode, boolean allowDirectSupplierShortcut) {
137+
public CodeBlock generateInstanceSupplierCode(
138+
GenerationContext generationContext, BeanRegistrationCode beanRegistrationCode,
139+
boolean allowDirectSupplierShortcut) {
139140

140141
GeneratedMethod generatedMethod = beanRegistrationCode.getMethods()
141142
.add("getScopedProxyInstance", method -> {

spring-beans/src/main/java/org/springframework/beans/factory/aot/DefaultBeanRegistrationCodeFragments.java

+8-7
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,7 @@ private Class<?> extractDeclaringClass(RegisteredBean registeredBean, Instantiat
104104
/**
105105
* Extract the target class of a public {@link FactoryBean} based on its
106106
* constructor. If the implementation does not resolve the target class
107-
* because it itself uses a generic, attempt to extract it from the
108-
* bean type.
107+
* because it itself uses a generic, attempt to extract it from the bean type.
109108
* @param factoryBeanType the factory bean type
110109
* @param beanType the bean type
111110
* @return the target class to use
@@ -172,9 +171,11 @@ public CodeBlock generateSetBeanDefinitionPropertiesCode(
172171

173172
Loader loader = AotServices.factories(this.registeredBean.getBeanFactory().getBeanClassLoader());
174173
List<Delegate> additionalDelegates = loader.load(Delegate.class).asList();
175-
return new BeanDefinitionPropertiesCodeGenerator(generationContext.getRuntimeHints(),
176-
attributeFilter, beanRegistrationCode.getMethods(),
177-
additionalDelegates, (name, value) -> generateValueCode(generationContext, name, value))
174+
175+
return new BeanDefinitionPropertiesCodeGenerator(
176+
generationContext.getRuntimeHints(), attributeFilter,
177+
beanRegistrationCode.getMethods(), additionalDelegates,
178+
(name, value) -> generateValueCode(generationContext, name, value))
178179
.generateCode(beanDefinition);
179180
}
180181

@@ -234,8 +235,8 @@ public CodeBlock generateInstanceSupplierCode(
234235
throw new IllegalStateException("Default code generation is not supported for bean definitions " +
235236
"declaring an instance supplier callback: " + this.registeredBean.getMergedBeanDefinition());
236237
}
237-
return new InstanceSupplierCodeGenerator(generationContext, beanRegistrationCode.getClassName(),
238-
beanRegistrationCode.getMethods(), allowDirectSupplierShortcut)
238+
return new InstanceSupplierCodeGenerator(generationContext,
239+
beanRegistrationCode.getClassName(), beanRegistrationCode.getMethods(), allowDirectSupplierShortcut)
239240
.generateCode(this.registeredBean, this.instantiationDescriptor.get());
240241
}
241242

spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassPostProcessor.java

+8-11
Original file line numberDiff line numberDiff line change
@@ -756,12 +756,7 @@ private CodeBlock generatePropertySourceDescriptorCode(PropertySourceDescriptor
756756
}
757757

758758
private CodeBlock handleNull(@Nullable Object value, Supplier<CodeBlock> nonNull) {
759-
if (value == null) {
760-
return CodeBlock.of("null");
761-
}
762-
else {
763-
return nonNull.get();
764-
}
759+
return (value == null ? CodeBlock.of("null") : nonNull.get());
765760
}
766761
}
767762

@@ -781,9 +776,9 @@ public ConfigurationClassProxyBeanRegistrationCodeFragments(
781776
}
782777

783778
@Override
784-
public CodeBlock generateSetBeanDefinitionPropertiesCode(GenerationContext generationContext,
785-
BeanRegistrationCode beanRegistrationCode, RootBeanDefinition beanDefinition,
786-
Predicate<String> attributeFilter) {
779+
public CodeBlock generateSetBeanDefinitionPropertiesCode(
780+
GenerationContext generationContext, BeanRegistrationCode beanRegistrationCode,
781+
RootBeanDefinition beanDefinition, Predicate<String> attributeFilter) {
787782

788783
CodeBlock.Builder code = CodeBlock.builder();
789784
code.add(super.generateSetBeanDefinitionPropertiesCode(generationContext,
@@ -794,11 +789,13 @@ public CodeBlock generateSetBeanDefinitionPropertiesCode(GenerationContext gener
794789
}
795790

796791
@Override
797-
public CodeBlock generateInstanceSupplierCode(GenerationContext generationContext,
798-
BeanRegistrationCode beanRegistrationCode, boolean allowDirectSupplierShortcut) {
792+
public CodeBlock generateInstanceSupplierCode(
793+
GenerationContext generationContext, BeanRegistrationCode beanRegistrationCode,
794+
boolean allowDirectSupplierShortcut) {
799795

800796
InstantiationDescriptor instantiationDescriptor = proxyInstantiationDescriptor(
801797
generationContext.getRuntimeHints(), this.registeredBean.resolveInstantiationDescriptor());
798+
802799
return new InstanceSupplierCodeGenerator(generationContext,
803800
beanRegistrationCode.getClassName(), beanRegistrationCode.getMethods(), allowDirectSupplierShortcut)
804801
.generateCode(this.registeredBean, instantiationDescriptor);

0 commit comments

Comments
 (0)