Skip to content

Commit e7a297a

Browse files
committed
Rename TestAotMappings to AotTestContextInitializers
- for consistency with AotTestAttributes and similar classes See gh-28205, gh-28204
1 parent a3b6b41 commit e7a297a

File tree

7 files changed

+38
-36
lines changed

7 files changed

+38
-36
lines changed

spring-test/src/main/java/org/springframework/test/context/aot/TestAotMappings.java renamed to spring-test/src/main/java/org/springframework/test/context/aot/AotTestContextInitializers.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
import org.springframework.util.ReflectionUtils;
2929

3030
/**
31-
* {@code TestAotMappings} provides mappings from test classes to AOT-optimized
32-
* context initializers.
31+
* {@code AotTestContextInitializers} provides mappings from test classes to
32+
* AOT-optimized context initializers.
3333
*
3434
* <p>If a test class is not {@linkplain #isSupportedTestClass(Class) supported} in
3535
* AOT mode, {@link #getContextInitializer(Class)} will return {@code null}.
@@ -42,27 +42,27 @@
4242
* @author Stephane Nicoll
4343
* @since 6.0
4444
*/
45-
public class TestAotMappings {
45+
public class AotTestContextInitializers {
4646

4747
// TODO Add support in ClassNameGenerator for supplying a predefined class name.
4848
// There is a similar issue in Spring Boot where code relies on a generated name.
49-
// Ideally we would generate a class named: org.springframework.test.context.aot.GeneratedTestAotMappings
50-
static final String GENERATED_MAPPINGS_CLASS_NAME = TestAotMappings.class.getName() + "__Generated";
49+
// Ideally we would generate a class named: org.springframework.test.context.aot.GeneratedAotTestContextInitializers
50+
static final String GENERATED_MAPPINGS_CLASS_NAME = AotTestContextInitializers.class.getName() + "__Generated";
5151

5252
static final String GENERATED_MAPPINGS_METHOD_NAME = "getContextInitializers";
5353

5454
private final Map<String, Supplier<ApplicationContextInitializer<ConfigurableApplicationContext>>> contextInitializers;
5555

5656

57-
public TestAotMappings() {
57+
public AotTestContextInitializers() {
5858
this(GENERATED_MAPPINGS_CLASS_NAME);
5959
}
6060

61-
TestAotMappings(String initializerClassName) {
61+
AotTestContextInitializers(String initializerClassName) {
6262
this(loadContextInitializersMap(initializerClassName));
6363
}
6464

65-
TestAotMappings(Map<String, Supplier<ApplicationContextInitializer<ConfigurableApplicationContext>>> contextInitializers) {
65+
AotTestContextInitializers(Map<String, Supplier<ApplicationContextInitializer<ConfigurableApplicationContext>>> contextInitializers) {
6666
this.contextInitializers = contextInitializers;
6767
}
6868

spring-test/src/main/java/org/springframework/test/context/aot/TestAotMappingsCodeGenerator.java renamed to spring-test/src/main/java/org/springframework/test/context/aot/AotTestContextInitializersCodeGenerator.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@
4141
import org.springframework.util.MultiValueMap;
4242

4343
/**
44-
* Internal code generator for mappings used by {@link TestAotMappings}.
44+
* Internal code generator for mappings used by {@link AotTestContextInitializers}.
4545
*
4646
* @author Sam Brannen
4747
* @since 6.0
4848
*/
49-
class TestAotMappingsCodeGenerator {
49+
class AotTestContextInitializersCodeGenerator {
5050

51-
private static final Log logger = LogFactory.getLog(TestAotMappingsCodeGenerator.class);
51+
private static final Log logger = LogFactory.getLog(AotTestContextInitializersCodeGenerator.class);
5252

5353
private static final ParameterizedTypeName CONTEXT_INITIALIZER = ParameterizedTypeName.get(
5454
ClassName.get(ApplicationContextInitializer.class),
@@ -67,7 +67,7 @@ class TestAotMappingsCodeGenerator {
6767
private final GeneratedClass generatedClass;
6868

6969

70-
TestAotMappingsCodeGenerator(MultiValueMap<ClassName, Class<?>> initializerClassMappings,
70+
AotTestContextInitializersCodeGenerator(MultiValueMap<ClassName, Class<?>> initializerClassMappings,
7171
GeneratedClasses generatedClasses) {
7272

7373
this.initializerClassMappings = initializerClassMappings;
@@ -82,13 +82,13 @@ GeneratedClass getGeneratedClass() {
8282
private void generateType(TypeSpec.Builder type) {
8383
logger.debug(LogMessage.format("Generating AOT test mappings in %s",
8484
this.generatedClass.getName().reflectionName()));
85-
type.addJavadoc("Generated mappings for {@link $T}.", TestAotMappings.class);
85+
type.addJavadoc("Generated mappings for {@link $T}.", AotTestContextInitializers.class);
8686
type.addModifiers(Modifier.PUBLIC);
8787
type.addMethod(generateMappingMethod());
8888
}
8989

9090
private MethodSpec generateMappingMethod() {
91-
MethodSpec.Builder method = MethodSpec.methodBuilder(TestAotMappings.GENERATED_MAPPINGS_METHOD_NAME);
91+
MethodSpec.Builder method = MethodSpec.methodBuilder(AotTestContextInitializers.GENERATED_MAPPINGS_METHOD_NAME);
9292
method.addModifiers(Modifier.PUBLIC, Modifier.STATIC);
9393
method.returns(CONTEXT_SUPPLIER_MAP);
9494
method.addCode(generateMappingCode());

spring-test/src/main/java/org/springframework/test/context/aot/TestContextAotGenerator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,13 @@ private String nextTestContextId() {
240240
}
241241

242242
private void generateTestAotMappings(MultiValueMap<ClassName, Class<?>> initializerClassMappings) {
243-
ClassNameGenerator classNameGenerator = new ClassNameGenerator(TestAotMappings.class);
243+
ClassNameGenerator classNameGenerator = new ClassNameGenerator(AotTestContextInitializers.class);
244244
DefaultGenerationContext generationContext =
245245
new DefaultGenerationContext(classNameGenerator, this.generatedFiles, this.runtimeHints);
246246
GeneratedClasses generatedClasses = generationContext.getGeneratedClasses();
247247

248-
TestAotMappingsCodeGenerator codeGenerator =
249-
new TestAotMappingsCodeGenerator(initializerClassMappings, generatedClasses);
248+
AotTestContextInitializersCodeGenerator codeGenerator =
249+
new AotTestContextInitializersCodeGenerator(initializerClassMappings, generatedClasses);
250250
generationContext.writeGeneratedContent();
251251
String className = codeGenerator.getGeneratedClass().getName().reflectionName();
252252
registerPublicMethods(className);

spring-test/src/main/java/org/springframework/test/context/cache/DefaultCacheAwareContextLoaderDelegate.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.springframework.test.context.MergedContextConfiguration;
3333
import org.springframework.test.context.SmartContextLoader;
3434
import org.springframework.test.context.aot.AotContextLoader;
35-
import org.springframework.test.context.aot.TestAotMappings;
35+
import org.springframework.test.context.aot.AotTestContextInitializers;
3636
import org.springframework.test.context.aot.TestContextAotException;
3737
import org.springframework.util.Assert;
3838

@@ -57,7 +57,7 @@ public class DefaultCacheAwareContextLoaderDelegate implements CacheAwareContext
5757
static final ContextCache defaultContextCache = new DefaultContextCache();
5858

5959
@Nullable
60-
private final TestAotMappings testAotMappings = getTestAotMappings();
60+
private final AotTestContextInitializers aotTestContextInitializers = getAotTestContextInitializers();
6161

6262
private final ContextCache contextCache;
6363

@@ -168,7 +168,7 @@ protected ApplicationContext loadContextInternal(MergedContextConfiguration merg
168168
protected ApplicationContext loadContextInAotMode(MergedContextConfiguration mergedConfig) throws Exception {
169169
Class<?> testClass = mergedConfig.getTestClass();
170170
ApplicationContextInitializer<ConfigurableApplicationContext> contextInitializer =
171-
this.testAotMappings.getContextInitializer(testClass);
171+
this.aotTestContextInitializers.getContextInitializer(testClass);
172172
Assert.state(contextInitializer != null,
173173
() -> "Failed to load AOT ApplicationContextInitializer for test class [%s]"
174174
.formatted(testClass.getName()));
@@ -200,17 +200,18 @@ private ContextLoader getContextLoader(MergedContextConfiguration mergedConfig)
200200
* Determine if we are running in AOT mode for the supplied test class.
201201
*/
202202
private boolean runningInAotMode(Class<?> testClass) {
203-
return (this.testAotMappings != null && this.testAotMappings.isSupportedTestClass(testClass));
203+
return (this.aotTestContextInitializers != null &&
204+
this.aotTestContextInitializers.isSupportedTestClass(testClass));
204205
}
205206

206207
@Nullable
207-
private static TestAotMappings getTestAotMappings() {
208+
private static AotTestContextInitializers getAotTestContextInitializers() {
208209
if (AotDetector.useGeneratedArtifacts()) {
209210
try {
210-
return new TestAotMappings();
211+
return new AotTestContextInitializers();
211212
}
212213
catch (Exception ex) {
213-
throw new IllegalStateException("Failed to instantiate TestAotMappings", ex);
214+
throw new IllegalStateException("Failed to instantiate AotTestContextInitializers", ex);
214215
}
215216
}
216217
return null;

spring-test/src/main/java/org/springframework/test/context/support/DependencyInjectionTestExecutionListener.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.springframework.core.Conventions;
2929
import org.springframework.lang.Nullable;
3030
import org.springframework.test.context.TestContext;
31-
import org.springframework.test.context.aot.TestAotMappings;
31+
import org.springframework.test.context.aot.AotTestContextInitializers;
3232

3333
/**
3434
* {@code TestExecutionListener} which provides support for dependency
@@ -61,7 +61,7 @@ public class DependencyInjectionTestExecutionListener extends AbstractTestExecut
6161
private static final Log logger = LogFactory.getLog(DependencyInjectionTestExecutionListener.class);
6262

6363
@Nullable
64-
private final TestAotMappings testAotMappings = getTestAotMappings();
64+
private final AotTestContextInitializers aotTestContextInitializers = getAotTestContextInitializers();
6565

6666

6767
/**
@@ -162,17 +162,18 @@ private void injectDependenciesInAotMode(TestContext testContext) throws Excepti
162162
* Determine if we are running in AOT mode for the supplied test class.
163163
*/
164164
private boolean runningInAotMode(Class<?> testClass) {
165-
return (this.testAotMappings != null && this.testAotMappings.isSupportedTestClass(testClass));
165+
return (this.aotTestContextInitializers != null &&
166+
this.aotTestContextInitializers.isSupportedTestClass(testClass));
166167
}
167168

168169
@Nullable
169-
private static TestAotMappings getTestAotMappings() {
170+
private static AotTestContextInitializers getAotTestContextInitializers() {
170171
if (AotDetector.useGeneratedArtifacts()) {
171172
try {
172-
return new TestAotMappings();
173+
return new AotTestContextInitializers();
173174
}
174175
catch (Exception ex) {
175-
throw new IllegalStateException("Failed to instantiate TestAotMappings", ex);
176+
throw new IllegalStateException("Failed to instantiate AotTestContextInitializers", ex);
176177
}
177178
}
178179
return null;

spring-test/src/test/java/org/springframework/test/context/aot/AbstractAotTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ abstract class AbstractAotTests {
3131

3232
static final String[] expectedSourceFilesForBasicSpringTests = {
3333
// Global
34-
"org/springframework/test/context/aot/TestAotMappings__Generated.java",
34+
"org/springframework/test/context/aot/AotTestContextInitializers__Generated.java",
3535
"org/springframework/test/context/aot/AotTestAttributes__Generated.java",
3636
// BasicSpringJupiterSharedConfigTests
3737
"org/springframework/context/event/DefaultEventListenerFactory__TestContext001_BeanDefinitions.java",

spring-test/src/test/java/org/springframework/test/context/aot/TestContextAotGeneratorTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
import static org.springframework.test.web.servlet.setup.MockMvcBuilders.webAppContextSetup;
7575

7676
/**
77-
* Tests for {@link TestContextAotGenerator}, {@link TestAotMappings},
77+
* Tests for {@link TestContextAotGenerator}, {@link AotTestContextInitializers},
7878
* {@link AotTestAttributes}, {@link AotContextLoader}, and run-time hints.
7979
*
8080
* @author Sam Brannen
@@ -126,11 +126,11 @@ void endToEndTests() {
126126
assertThat(aotAttributes.getString("bogus")).isNull();
127127
assertThat(aotAttributes.getBoolean("bogus")).isFalse();
128128

129-
TestAotMappings testAotMappings = new TestAotMappings();
129+
AotTestContextInitializers aotContextInitializers = new AotTestContextInitializers();
130130
for (Class<?> testClass : testClasses) {
131131
MergedContextConfiguration mergedConfig = buildMergedContextConfiguration(testClass);
132132
ApplicationContextInitializer<ConfigurableApplicationContext> contextInitializer =
133-
testAotMappings.getContextInitializer(testClass);
133+
aotContextInitializers.getContextInitializer(testClass);
134134
assertThat(contextInitializer).isNotNull();
135135
ApplicationContext context = ((AotContextLoader) mergedConfig.getContextLoader())
136136
.loadContextForAotRuntime(mergedConfig, contextInitializer);
@@ -153,7 +153,7 @@ else if (testClass.getPackageName().contains("jdbc")) {
153153
}
154154

155155
private static void assertRuntimeHints(RuntimeHints runtimeHints) {
156-
assertReflectionRegistered(runtimeHints, TestAotMappings.GENERATED_MAPPINGS_CLASS_NAME, INVOKE_PUBLIC_METHODS);
156+
assertReflectionRegistered(runtimeHints, AotTestContextInitializers.GENERATED_MAPPINGS_CLASS_NAME, INVOKE_PUBLIC_METHODS);
157157
assertReflectionRegistered(runtimeHints, AotTestAttributesCodeGenerator.GENERATED_ATTRIBUTES_CLASS_NAME, INVOKE_PUBLIC_METHODS);
158158

159159
Stream.of(
@@ -356,7 +356,7 @@ record Mapping(MergedContextConfiguration mergedConfig, ClassName className) {
356356

357357
private static final String[] expectedSourceFiles = {
358358
// Global
359-
"org/springframework/test/context/aot/TestAotMappings__Generated.java",
359+
"org/springframework/test/context/aot/AotTestContextInitializers__Generated.java",
360360
"org/springframework/test/context/aot/AotTestAttributes__Generated.java",
361361
// BasicSpringJupiterSharedConfigTests
362362
"org/springframework/context/event/DefaultEventListenerFactory__TestContext001_BeanDefinitions.java",

0 commit comments

Comments
 (0)