Skip to content

Commit de33056

Browse files
committed
Use new features from JUnit Jupiter 5.11
This commit migrates additional parameterized tests (that were missed in the previous commit) to the new argumentSet() feature. See gh-33395
1 parent a9a1798 commit de33056

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

spring-web/src/test/java/org/springframework/web/client/RestClientIntegrationTests.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333
import okhttp3.mockwebserver.MockWebServer;
3434
import okhttp3.mockwebserver.RecordedRequest;
3535
import org.junit.jupiter.api.AfterEach;
36-
import org.junit.jupiter.api.Named;
3736
import org.junit.jupiter.params.ParameterizedTest;
37+
import org.junit.jupiter.params.provider.Arguments;
3838
import org.junit.jupiter.params.provider.MethodSource;
3939

4040
import org.springframework.core.ParameterizedTypeReference;
@@ -59,7 +59,7 @@
5959
import static org.assertj.core.api.Assertions.assertThat;
6060
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
6161
import static org.junit.jupiter.api.Assumptions.assumeFalse;
62-
import static org.junit.jupiter.api.Named.named;
62+
import static org.junit.jupiter.params.provider.Arguments.argumentSet;
6363

6464
/**
6565
* Integration tests for {@link RestClient}.
@@ -71,20 +71,20 @@ class RestClientIntegrationTests {
7171

7272
@Retention(RetentionPolicy.RUNTIME)
7373
@Target(ElementType.METHOD)
74-
@ParameterizedTest(name = "[{index}] {0}")
74+
@ParameterizedTest
7575
@MethodSource("clientHttpRequestFactories")
7676
@interface ParameterizedRestClientTest {
7777
}
7878

7979
@SuppressWarnings("removal")
80-
static Stream<Named<ClientHttpRequestFactory>> clientHttpRequestFactories() {
80+
static Stream<Arguments> clientHttpRequestFactories() {
8181
return Stream.of(
82-
named("JDK HttpURLConnection", new SimpleClientHttpRequestFactory()),
83-
named("HttpComponents", new HttpComponentsClientHttpRequestFactory()),
84-
named("OkHttp", new org.springframework.http.client.OkHttp3ClientHttpRequestFactory()),
85-
named("Jetty", new JettyClientHttpRequestFactory()),
86-
named("JDK HttpClient", new JdkClientHttpRequestFactory()),
87-
named("Reactor Netty", new ReactorNettyClientRequestFactory())
82+
argumentSet("JDK HttpURLConnection", new SimpleClientHttpRequestFactory()),
83+
argumentSet("HttpComponents", new HttpComponentsClientHttpRequestFactory()),
84+
argumentSet("OkHttp", new org.springframework.http.client.OkHttp3ClientHttpRequestFactory()),
85+
argumentSet("Jetty", new JettyClientHttpRequestFactory()),
86+
argumentSet("JDK HttpClient", new JdkClientHttpRequestFactory()),
87+
argumentSet("Reactor Netty", new ReactorNettyClientRequestFactory())
8888
);
8989
}
9090

spring-web/src/test/java/org/springframework/web/client/RestTemplateIntegrationTests.java

+10-10
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@
3030
import com.fasterxml.jackson.annotation.JsonTypeInfo;
3131
import com.fasterxml.jackson.annotation.JsonTypeName;
3232
import com.fasterxml.jackson.annotation.JsonView;
33-
import org.junit.jupiter.api.Named;
3433
import org.junit.jupiter.api.extension.RegisterExtension;
3534
import org.junit.jupiter.api.extension.TestExecutionExceptionHandler;
3635
import org.junit.jupiter.params.ParameterizedTest;
36+
import org.junit.jupiter.params.provider.Arguments;
3737
import org.junit.jupiter.params.provider.MethodSource;
3838

3939
import org.springframework.core.ParameterizedTypeReference;
@@ -60,7 +60,7 @@
6060
import static org.assertj.core.api.Assertions.assertThat;
6161
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
6262
import static org.junit.jupiter.api.Assumptions.assumeFalse;
63-
import static org.junit.jupiter.api.Named.named;
63+
import static org.junit.jupiter.params.provider.Arguments.argumentSet;
6464
import static org.springframework.http.HttpMethod.POST;
6565
import static org.springframework.http.MediaType.MULTIPART_MIXED;
6666

@@ -85,20 +85,20 @@ class RestTemplateIntegrationTests extends AbstractMockWebServerTests {
8585

8686
@Retention(RetentionPolicy.RUNTIME)
8787
@Target(ElementType.METHOD)
88-
@ParameterizedTest(name = "[{index}] {0}")
88+
@ParameterizedTest
8989
@MethodSource("clientHttpRequestFactories")
9090
@interface ParameterizedRestTemplateTest {
9191
}
9292

9393
@SuppressWarnings("removal")
94-
static Stream<Named<ClientHttpRequestFactory>> clientHttpRequestFactories() {
94+
static Stream<Arguments> clientHttpRequestFactories() {
9595
return Stream.of(
96-
named("JDK HttpURLConnection", new SimpleClientHttpRequestFactory()),
97-
named("HttpComponents", new HttpComponentsClientHttpRequestFactory()),
98-
named("OkHttp", new org.springframework.http.client.OkHttp3ClientHttpRequestFactory()),
99-
named("Jetty", new JettyClientHttpRequestFactory()),
100-
named("JDK HttpClient", new JdkClientHttpRequestFactory()),
101-
named("Reactor Netty", new ReactorNettyClientRequestFactory())
96+
argumentSet("JDK HttpURLConnection", new SimpleClientHttpRequestFactory()),
97+
argumentSet("HttpComponents", new HttpComponentsClientHttpRequestFactory()),
98+
argumentSet("OkHttp", new org.springframework.http.client.OkHttp3ClientHttpRequestFactory()),
99+
argumentSet("Jetty", new JettyClientHttpRequestFactory()),
100+
argumentSet("JDK HttpClient", new JdkClientHttpRequestFactory()),
101+
argumentSet("Reactor Netty", new ReactorNettyClientRequestFactory())
102102
);
103103
}
104104

0 commit comments

Comments
 (0)