Skip to content

Commit c462fe3

Browse files
sbrannensbrannen
committed
Use Named arguments in parameterized tests
1 parent 8a0c4ca commit c462fe3

File tree

28 files changed

+416
-366
lines changed

28 files changed

+416
-366
lines changed

‎spring-core/src/test/java/org/springframework/core/io/buffer/DataBufferTests.java

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2020 the original author or authors.
2+
* Copyright 2002-2022 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -35,7 +35,7 @@
3535
class DataBufferTests extends AbstractDataBufferAllocatingTests {
3636

3737
@ParameterizedDataBufferAllocatingTest
38-
void byteCountsAndPositions(String displayName, DataBufferFactory bufferFactory) {
38+
void byteCountsAndPositions(DataBufferFactory bufferFactory) {
3939
super.bufferFactory = bufferFactory;
4040

4141
DataBuffer buffer = createDataBuffer(2);
@@ -78,7 +78,7 @@ void byteCountsAndPositions(String displayName, DataBufferFactory bufferFactory)
7878
}
7979

8080
@ParameterizedDataBufferAllocatingTest
81-
void readPositionSmallerThanZero(String displayName, DataBufferFactory bufferFactory) {
81+
void readPositionSmallerThanZero(DataBufferFactory bufferFactory) {
8282
super.bufferFactory = bufferFactory;
8383

8484
DataBuffer buffer = createDataBuffer(1);
@@ -92,7 +92,7 @@ void readPositionSmallerThanZero(String displayName, DataBufferFactory bufferFac
9292
}
9393

9494
@ParameterizedDataBufferAllocatingTest
95-
void readPositionGreaterThanWritePosition(String displayName, DataBufferFactory bufferFactory) {
95+
void readPositionGreaterThanWritePosition(DataBufferFactory bufferFactory) {
9696
super.bufferFactory = bufferFactory;
9797

9898
DataBuffer buffer = createDataBuffer(1);
@@ -106,7 +106,7 @@ void readPositionGreaterThanWritePosition(String displayName, DataBufferFactory
106106
}
107107

108108
@ParameterizedDataBufferAllocatingTest
109-
void writePositionSmallerThanReadPosition(String displayName, DataBufferFactory bufferFactory) {
109+
void writePositionSmallerThanReadPosition(DataBufferFactory bufferFactory) {
110110
super.bufferFactory = bufferFactory;
111111

112112
DataBuffer buffer = createDataBuffer(2);
@@ -122,7 +122,7 @@ void writePositionSmallerThanReadPosition(String displayName, DataBufferFactory
122122
}
123123

124124
@ParameterizedDataBufferAllocatingTest
125-
void writePositionGreaterThanCapacity(String displayName, DataBufferFactory bufferFactory) {
125+
void writePositionGreaterThanCapacity(DataBufferFactory bufferFactory) {
126126
super.bufferFactory = bufferFactory;
127127

128128
DataBuffer buffer = createDataBuffer(1);
@@ -136,7 +136,7 @@ void writePositionGreaterThanCapacity(String displayName, DataBufferFactory buff
136136
}
137137

138138
@ParameterizedDataBufferAllocatingTest
139-
void writeAndRead(String displayName, DataBufferFactory bufferFactory) {
139+
void writeAndRead(DataBufferFactory bufferFactory) {
140140
super.bufferFactory = bufferFactory;
141141

142142
DataBuffer buffer = createDataBuffer(5);
@@ -157,7 +157,7 @@ void writeAndRead(String displayName, DataBufferFactory bufferFactory) {
157157
}
158158

159159
@ParameterizedDataBufferAllocatingTest
160-
void writeNullString(String displayName, DataBufferFactory bufferFactory) {
160+
void writeNullString(DataBufferFactory bufferFactory) {
161161
super.bufferFactory = bufferFactory;
162162

163163
DataBuffer buffer = createDataBuffer(1);
@@ -171,7 +171,7 @@ void writeNullString(String displayName, DataBufferFactory bufferFactory) {
171171
}
172172

173173
@ParameterizedDataBufferAllocatingTest
174-
void writeNullCharset(String displayName, DataBufferFactory bufferFactory) {
174+
void writeNullCharset(DataBufferFactory bufferFactory) {
175175
super.bufferFactory = bufferFactory;
176176

177177
DataBuffer buffer = createDataBuffer(1);
@@ -185,7 +185,7 @@ void writeNullCharset(String displayName, DataBufferFactory bufferFactory) {
185185
}
186186

187187
@ParameterizedDataBufferAllocatingTest
188-
void writeEmptyString(String displayName, DataBufferFactory bufferFactory) {
188+
void writeEmptyString(DataBufferFactory bufferFactory) {
189189
super.bufferFactory = bufferFactory;
190190

191191
DataBuffer buffer = createDataBuffer(1);
@@ -197,7 +197,7 @@ void writeEmptyString(String displayName, DataBufferFactory bufferFactory) {
197197
}
198198

199199
@ParameterizedDataBufferAllocatingTest
200-
void writeUtf8String(String displayName, DataBufferFactory bufferFactory) {
200+
void writeUtf8String(DataBufferFactory bufferFactory) {
201201
super.bufferFactory = bufferFactory;
202202

203203
DataBuffer buffer = createDataBuffer(6);
@@ -211,7 +211,7 @@ void writeUtf8String(String displayName, DataBufferFactory bufferFactory) {
211211
}
212212

213213
@ParameterizedDataBufferAllocatingTest
214-
void writeUtf8StringOutGrowsCapacity(String displayName, DataBufferFactory bufferFactory) {
214+
void writeUtf8StringOutGrowsCapacity(DataBufferFactory bufferFactory) {
215215
super.bufferFactory = bufferFactory;
216216

217217
DataBuffer buffer = createDataBuffer(5);
@@ -225,7 +225,7 @@ void writeUtf8StringOutGrowsCapacity(String displayName, DataBufferFactory buffe
225225
}
226226

227227
@ParameterizedDataBufferAllocatingTest
228-
void writeIsoString(String displayName, DataBufferFactory bufferFactory) {
228+
void writeIsoString(DataBufferFactory bufferFactory) {
229229
super.bufferFactory = bufferFactory;
230230

231231
DataBuffer buffer = createDataBuffer(3);
@@ -239,7 +239,7 @@ void writeIsoString(String displayName, DataBufferFactory bufferFactory) {
239239
}
240240

241241
@ParameterizedDataBufferAllocatingTest
242-
void writeMultipleUtf8String(String displayName, DataBufferFactory bufferFactory) {
242+
void writeMultipleUtf8String(DataBufferFactory bufferFactory) {
243243
super.bufferFactory = bufferFactory;
244244

245245
DataBuffer buffer = createDataBuffer(1);
@@ -261,7 +261,7 @@ void writeMultipleUtf8String(String displayName, DataBufferFactory bufferFactory
261261
}
262262

263263
@ParameterizedDataBufferAllocatingTest
264-
void toStringNullCharset(String displayName, DataBufferFactory bufferFactory) {
264+
void toStringNullCharset(DataBufferFactory bufferFactory) {
265265
super.bufferFactory = bufferFactory;
266266

267267
DataBuffer buffer = createDataBuffer(1);
@@ -275,7 +275,7 @@ void toStringNullCharset(String displayName, DataBufferFactory bufferFactory) {
275275
}
276276

277277
@ParameterizedDataBufferAllocatingTest
278-
void toStringUtf8(String displayName, DataBufferFactory bufferFactory) {
278+
void toStringUtf8(DataBufferFactory bufferFactory) {
279279
super.bufferFactory = bufferFactory;
280280

281281
String spring = "Spring";
@@ -290,7 +290,7 @@ void toStringUtf8(String displayName, DataBufferFactory bufferFactory) {
290290
}
291291

292292
@ParameterizedDataBufferAllocatingTest
293-
void toStringSection(String displayName, DataBufferFactory bufferFactory) {
293+
void toStringSection(DataBufferFactory bufferFactory) {
294294
super.bufferFactory = bufferFactory;
295295

296296
String spring = "Spring";
@@ -305,7 +305,7 @@ void toStringSection(String displayName, DataBufferFactory bufferFactory) {
305305
}
306306

307307
@ParameterizedDataBufferAllocatingTest
308-
void inputStream(String displayName, DataBufferFactory bufferFactory) throws Exception {
308+
void inputStream(DataBufferFactory bufferFactory) throws Exception {
309309
super.bufferFactory = bufferFactory;
310310

311311
DataBuffer buffer = createDataBuffer(4);
@@ -339,7 +339,7 @@ void inputStream(String displayName, DataBufferFactory bufferFactory) throws Exc
339339
}
340340

341341
@ParameterizedDataBufferAllocatingTest
342-
void inputStreamReleaseOnClose(String displayName, DataBufferFactory bufferFactory) throws Exception {
342+
void inputStreamReleaseOnClose(DataBufferFactory bufferFactory) throws Exception {
343343
super.bufferFactory = bufferFactory;
344344

345345
DataBuffer buffer = createDataBuffer(3);
@@ -357,7 +357,7 @@ void inputStreamReleaseOnClose(String displayName, DataBufferFactory bufferFacto
357357
}
358358

359359
@ParameterizedDataBufferAllocatingTest
360-
void outputStream(String displayName, DataBufferFactory bufferFactory) throws Exception {
360+
void outputStream(DataBufferFactory bufferFactory) throws Exception {
361361
super.bufferFactory = bufferFactory;
362362

363363
DataBuffer buffer = createDataBuffer(4);
@@ -377,7 +377,7 @@ void outputStream(String displayName, DataBufferFactory bufferFactory) throws Ex
377377
}
378378

379379
@ParameterizedDataBufferAllocatingTest
380-
void expand(String displayName, DataBufferFactory bufferFactory) {
380+
void expand(DataBufferFactory bufferFactory) {
381381
super.bufferFactory = bufferFactory;
382382

383383
DataBuffer buffer = createDataBuffer(1);
@@ -391,7 +391,7 @@ void expand(String displayName, DataBufferFactory bufferFactory) {
391391
}
392392

393393
@ParameterizedDataBufferAllocatingTest
394-
void increaseCapacity(String displayName, DataBufferFactory bufferFactory) {
394+
void increaseCapacity(DataBufferFactory bufferFactory) {
395395
super.bufferFactory = bufferFactory;
396396

397397
DataBuffer buffer = createDataBuffer(1);
@@ -404,7 +404,7 @@ void increaseCapacity(String displayName, DataBufferFactory bufferFactory) {
404404
}
405405

406406
@ParameterizedDataBufferAllocatingTest
407-
void decreaseCapacityLowReadPosition(String displayName, DataBufferFactory bufferFactory) {
407+
void decreaseCapacityLowReadPosition(DataBufferFactory bufferFactory) {
408408
super.bufferFactory = bufferFactory;
409409

410410
DataBuffer buffer = createDataBuffer(2);
@@ -416,7 +416,7 @@ void decreaseCapacityLowReadPosition(String displayName, DataBufferFactory buffe
416416
}
417417

418418
@ParameterizedDataBufferAllocatingTest
419-
void decreaseCapacityHighReadPosition(String displayName, DataBufferFactory bufferFactory) {
419+
void decreaseCapacityHighReadPosition(DataBufferFactory bufferFactory) {
420420
super.bufferFactory = bufferFactory;
421421

422422
DataBuffer buffer = createDataBuffer(2);
@@ -429,7 +429,7 @@ void decreaseCapacityHighReadPosition(String displayName, DataBufferFactory buff
429429
}
430430

431431
@ParameterizedDataBufferAllocatingTest
432-
void capacityLessThanZero(String displayName, DataBufferFactory bufferFactory) {
432+
void capacityLessThanZero(DataBufferFactory bufferFactory) {
433433
super.bufferFactory = bufferFactory;
434434

435435
DataBuffer buffer = createDataBuffer(1);
@@ -443,7 +443,7 @@ void capacityLessThanZero(String displayName, DataBufferFactory bufferFactory) {
443443
}
444444

445445
@ParameterizedDataBufferAllocatingTest
446-
void writeByteBuffer(String displayName, DataBufferFactory bufferFactory) {
446+
void writeByteBuffer(DataBufferFactory bufferFactory) {
447447
super.bufferFactory = bufferFactory;
448448

449449
DataBuffer buffer1 = createDataBuffer(1);
@@ -472,7 +472,7 @@ private ByteBuffer createByteBuffer(int capacity) {
472472
}
473473

474474
@ParameterizedDataBufferAllocatingTest
475-
void writeDataBuffer(String displayName, DataBufferFactory bufferFactory) {
475+
void writeDataBuffer(DataBufferFactory bufferFactory) {
476476
super.bufferFactory = bufferFactory;
477477

478478
DataBuffer buffer1 = createDataBuffer(1);
@@ -495,7 +495,7 @@ void writeDataBuffer(String displayName, DataBufferFactory bufferFactory) {
495495
}
496496

497497
@ParameterizedDataBufferAllocatingTest
498-
void asByteBuffer(String displayName, DataBufferFactory bufferFactory) {
498+
void asByteBuffer(DataBufferFactory bufferFactory) {
499499
super.bufferFactory = bufferFactory;
500500

501501
DataBuffer buffer = createDataBuffer(4);
@@ -516,7 +516,7 @@ void asByteBuffer(String displayName, DataBufferFactory bufferFactory) {
516516
}
517517

518518
@ParameterizedDataBufferAllocatingTest
519-
void asByteBufferIndexLength(String displayName, DataBufferFactory bufferFactory) {
519+
void asByteBufferIndexLength(DataBufferFactory bufferFactory) {
520520
super.bufferFactory = bufferFactory;
521521

522522
DataBuffer buffer = createDataBuffer(3);
@@ -536,7 +536,7 @@ void asByteBufferIndexLength(String displayName, DataBufferFactory bufferFactory
536536
}
537537

538538
@ParameterizedDataBufferAllocatingTest
539-
void byteBufferContainsDataBufferChanges(String displayName, DataBufferFactory bufferFactory) {
539+
void byteBufferContainsDataBufferChanges(DataBufferFactory bufferFactory) {
540540
super.bufferFactory = bufferFactory;
541541

542542
DataBuffer dataBuffer = createDataBuffer(1);
@@ -552,7 +552,7 @@ void byteBufferContainsDataBufferChanges(String displayName, DataBufferFactory b
552552
}
553553

554554
@ParameterizedDataBufferAllocatingTest
555-
void dataBufferContainsByteBufferChanges(String displayName, DataBufferFactory bufferFactory) {
555+
void dataBufferContainsByteBufferChanges(DataBufferFactory bufferFactory) {
556556
super.bufferFactory = bufferFactory;
557557

558558
DataBuffer dataBuffer = createDataBuffer(1);
@@ -568,7 +568,7 @@ void dataBufferContainsByteBufferChanges(String displayName, DataBufferFactory b
568568
}
569569

570570
@ParameterizedDataBufferAllocatingTest
571-
void emptyAsByteBuffer(String displayName, DataBufferFactory bufferFactory) {
571+
void emptyAsByteBuffer(DataBufferFactory bufferFactory) {
572572
super.bufferFactory = bufferFactory;
573573

574574
DataBuffer buffer = createDataBuffer(1);
@@ -580,7 +580,7 @@ void emptyAsByteBuffer(String displayName, DataBufferFactory bufferFactory) {
580580
}
581581

582582
@ParameterizedDataBufferAllocatingTest
583-
void indexOf(String displayName, DataBufferFactory bufferFactory) {
583+
void indexOf(DataBufferFactory bufferFactory) {
584584
super.bufferFactory = bufferFactory;
585585

586586
DataBuffer buffer = createDataBuffer(3);
@@ -602,7 +602,7 @@ void indexOf(String displayName, DataBufferFactory bufferFactory) {
602602
}
603603

604604
@ParameterizedDataBufferAllocatingTest
605-
void lastIndexOf(String displayName, DataBufferFactory bufferFactory) {
605+
void lastIndexOf(DataBufferFactory bufferFactory) {
606606
super.bufferFactory = bufferFactory;
607607

608608
DataBuffer buffer = createDataBuffer(3);
@@ -633,7 +633,7 @@ void lastIndexOf(String displayName, DataBufferFactory bufferFactory) {
633633
}
634634

635635
@ParameterizedDataBufferAllocatingTest
636-
void slice(String displayName, DataBufferFactory bufferFactory) {
636+
void slice(DataBufferFactory bufferFactory) {
637637
super.bufferFactory = bufferFactory;
638638

639639
DataBuffer buffer = createDataBuffer(3);
@@ -662,7 +662,7 @@ void slice(String displayName, DataBufferFactory bufferFactory) {
662662
}
663663

664664
@ParameterizedDataBufferAllocatingTest
665-
void retainedSlice(String displayName, DataBufferFactory bufferFactory) {
665+
void retainedSlice(DataBufferFactory bufferFactory) {
666666
super.bufferFactory = bufferFactory;
667667

668668
DataBuffer buffer = createDataBuffer(3);
@@ -691,7 +691,7 @@ void retainedSlice(String displayName, DataBufferFactory bufferFactory) {
691691
}
692692

693693
@ParameterizedDataBufferAllocatingTest
694-
void spr16351(String displayName, DataBufferFactory bufferFactory) {
694+
void spr16351(DataBufferFactory bufferFactory) {
695695
super.bufferFactory = bufferFactory;
696696

697697
DataBuffer buffer = createDataBuffer(6);
@@ -711,7 +711,7 @@ void spr16351(String displayName, DataBufferFactory bufferFactory) {
711711
}
712712

713713
@ParameterizedDataBufferAllocatingTest
714-
void join(String displayName, DataBufferFactory bufferFactory) {
714+
void join(DataBufferFactory bufferFactory) {
715715
super.bufferFactory = bufferFactory;
716716

717717
DataBuffer composite = this.bufferFactory.join(Arrays.asList(stringBuffer("a"),
@@ -726,7 +726,7 @@ void join(String displayName, DataBufferFactory bufferFactory) {
726726
}
727727

728728
@ParameterizedDataBufferAllocatingTest
729-
void getByte(String displayName, DataBufferFactory bufferFactory) {
729+
void getByte(DataBufferFactory bufferFactory) {
730730
super.bufferFactory = bufferFactory;
731731

732732
DataBuffer buffer = stringBuffer("abc");

0 commit comments

Comments
 (0)