Polish "Allow batch update to take a KeyHolder"

See gh-28132

Author: snicoll

spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcOperations.java

@@ -1014,9 +1014,11 @@ <T> List<T> queryForList(String sql, Object[] args, int[] argTypes, Class<T> ele
 	 * (may also contain special JDBC-defined negative values for affected rows such as
 	 * {@link java.sql.Statement#SUCCESS_NO_INFO}/{@link java.sql.Statement#EXECUTE_FAILED})
 	 * @throws DataAccessException if there is any problem issuing the update
+	 * @since 6.1
 	 * @see org.springframework.jdbc.support.GeneratedKeyHolder
 	 */
-	int[] batchUpdate(PreparedStatementCreator psc, BatchPreparedStatementSetter pss, KeyHolder generatedKeyHolder) throws DataAccessException;
+	int[] batchUpdate(PreparedStatementCreator psc, BatchPreparedStatementSetter pss,
+			KeyHolder generatedKeyHolder) throws DataAccessException;
 
 	/**
 	 * Execute a batch using the supplied SQL statement with the batch of supplied arguments.

spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java

@@ -1021,7 +1021,9 @@ public int update(String sql, @Nullable Object... args) throws DataAccessExcepti
 	}
 
 	@Override
-	public int[] batchUpdate(final PreparedStatementCreator psc, final BatchPreparedStatementSetter pss, final KeyHolder generatedKeyHolder) throws DataAccessException {
+	public int[] batchUpdate(final PreparedStatementCreator psc, final BatchPreparedStatementSetter pss,
+			final KeyHolder generatedKeyHolder) throws DataAccessException {
+
 		int[] result = execute(psc, getPreparedStatementCallback(pss, generatedKeyHolder));
 
 		Assert.state(result != null, "No result array");

spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcOperations.java

@@ -556,8 +556,8 @@ int update(String sql, SqlParameterSource paramSource, KeyHolder generatedKeyHol
 	int[] batchUpdate(String sql, SqlParameterSource[] batchArgs);
 
 	/**
-	 * Execute a batch using the supplied SQL statement with the batch of supplied arguments,
-	 * returning generated keys.
+	 * Execute a batch using the supplied SQL statement with the batch of supplied
+	 * arguments, returning generated keys.
 	 * @param sql the SQL statement to execute
 	 * @param batchArgs the array of {@link SqlParameterSource} containing the batch of
 	 * arguments for the query
@@ -566,6 +566,7 @@ int update(String sql, SqlParameterSource paramSource, KeyHolder generatedKeyHol
 	 * (may also contain special JDBC-defined negative values for affected rows such as
 	 * {@link java.sql.Statement#SUCCESS_NO_INFO}/{@link java.sql.Statement#EXECUTE_FAILED})
 	 * @throws DataAccessException if there is any problem issuing the update
+	 * @since 6.1
 	 * @see org.springframework.jdbc.support.GeneratedKeyHolder
 	 */
 	int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder generatedKeyHolder);
@@ -582,7 +583,9 @@ int update(String sql, SqlParameterSource paramSource, KeyHolder generatedKeyHol
 	 * (may also contain special JDBC-defined negative values for affected rows such as
 	 * {@link java.sql.Statement#SUCCESS_NO_INFO}/{@link java.sql.Statement#EXECUTE_FAILED})
 	 * @throws DataAccessException if there is any problem issuing the update
+	 * @since 6.1
 	 * @see org.springframework.jdbc.support.GeneratedKeyHolder
 	 */
-	int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder generatedKeyHolder, String[] keyColumnNames);
+	int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder generatedKeyHolder,
+			String[] keyColumnNames);
 }

spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcTemplate.java

@@ -400,7 +400,9 @@ public int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder g
 	}
 
 	@Override
-	public int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder generatedKeyHolder, String[] keyColumnNames) {
+	public int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder generatedKeyHolder,
+			@Nullable String[] keyColumnNames) {
+
 		if (batchArgs.length == 0) {
 			return new int[0];
 		}
@@ -416,20 +418,18 @@ public int[] batchUpdate(String sql, SqlParameterSource[] batchArgs, KeyHolder g
 		}
 		Object[] params = NamedParameterUtils.buildValueArray(parsedSql, paramSource, null);
 		PreparedStatementCreator psc = pscf.newPreparedStatementCreator(params);
-		return getJdbcOperations().batchUpdate(
-				psc,
-				new BatchPreparedStatementSetter() {
-					@Override
-					public void setValues(PreparedStatement ps, int i) throws SQLException {
-						Object[] values = NamedParameterUtils.buildValueArray(parsedSql, batchArgs[i], null);
-						pscf.newPreparedStatementSetter(values).setValues(ps);
-					}
-					@Override
-					public int getBatchSize() {
-						return batchArgs.length;
-					}
-				},
-				generatedKeyHolder);
+		return getJdbcOperations().batchUpdate(psc, new BatchPreparedStatementSetter() {
+			@Override
+			public void setValues(PreparedStatement ps, int i) throws SQLException {
+				Object[] values = NamedParameterUtils.buildValueArray(parsedSql, batchArgs[i], null);
+				pscf.newPreparedStatementSetter(values).setValues(ps);
+			}
+
+			@Override
+			public int getBatchSize() {
+				return batchArgs.length;
+			}
+		}, generatedKeyHolder);
 	}