Skip to content

Commit c09eb63

Browse files
committed
Rename test fixture to avoid class with existing TestBean class
1 parent ba5ab1a commit c09eb63

File tree

3 files changed

+37
-32
lines changed

3 files changed

+37
-32
lines changed

spring-beans/src/test/java/org/springframework/beans/factory/aot/DefaultBeanRegistrationCodeFragmentsTests.java

Lines changed: 32 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -45,38 +45,40 @@ class DefaultBeanRegistrationCodeFragmentsTests {
4545

4646
@Test
4747
void getTargetOnConstructor() {
48-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
48+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
4949
assertThat(createInstance(registeredBean).getTarget(registeredBean,
50-
TestBean.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
50+
SimpleBean.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
5151
}
5252

5353
@Test
5454
void getTargetOnConstructorToPublicFactoryBean() {
55-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
55+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
5656
assertThat(createInstance(registeredBean).getTarget(registeredBean,
57-
TestBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
57+
SimpleBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
5858
}
5959

6060
@Test
6161
void getTargetOnConstructorToProtectedFactoryBean() {
62-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
62+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
6363
assertThat(createInstance(registeredBean).getTarget(registeredBean,
64-
PrivilegedTestBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(PrivilegedTestBeanFactoryBean.class);
64+
PrivilegedTestBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(
65+
PrivilegedTestBeanFactoryBean.class);
6566
}
6667

6768
@Test
6869
void getTargetOnMethod() {
69-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
70-
Method method = ReflectionUtils.findMethod(TestBeanFactoryBean.class, "getObject");
70+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
71+
Method method = ReflectionUtils.findMethod(SimpleBeanFactoryBean.class, "getObject");
7172
assertThat(method).isNotNull();
7273
assertThat(createInstance(registeredBean).getTarget(registeredBean,
73-
method)).isEqualTo(TestBeanFactoryBean.class);
74+
method)).isEqualTo(SimpleBeanFactoryBean.class);
7475
}
7576

7677
@Test
7778
void getTargetOnMethodWithInnerBeanInJavaPackage() {
78-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
79-
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean", new RootBeanDefinition(String.class));
79+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
80+
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean",
81+
new RootBeanDefinition(String.class));
8082
Method method = ReflectionUtils.findMethod(getClass(), "createString");
8183
assertThat(method).isNotNull();
8284
assertThat(createInstance(innerBean).getTarget(innerBean,
@@ -85,45 +87,47 @@ void getTargetOnMethodWithInnerBeanInJavaPackage() {
8587

8688
@Test
8789
void getTargetOnConstructorWithInnerBeanInJavaPackage() {
88-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
90+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
8991
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean", new RootBeanDefinition(String.class));
9092
assertThat(createInstance(innerBean).getTarget(innerBean,
91-
String.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
93+
String.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
9294
}
9395

9496
@Test
9597
void getTargetOnConstructorWithInnerBeanOnTypeInJavaPackage() {
96-
RegisteredBean registeredBean = registerTestBean(TestBean.class);
98+
RegisteredBean registeredBean = registerTestBean(SimpleBean.class);
9799
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean",
98100
new RootBeanDefinition(StringFactoryBean.class));
99101
assertThat(createInstance(innerBean).getTarget(innerBean,
100-
StringFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
102+
StringFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
101103
}
102104

103105
@Test
104106
void getTargetOnMethodWithInnerBeanInRegularPackage() {
105107
RegisteredBean registeredBean = registerTestBean(DummyFactory.class);
106-
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean", new RootBeanDefinition(TestBean.class));
107-
Method method = ReflectionUtils.findMethod(TestBeanFactoryBean.class, "getObject");
108+
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean",
109+
new RootBeanDefinition(SimpleBean.class));
110+
Method method = ReflectionUtils.findMethod(SimpleBeanFactoryBean.class, "getObject");
108111
assertThat(method).isNotNull();
109-
assertThat(createInstance(innerBean).getTarget(innerBean, method)).isEqualTo(TestBeanFactoryBean.class);
112+
assertThat(createInstance(innerBean).getTarget(innerBean, method)).isEqualTo(SimpleBeanFactoryBean.class);
110113
}
111114

112115
@Test
113116
void getTargetOnConstructorWithInnerBeanInRegularPackage() {
114117
RegisteredBean registeredBean = registerTestBean(DummyFactory.class);
115-
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean", new RootBeanDefinition(TestBean.class));
118+
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean",
119+
new RootBeanDefinition(SimpleBean.class));
116120
assertThat(createInstance(innerBean).getTarget(innerBean,
117-
TestBean.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
121+
SimpleBean.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
118122
}
119123

120124
@Test
121125
void getTargetOnConstructorWithInnerBeanOnFactoryBeanOnTypeInRegularPackage() {
122126
RegisteredBean registeredBean = registerTestBean(DummyFactory.class);
123127
RegisteredBean innerBean = RegisteredBean.ofInnerBean(registeredBean, "innerTestBean",
124-
new RootBeanDefinition(TestBean.class));
128+
new RootBeanDefinition(SimpleBean.class));
125129
assertThat(createInstance(innerBean).getTarget(innerBean,
126-
TestBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(TestBean.class);
130+
SimpleBeanFactoryBean.class.getDeclaredConstructors()[0])).isEqualTo(SimpleBean.class);
127131
}
128132

129133

@@ -134,24 +138,25 @@ private RegisteredBean registerTestBean(Class<?> beanType) {
134138
}
135139

136140
private BeanRegistrationCodeFragments createInstance(RegisteredBean registeredBean) {
137-
return new DefaultBeanRegistrationCodeFragments(this.beanRegistrationsCode, registeredBean, new BeanDefinitionMethodGeneratorFactory(this.beanFactory));
141+
return new DefaultBeanRegistrationCodeFragments(this.beanRegistrationsCode, registeredBean,
142+
new BeanDefinitionMethodGeneratorFactory(this.beanFactory));
138143
}
139144

140145
@SuppressWarnings("unused")
141146
static String createString() {
142147
return "Test";
143148
}
144149

145-
static class PrivilegedTestBeanFactoryBean implements FactoryBean<TestBean> {
150+
static class PrivilegedTestBeanFactoryBean implements FactoryBean<SimpleBean> {
146151

147152
@Override
148-
public TestBean getObject() throws Exception {
149-
return new TestBean();
153+
public SimpleBean getObject() throws Exception {
154+
return new SimpleBean();
150155
}
151156

152157
@Override
153158
public Class<?> getObjectType() {
154-
return TestBean.class;
159+
return SimpleBean.class;
155160
}
156161
}
157162

spring-beans/src/testFixtures/java/org/springframework/beans/factory/aot/TestBean.java renamed to spring-beans/src/testFixtures/java/org/springframework/beans/factory/aot/SimpleBean.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@
2121
*
2222
* @author Stephane Nicoll
2323
*/
24-
public class TestBean {
24+
public class SimpleBean {
2525
}

spring-beans/src/testFixtures/java/org/springframework/beans/factory/aot/TestBeanFactoryBean.java renamed to spring-beans/src/testFixtures/java/org/springframework/beans/factory/aot/SimpleBeanFactoryBean.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@
2323
*
2424
* @author Stephane Nicoll
2525
*/
26-
public class TestBeanFactoryBean implements FactoryBean<TestBean> {
26+
public class SimpleBeanFactoryBean implements FactoryBean<SimpleBean> {
2727

2828
@Override
29-
public TestBean getObject() throws Exception {
30-
return new TestBean();
29+
public SimpleBean getObject() throws Exception {
30+
return new SimpleBean();
3131
}
3232

3333
@Override
3434
public Class<?> getObjectType() {
35-
return TestBean.class;
35+
return SimpleBean.class;
3636
}
3737

3838
}

0 commit comments

Comments
 (0)