Skip to content

Commit bd3d7db

Browse files
committed
Merge pull request #22283 from izeye
* pr/22283: Polish AutowireUtils.EXECUTABLE_COMPARATOR
2 parents b0a3a6f + 963cc09 commit bd3d7db

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,8 @@
5252
abstract class AutowireUtils {
5353

5454
private static final Comparator<Executable> EXECUTABLE_COMPARATOR = (e1, e2) -> {
55-
boolean p1 = Modifier.isPublic(e1.getModifiers());
56-
boolean p2 = Modifier.isPublic(e2.getModifiers());
57-
if (p1 != p2) {
58-
return (p1 ? -1 : 1);
59-
}
60-
int c1pl = e1.getParameterCount();
61-
int c2pl = e2.getParameterCount();
62-
return Integer.compare(c2pl, c1pl);
55+
int result = Boolean.compare(Modifier.isPublic(e2.getModifiers()), Modifier.isPublic(e1.getModifiers()));
56+
return result != 0 ? result : Integer.compare(e2.getParameterCount(), e1.getParameterCount());
6357
};
6458

6559

0 commit comments

Comments
 (0)