Polishing

Author: sbrannen

spring-beans/src/main/java/org/springframework/beans/factory/aot/DefaultBeanRegistrationCodeFragments.java

@@ -138,6 +138,7 @@ private RegisteredBean getInnerRegisteredBean(Object value) {
 		return null;
 	}
 
+	@Override
 	public CodeBlock generateSetBeanInstanceSupplierCode(
 			GenerationContext generationContext,
 			BeanRegistrationCode beanRegistrationCode, CodeBlock instanceSupplierCode,

spring-beans/src/test/java/org/springframework/beans/factory/aot/BeanDefinitionMethodGeneratorTests.java

@@ -196,7 +196,7 @@ public CodeBlock generateSetBeanDefinitionPropertiesCode(
 					RootBeanDefinition beanDefinition,
 					Predicate<String> attributeFilter) {
 				return super.generateSetBeanDefinitionPropertiesCode(generationContext,
-						beanRegistrationCode, beanDefinition, name -> "a".equals(name));
+						beanRegistrationCode, beanDefinition, "a"::equals);
 			}
 
 		};

spring-beans/src/test/java/org/springframework/beans/factory/aot/BeanDefinitionPropertiesCodeGeneratorTests.java

@@ -371,7 +371,7 @@ void attributesWhenAllFiltered() {
 	void attributesWhenSomeFiltered() {
 		this.beanDefinition.setAttribute("a", "A");
 		this.beanDefinition.setAttribute("b", "B");
-		Predicate<String> attributeFilter = attribute -> "a".equals(attribute);
+		Predicate<String> attributeFilter = "a"::equals;
 		this.generator = new BeanDefinitionPropertiesCodeGenerator(this.hints,
 				attributeFilter, this.generatedMethods, (name, value) -> null);
 		testCompiledResult(this.beanDefinition, (actual, compiled) -> {

spring-beans/src/test/java/org/springframework/beans/factory/support/DefaultSingletonBeanRegistryTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@ public void testSingletons() {
 		beanRegistry.registerSingleton("tb", tb);
 		assertThat(beanRegistry.getSingleton("tb")).isSameAs(tb);
 
-		TestBean tb2 = (TestBean) beanRegistry.getSingleton("tb2", () -> new TestBean());
+		TestBean tb2 = (TestBean) beanRegistry.getSingleton("tb2", TestBean::new);
 		assertThat(beanRegistry.getSingleton("tb2")).isSameAs(tb2);
 
 		assertThat(beanRegistry.getSingleton("tb")).isSameAs(tb);

spring-context/src/test/java/org/springframework/context/annotation/CommonAnnotationBeanPostProcessorTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -214,7 +214,7 @@ public void testResourceInjectionWithResolvableDependencyType() {
 		bf.registerBeanDefinition("testBean4", tbd);
 
 		bf.registerResolvableDependency(BeanFactory.class, bf);
-		bf.registerResolvableDependency(INestedTestBean.class, (ObjectFactory<Object>) () -> new NestedTestBean());
+		bf.registerResolvableDependency(INestedTestBean.class, (ObjectFactory<Object>) NestedTestBean::new);
 
 		@SuppressWarnings("deprecation")
 		org.springframework.beans.factory.config.PropertyPlaceholderConfigurer ppc = new org.springframework.beans.factory.config.PropertyPlaceholderConfigurer();

spring-context/src/test/java/org/springframework/context/support/ConversionServiceFactoryBeanTests.java

@@ -55,6 +55,8 @@ void createDefaultConversionService() {
 	void createDefaultConversionServiceWithSupplements() {
 		ConversionServiceFactoryBean factory = new ConversionServiceFactoryBean();
 		Set<Object> converters = new HashSet<>();
+		// The following String -> Foo Converter cannot be implemented as a lambda
+		// due to type erasure of the source and target types.
 		converters.add(new Converter<String, Foo>() {
 			@Override
 			public Foo convert(String source) {

spring-core-test/src/main/java/org/springframework/aot/test/generator/file/DynamicFileAssert.java

@@ -49,6 +49,7 @@ public A doesNotContain(CharSequence... values) {
 		return this.myself;
 	}
 
+	@Override
 	public A isEqualTo(@Nullable Object expected) {
 		if (expected instanceof DynamicFile) {
 			return super.isEqualTo(expected);

spring-expression/src/test/java/org/springframework/expression/spel/ScenariosForSpringSecurityExpressionTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -153,11 +153,15 @@ static class Person {
 		public String[] getRoles() { return new String[]{"NONE"}; }
 
 		public boolean hasAnyRole(String... roles) {
-			if (roles == null) return true;
+			if (roles == null) {
+				return true;
+			}
 			String[] myRoles = getRoles();
-			for (int i = 0; i < myRoles.length; i++) {
-				for (int j = 0; j < roles.length; j++) {
-					if (myRoles[i].equals(roles[j])) return true;
+			for (String myRole : myRoles) {
+				for (String role : roles) {
+					if (myRole.equals(role)) {
+						return true;
+					}
 				}
 			}
 			return false;

spring-expression/src/test/java/org/springframework/expression/spel/SpelCompilationCoverageTests.java

@@ -1796,7 +1796,7 @@ public void opNe_SPR14863() throws Exception {
 		((SpelExpression) expression).compileExpression();
 		assertThat(expression.getValue(context, Boolean.class)).isFalse();
 
-		List<String> ls = new ArrayList<String>();
+		List<String> ls = new ArrayList<>();
 		ls.add(new String("foo"));
 		context = new StandardEvaluationContext(ls);
 		expression = parse("get(0) != 'foo'");
@@ -1844,7 +1844,7 @@ public void opEq_SPR14863() throws Exception {
 		assertThat(aa.gotComparedTo).isEqualTo(bb);
 
 
-		List<String> ls = new ArrayList<String>();
+		List<String> ls = new ArrayList<>();
 		ls.add(new String("foo"));
 		StandardEvaluationContext context = new StandardEvaluationContext(ls);
 		expression = parse("get(0) == 'foo'");
@@ -5109,29 +5109,26 @@ private SpelNodeImpl getAst() {
 
 	private String stringify(Object object) {
 		StringBuilder s = new StringBuilder();
-		if (object instanceof List) {
-			List<?> ls = (List<?>) object;
-			for (Object l: ls) {
+		if (object instanceof List<?> list) {
+			for (Object l: list) {
 				s.append(l);
 				s.append(' ');
 			}
 		}
-		else if (object instanceof Object[]) {
-			Object[] os = (Object[]) object;
-			for (Object o: os) {
+		else if (object instanceof Object[] objects) {
+			for (Object o: objects) {
 				s.append(o);
 				s.append(' ');
 			}
 		}
-		else if (object instanceof int[]) {
-			int[] is = (int[]) object;
-			for (int i: is) {
+		else if (object instanceof int[] ints) {
+			for (int i: ints) {
 				s.append(i);
 				s.append(' ');
 			}
 		}
 		else {
-			s.append(object.toString());
+			s.append(object);
 		}
 		return s.toString().trim();
 	}

spring-expression/src/test/java/org/springframework/expression/spel/SpelReproTests.java

@@ -1321,20 +1321,14 @@ void SPR9495() {
 		assertThat(Array.get(result, 1)).isEqualTo(ABC.B);
 		assertThat(Array.get(result, 2)).isEqualTo(ABC.C);
 
-		context.addMethodResolver(new MethodResolver() {
-			@Override
-			public MethodExecutor resolve(EvaluationContext context, Object targetObject, String name,
-					List<TypeDescriptor> argumentTypes) throws AccessException {
-				return (context1, target, arguments) -> {
-					try {
-						Method method = XYZ.class.getMethod("values");
-						Object value = method.invoke(target, arguments);
-						return new TypedValue(value, new TypeDescriptor(new MethodParameter(method, -1)).narrow(value));
-					}
-					catch (Exception ex) {
-						throw new AccessException(ex.getMessage(), ex);
-					}
-				};
+		context.addMethodResolver((context2, targetObject, name, argumentTypes) -> (context1, target, arguments) -> {
+			try {
+				Method method = XYZ.class.getMethod("values");
+				Object value = method.invoke(target, arguments);
+				return new TypedValue(value, new TypeDescriptor(new MethodParameter(method, -1)).narrow(value));
+			}
+			catch (Exception ex) {
+				throw new AccessException(ex.getMessage(), ex);
 			}
 		});
 

spring-expression/src/test/java/org/springframework/expression/spel/testresources/PlaceOfBirth.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -18,6 +18,7 @@
 
 ///CLOVER:OFF
 public class PlaceOfBirth {
+
 	private String city;
 
 	public String Country;
@@ -29,11 +30,14 @@ public class PlaceOfBirth {
 	 * country - but as it is just a test object, it is ok.
 	 */
 	@Override
-	public String toString() {return city;}
+	public String toString() {
+		return city;
+	}
 
 	public String getCity() {
 		return city;
 	}
+
 	public void setCity(String s) {
 		this.city = s;
 	}
@@ -48,11 +52,10 @@ public int doubleIt(int i) {
 
 	@Override
 	public boolean equals(Object o) {
-		if (!(o instanceof PlaceOfBirth)) {
+		if (!(o instanceof PlaceOfBirth otherPOB)) {
 			return false;
 		}
-		PlaceOfBirth oPOB = (PlaceOfBirth)o;
-		return (city.equals(oPOB.city));
+		return (city.equals(otherPOB.city));
 	}
 
 	@Override

spring-r2dbc/src/main/java/org/springframework/r2dbc/connection/R2dbcTransactionManager.java

@@ -209,32 +209,30 @@ protected Mono<Void> doBegin(TransactionSynchronizationManager synchronizationMa
 				connectionMono = Mono.just(txObject.getConnectionHolder().getConnection());
 			}
 
-			return connectionMono.flatMap(con -> {
-				return prepareTransactionalConnection(con, definition, transaction)
-						.then(Mono.from(doBegin(definition, con)))
-						.doOnSuccess(v -> {
-							txObject.getConnectionHolder().setTransactionActive(true);
-							Duration timeout = determineTimeout(definition);
-							if (!timeout.isNegative() && !timeout.isZero()) {
-								txObject.getConnectionHolder().setTimeoutInMillis(timeout.toMillis());
-							}
-							// Bind the connection holder to the thread.
-							if (txObject.isNewConnectionHolder()) {
-								synchronizationManager.bindResource(obtainConnectionFactory(), txObject.getConnectionHolder());
-							}
-						}).thenReturn(con).onErrorResume(e -> {
-							if (txObject.isNewConnectionHolder()) {
-								return ConnectionFactoryUtils.releaseConnection(con, obtainConnectionFactory())
-										.doOnTerminate(() -> txObject.setConnectionHolder(null, false))
-										.then(Mono.error(e));
-							}
-							return Mono.error(e);
-						});
-			}).onErrorResume(e -> {
-				CannotCreateTransactionException ex = new CannotCreateTransactionException(
-						"Could not open R2DBC Connection for transaction", e);
-				return Mono.error(ex);
-			});
+			return connectionMono.flatMap(con -> prepareTransactionalConnection(con, definition, transaction)
+					.then(Mono.from(doBegin(definition, con)))
+					.doOnSuccess(v -> {
+						txObject.getConnectionHolder().setTransactionActive(true);
+						Duration timeout = determineTimeout(definition);
+						if (!timeout.isNegative() && !timeout.isZero()) {
+							txObject.getConnectionHolder().setTimeoutInMillis(timeout.toMillis());
+						}
+						// Bind the connection holder to the thread.
+						if (txObject.isNewConnectionHolder()) {
+							synchronizationManager.bindResource(obtainConnectionFactory(), txObject.getConnectionHolder());
+						}
+					}).thenReturn(con).onErrorResume(e -> {
+						if (txObject.isNewConnectionHolder()) {
+							return ConnectionFactoryUtils.releaseConnection(con, obtainConnectionFactory())
+									.doOnTerminate(() -> txObject.setConnectionHolder(null, false))
+									.then(Mono.error(e));
+						}
+						return Mono.error(e);
+					})).onErrorResume(e -> {
+						CannotCreateTransactionException ex = new CannotCreateTransactionException(
+								"Could not open R2DBC Connection for transaction", e);
+						return Mono.error(ex);
+					});
 		}).then();
 	}