Add logger.isInfoEnabled check before logger.info

chenqimiao · web-flow · commit b92515bdee5a · 2020-03-10T14:41:20.000+01:00
Closes gh-24667
diff --git a/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java b/spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java
@@ -254,7 +254,7 @@ public Object getObject() throws BeansException {
 			return getSingletonInstance();
 		}
 		else {
-			if (this.targetName == null) {
+			if (this.targetName == null && logger.isInfoEnabled()) {
 				logger.info("Using non-singleton proxies with singleton targets is often undesirable. " +
 						"Enable prototype proxies by setting the 'targetName' property.");
 			}

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ public Object getObject() throws BeansException {`
`254`	`254`	`return getSingletonInstance();`
`255`	`255`	`}`
`256`	`256`	`else {`
`257`		`- if (this.targetName == null) {`
	`257`	`+ if (this.targetName == null && logger.isInfoEnabled()) {`
`258`	`258`	`logger.info("Using non-singleton proxies with singleton targets is often undesirable. " +`
`259`	`259`	`"Enable prototype proxies by setting the 'targetName' property.");`
`260`	`260`	`}`