Skip to content

Commit b5c0c6d

Browse files
committed
Merge branch '5.3.x'
# Conflicts: # spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMvcRequestBuilders.java
2 parents 67b1420 + fb1fa07 commit b5c0c6d

File tree

3 files changed

+102
-63
lines changed

3 files changed

+102
-63
lines changed

spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMultipartHttpServletRequestBuilder.java

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,16 @@ public class MockMultipartHttpServletRequestBuilder extends MockHttpServletReque
6464
* @param uriVariables zero or more URI variables
6565
*/
6666
MockMultipartHttpServletRequestBuilder(String urlTemplate, Object... uriVariables) {
67-
super(HttpMethod.POST, urlTemplate, uriVariables);
67+
this(HttpMethod.POST, urlTemplate, uriVariables);
68+
}
69+
70+
/**
71+
* Variant of {@link #MockMultipartHttpServletRequestBuilder(String, Object...)}
72+
* that also accepts an {@link HttpMethod}.
73+
* @since 5.3.22
74+
*/
75+
MockMultipartHttpServletRequestBuilder(HttpMethod httpMethod, String urlTemplate, Object... uriVariables) {
76+
super(httpMethod, urlTemplate, uriVariables);
6877
super.contentType(MediaType.MULTIPART_FORM_DATA);
6978
}
7079

@@ -74,8 +83,7 @@ public class MockMultipartHttpServletRequestBuilder extends MockHttpServletReque
7483
* @since 4.0.3
7584
*/
7685
MockMultipartHttpServletRequestBuilder(URI uri) {
77-
super(HttpMethod.POST, uri);
78-
super.contentType(MediaType.MULTIPART_FORM_DATA);
86+
this(HttpMethod.POST, uri);
7987
}
8088

8189
/**

spring-test/src/main/java/org/springframework/test/web/servlet/request/MockMvcRequestBuilders.java

Lines changed: 41 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ public abstract class MockMvcRequestBuilders {
5050
/**
5151
* Create a {@link MockHttpServletRequestBuilder} for a GET request.
5252
* @param urlTemplate a URL template; the resulting URL will be encoded
53-
* @param uriVars zero or more URI variables
53+
* @param uriVariables zero or more URI variables
5454
*/
55-
public static MockHttpServletRequestBuilder get(String urlTemplate, Object... uriVars) {
56-
return new MockHttpServletRequestBuilder(HttpMethod.GET, urlTemplate, uriVars);
55+
public static MockHttpServletRequestBuilder get(String urlTemplate, Object... uriVariables) {
56+
return new MockHttpServletRequestBuilder(HttpMethod.GET, urlTemplate, uriVariables);
5757
}
5858

5959
/**
@@ -68,10 +68,10 @@ public static MockHttpServletRequestBuilder get(URI uri) {
6868
/**
6969
* Create a {@link MockHttpServletRequestBuilder} for a POST request.
7070
* @param urlTemplate a URL template; the resulting URL will be encoded
71-
* @param uriVars zero or more URI variables
71+
* @param uriVariables zero or more URI variables
7272
*/
73-
public static MockHttpServletRequestBuilder post(String urlTemplate, Object... uriVars) {
74-
return new MockHttpServletRequestBuilder(HttpMethod.POST, urlTemplate, uriVars);
73+
public static MockHttpServletRequestBuilder post(String urlTemplate, Object... uriVariables) {
74+
return new MockHttpServletRequestBuilder(HttpMethod.POST, urlTemplate, uriVariables);
7575
}
7676

7777
/**
@@ -86,10 +86,10 @@ public static MockHttpServletRequestBuilder post(URI uri) {
8686
/**
8787
* Create a {@link MockHttpServletRequestBuilder} for a PUT request.
8888
* @param urlTemplate a URL template; the resulting URL will be encoded
89-
* @param uriVars zero or more URI variables
89+
* @param uriVariables zero or more URI variables
9090
*/
91-
public static MockHttpServletRequestBuilder put(String urlTemplate, Object... uriVars) {
92-
return new MockHttpServletRequestBuilder(HttpMethod.PUT, urlTemplate, uriVars);
91+
public static MockHttpServletRequestBuilder put(String urlTemplate, Object... uriVariables) {
92+
return new MockHttpServletRequestBuilder(HttpMethod.PUT, urlTemplate, uriVariables);
9393
}
9494

9595
/**
@@ -104,10 +104,10 @@ public static MockHttpServletRequestBuilder put(URI uri) {
104104
/**
105105
* Create a {@link MockHttpServletRequestBuilder} for a PATCH request.
106106
* @param urlTemplate a URL template; the resulting URL will be encoded
107-
* @param uriVars zero or more URI variables
107+
* @param uriVariables zero or more URI variables
108108
*/
109-
public static MockHttpServletRequestBuilder patch(String urlTemplate, Object... uriVars) {
110-
return new MockHttpServletRequestBuilder(HttpMethod.PATCH, urlTemplate, uriVars);
109+
public static MockHttpServletRequestBuilder patch(String urlTemplate, Object... uriVariables) {
110+
return new MockHttpServletRequestBuilder(HttpMethod.PATCH, urlTemplate, uriVariables);
111111
}
112112

113113
/**
@@ -122,10 +122,10 @@ public static MockHttpServletRequestBuilder patch(URI uri) {
122122
/**
123123
* Create a {@link MockHttpServletRequestBuilder} for a DELETE request.
124124
* @param urlTemplate a URL template; the resulting URL will be encoded
125-
* @param uriVars zero or more URI variables
125+
* @param uriVariables zero or more URI variables
126126
*/
127-
public static MockHttpServletRequestBuilder delete(String urlTemplate, Object... uriVars) {
128-
return new MockHttpServletRequestBuilder(HttpMethod.DELETE, urlTemplate, uriVars);
127+
public static MockHttpServletRequestBuilder delete(String urlTemplate, Object... uriVariables) {
128+
return new MockHttpServletRequestBuilder(HttpMethod.DELETE, urlTemplate, uriVariables);
129129
}
130130

131131
/**
@@ -140,10 +140,10 @@ public static MockHttpServletRequestBuilder delete(URI uri) {
140140
/**
141141
* Create a {@link MockHttpServletRequestBuilder} for an OPTIONS request.
142142
* @param urlTemplate a URL template; the resulting URL will be encoded
143-
* @param uriVars zero or more URI variables
143+
* @param uriVariables zero or more URI variables
144144
*/
145-
public static MockHttpServletRequestBuilder options(String urlTemplate, Object... uriVars) {
146-
return new MockHttpServletRequestBuilder(HttpMethod.OPTIONS, urlTemplate, uriVars);
145+
public static MockHttpServletRequestBuilder options(String urlTemplate, Object... uriVariables) {
146+
return new MockHttpServletRequestBuilder(HttpMethod.OPTIONS, urlTemplate, uriVariables);
147147
}
148148

149149
/**
@@ -158,11 +158,11 @@ public static MockHttpServletRequestBuilder options(URI uri) {
158158
/**
159159
* Create a {@link MockHttpServletRequestBuilder} for a HEAD request.
160160
* @param urlTemplate a URL template; the resulting URL will be encoded
161-
* @param uriVars zero or more URI variables
161+
* @param uriVariables zero or more URI variables
162162
* @since 4.1
163163
*/
164-
public static MockHttpServletRequestBuilder head(String urlTemplate, Object... uriVars) {
165-
return new MockHttpServletRequestBuilder(HttpMethod.HEAD, urlTemplate, uriVars);
164+
public static MockHttpServletRequestBuilder head(String urlTemplate, Object... uriVariables) {
165+
return new MockHttpServletRequestBuilder(HttpMethod.HEAD, urlTemplate, uriVariables);
166166
}
167167

168168
/**
@@ -178,10 +178,10 @@ public static MockHttpServletRequestBuilder head(URI uri) {
178178
* Create a {@link MockHttpServletRequestBuilder} for a request with the given HTTP method.
179179
* @param method the HTTP method (GET, POST, etc)
180180
* @param urlTemplate a URL template; the resulting URL will be encoded
181-
* @param uriVars zero or more URI variables
181+
* @param uriVariables zero or more URI variables
182182
*/
183-
public static MockHttpServletRequestBuilder request(HttpMethod method, String urlTemplate, Object... uriVars) {
184-
return new MockHttpServletRequestBuilder(method, urlTemplate, uriVars);
183+
public static MockHttpServletRequestBuilder request(HttpMethod method, String urlTemplate, Object... uriVariables) {
184+
return new MockHttpServletRequestBuilder(method, urlTemplate, uriVariables);
185185
}
186186

187187
/**
@@ -205,13 +205,26 @@ public static MockHttpServletRequestBuilder request(String httpMethod, URI uri)
205205
}
206206

207207
/**
208-
* Create a {@link MockMultipartHttpServletRequestBuilder} for a multipart request.
208+
* Create a {@link MockMultipartHttpServletRequestBuilder} for a multipart request,
209+
* using POST as the HTTP method.
209210
* @param urlTemplate a URL template; the resulting URL will be encoded
210-
* @param uriVars zero or more URI variables
211+
* @param uriVariables zero or more URI variables
211212
* @since 5.0
212213
*/
213-
public static MockMultipartHttpServletRequestBuilder multipart(String urlTemplate, Object... uriVars) {
214-
return new MockMultipartHttpServletRequestBuilder(urlTemplate, uriVars);
214+
public static MockMultipartHttpServletRequestBuilder multipart(String urlTemplate, Object... uriVariables) {
215+
return new MockMultipartHttpServletRequestBuilder(urlTemplate, uriVariables);
216+
}
217+
218+
/**
219+
* Variant of {@link #multipart(String, Object...)} that also accepts an
220+
* {@link HttpMethod}.
221+
* @param httpMethod the HTTP method to use
222+
* @param urlTemplate a URL template; the resulting URL will be encoded
223+
* @param uriVariables zero or more URI variables
224+
* @since 5.3.22
225+
*/
226+
public static MockMultipartHttpServletRequestBuilder multipart(HttpMethod httpMethod, String urlTemplate, Object... uriVariables) {
227+
return new MockMultipartHttpServletRequestBuilder(httpMethod, urlTemplate, uriVariables);
215228
}
216229

217230
/**

0 commit comments

Comments
 (0)