Skip to content

Commit b3bc2d9

Browse files
committed
Remove workaround for reactor-core issue
1 parent 0cc6a9e commit b3bc2d9

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

build.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ ext {
3838
kotlinVersion = "1.2.71"
3939
log4jVersion = "2.11.2"
4040
nettyVersion = "4.1.34.Final"
41-
reactorVersion = "Californium-SR6"
41+
reactorVersion = "Californium-BUILD-SNAPSHOT"
4242
rxjavaVersion = "1.3.8"
4343
rxjavaAdapterVersion = "1.2.1"
4444
rxjava2Version = "2.2.8"
@@ -149,6 +149,8 @@ configure(allprojects) { project ->
149149

150150
repositories {
151151
maven { url "https://repo.spring.io/libs-release" }
152+
maven { url "https://repo.spring.io/snapshot" } // Reactor
153+
mavenLocal()
152154
}
153155

154156
dependencies {

spring-core/src/main/java/org/springframework/core/io/buffer/DataBufferUtils.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,6 @@ public abstract class DataBufferUtils {
5757

5858
private static final Consumer<DataBuffer> RELEASE_CONSUMER = DataBufferUtils::release;
5959

60-
/**
61-
* Workaround to disable use of pooled buffers:
62-
* https://github.com/reactor/reactor-core/issues/1634.
63-
*/
64-
private static final DataBufferFactory defaultDataBufferFactory = new DefaultDataBufferFactory();
65-
6660

6761
//---------------------------------------------------------------------
6862
// Reading
@@ -141,14 +135,12 @@ public static Flux<DataBuffer> readAsynchronousFileChannel(
141135
Assert.isTrue(position >= 0, "'position' must be >= 0");
142136
Assert.isTrue(bufferSize > 0, "'bufferSize' must be > 0");
143137

144-
DataBufferFactory bufferFactoryToUse = defaultDataBufferFactory;
145-
146138
Flux<DataBuffer> flux = Flux.using(channelSupplier,
147139
channel -> Flux.create(sink -> {
148140
ReadCompletionHandler handler =
149-
new ReadCompletionHandler(channel, sink, position, bufferFactoryToUse, bufferSize);
141+
new ReadCompletionHandler(channel, sink, position, bufferFactory, bufferSize);
150142
sink.onDispose(handler::dispose);
151-
DataBuffer dataBuffer = bufferFactoryToUse.allocateBuffer(bufferSize);
143+
DataBuffer dataBuffer = bufferFactory.allocateBuffer(bufferSize);
152144
ByteBuffer byteBuffer = dataBuffer.asByteBuffer(0, bufferSize);
153145
channel.read(byteBuffer, position, dataBuffer, handler);
154146
}),

spring-core/src/test/java/org/springframework/core/io/buffer/DataBufferUtilsTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535

3636
import io.netty.buffer.ByteBuf;
3737
import org.junit.Before;
38-
import org.junit.Ignore;
3938
import org.junit.Test;
4039
import org.mockito.stubbing.Answer;
4140
import org.reactivestreams.Subscription;
@@ -50,7 +49,9 @@
5049
import org.springframework.core.io.buffer.support.DataBufferTestUtils;
5150

5251
import static org.junit.Assert.*;
53-
import static org.mockito.ArgumentMatchers.any;
52+
import static org.mockito.ArgumentMatchers.*;
53+
import static org.mockito.Mockito.anyLong;
54+
import static org.mockito.Mockito.isA;
5455
import static org.mockito.Mockito.*;
5556

5657
/**

0 commit comments

Comments
 (0)