Delete file on multipart cancel

This commit makes sure that the temporary file used for multipart
storage is deleted when the source stream is malformed or cancelled.

Closes gh-28740

Author: poutsma

spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartUtils.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2020 the original author or authors.
+ * Copyright 2002-2022 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -20,6 +20,8 @@
 import java.nio.channels.Channel;
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
 
 import org.springframework.core.io.buffer.DataBuffer;
 import org.springframework.http.HttpHeaders;
@@ -91,4 +93,12 @@ public static void closeChannel(Channel channel) {
 		}
 	}
 
+	public static void deleteFile(Path file) {
+		try {
+			Files.delete(file);
+		}
+		catch (IOException ignore) {
+		}
+	}
+
 }

spring-web/src/main/java/org/springframework/http/codec/multipart/PartGenerator.java

@@ -609,6 +609,7 @@ private void fileCreated(WritingFileState newState) {
 			}
 			else {
 				MultipartUtils.closeChannel(newState.channel);
+				MultipartUtils.deleteFile(newState.file);
 				this.content.forEach(DataBufferUtils::release);
 			}
 		}
@@ -640,6 +641,8 @@ private final class IdleFileState implements State {
 
 		private volatile boolean closeOnDispose = true;
 
+		private volatile boolean deleteOnDispose = true;
+
 
 		public IdleFileState(WritingFileState state) {
 			this.headers = state.headers;
@@ -654,16 +657,20 @@ public void body(DataBuffer dataBuffer) {
 			if (PartGenerator.this.maxDiskUsagePerPart == -1 || count <= PartGenerator.this.maxDiskUsagePerPart) {
 
 				this.closeOnDispose = false;
+				this.deleteOnDispose = false;
 				WritingFileState newState = new WritingFileState(this);
 				if (changeState(this, newState)) {
 					newState.writeBuffer(dataBuffer);
 				}
 				else {
 					MultipartUtils.closeChannel(this.channel);
+					MultipartUtils.deleteFile(this.file);
 					DataBufferUtils.release(dataBuffer);
 				}
 			}
 			else {
+				MultipartUtils.closeChannel(this.channel);
+				MultipartUtils.deleteFile(this.file);
 				DataBufferUtils.release(dataBuffer);
 				emitError(new DataBufferLimitException(
 						"Part exceeded the disk usage limit of " + PartGenerator.this.maxDiskUsagePerPart +
@@ -674,6 +681,7 @@ public void body(DataBuffer dataBuffer) {
 		@Override
 		public void partComplete(boolean finalPart) {
 			MultipartUtils.closeChannel(this.channel);
+			this.deleteOnDispose = false;
 			emitPart(DefaultParts.part(this.headers, this.file, PartGenerator.this.blockingOperationScheduler));
 			if (finalPart) {
 				emitComplete();
@@ -685,6 +693,9 @@ public void dispose() {
 			if (this.closeOnDispose) {
 				MultipartUtils.closeChannel(this.channel);
 			}
+			if (this.deleteOnDispose) {
+				MultipartUtils.deleteFile(this.file);
+			}
 		}
 
 
@@ -710,6 +721,8 @@ private final class WritingFileState implements State {
 
 		private volatile boolean finalPart;
 
+		private volatile boolean disposed;
+
 
 		public WritingFileState(CreateFileState state, Path file, WritableByteChannel channel) {
 			this.headers = state.headers;
@@ -761,11 +774,15 @@ private void writeComplete() {
 			if (this.completed) {
 				newState.partComplete(this.finalPart);
 			}
+			else if (this.disposed) {
+				newState.dispose();
+			}
 			else if (changeState(this, newState)) {
 				requestToken();
 			}
 			else {
 				MultipartUtils.closeChannel(this.channel);
+				MultipartUtils.deleteFile(this.file);
 			}
 		}
 
@@ -779,13 +796,21 @@ private Mono<Void> writeInternal(DataBuffer dataBuffer) {
 				return Mono.empty();
 			}
 			catch (IOException ex) {
+				MultipartUtils.closeChannel(this.channel);
+				MultipartUtils.deleteFile(this.file);
 				return Mono.error(ex);
 			}
 			finally {
 				DataBufferUtils.release(dataBuffer);
 			}
 		}
 
+		@Override
+		public void dispose() {
+			this.disposed = true;
+		}
+
+
 		@Override
 		public String toString() {
 			return "WRITE-FILE";