Skip to content

Commit a92f425

Browse files
committed
Also use constant for custom mapping condition
See gh-25143
1 parent c0c3c01 commit a92f425

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
6767

6868
private static final ProducesRequestCondition EMPTY_PRODUCES = new ProducesRequestCondition();
6969

70+
private static final RequestConditionHolder EMPTY_CUSTOM = new RequestConditionHolder(null);
71+
7072

7173
@Nullable
7274
private final String name;
@@ -98,7 +100,7 @@ public RequestMappingInfo(@Nullable String name, @Nullable PatternsRequestCondit
98100
this.headersCondition = (headers != null ? headers : EMPTY_HEADERS);
99101
this.consumesCondition = (consumes != null ? consumes : EMPTY_CONSUMES);
100102
this.producesCondition = (produces != null ? produces : EMPTY_PRODUCES);
101-
this.customConditionHolder = new RequestConditionHolder(custom);
103+
this.customConditionHolder = (custom != null ? new RequestConditionHolder(custom) : EMPTY_CUSTOM);
102104
}
103105

104106
/**

spring-webflux/src/test/java/org/springframework/web/reactive/result/condition/RequestMappingInfoTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public void createEmpty() {
6969
assertThat(info.getHeadersCondition()).isSameAs(anotherInfo.getHeadersCondition());
7070
assertThat(info.getConsumesCondition()).isSameAs(anotherInfo.getConsumesCondition());
7171
assertThat(info.getProducesCondition()).isSameAs(anotherInfo.getProducesCondition());
72+
assertThat(info.getCustomCondition()).isSameAs(anotherInfo.getCustomCondition());
7273

7374
RequestMappingInfo result = info.combine(anotherInfo);
7475
assertThat(info.getPatternsCondition()).isSameAs(result.getPatternsCondition());
@@ -77,6 +78,7 @@ public void createEmpty() {
7778
assertThat(info.getHeadersCondition()).isSameAs(result.getHeadersCondition());
7879
assertThat(info.getConsumesCondition()).isSameAs(result.getConsumesCondition());
7980
assertThat(info.getProducesCondition()).isSameAs(result.getProducesCondition());
81+
assertThat(info.getCustomCondition()).isSameAs(result.getCustomCondition());
8082
}
8183

8284
@Test

spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ public final class RequestMappingInfo implements RequestCondition<RequestMapping
6969

7070
private static final ProducesRequestCondition EMPTY_PRODUCES = new ProducesRequestCondition();
7171

72+
private static final RequestConditionHolder EMPTY_CUSTOM = new RequestConditionHolder(null);
73+
74+
7275

7376
@Nullable
7477
private final String name;
@@ -100,7 +103,7 @@ public RequestMappingInfo(@Nullable String name, @Nullable PatternsRequestCondit
100103
this.headersCondition = (headers != null ? headers : EMPTY_HEADERS);
101104
this.consumesCondition = (consumes != null ? consumes : EMPTY_CONSUMES);
102105
this.producesCondition = (produces != null ? produces : EMPTY_PRODUCES);
103-
this.customConditionHolder = new RequestConditionHolder(custom);
106+
this.customConditionHolder = (custom != null ? new RequestConditionHolder(custom) : EMPTY_CUSTOM);
104107
}
105108

106109
/**

spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/RequestMappingInfoTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ public void createEmpty() {
6363
assertThat(info.getHeadersCondition()).isSameAs(anotherInfo.getHeadersCondition());
6464
assertThat(info.getConsumesCondition()).isSameAs(anotherInfo.getConsumesCondition());
6565
assertThat(info.getProducesCondition()).isSameAs(anotherInfo.getProducesCondition());
66+
assertThat(info.getCustomCondition()).isSameAs(anotherInfo.getCustomCondition());
6667

6768
RequestMappingInfo result = info.combine(anotherInfo);
6869
assertThat(info.getPatternsCondition()).isSameAs(result.getPatternsCondition());
@@ -71,6 +72,7 @@ public void createEmpty() {
7172
assertThat(info.getHeadersCondition()).isSameAs(result.getHeadersCondition());
7273
assertThat(info.getConsumesCondition()).isSameAs(result.getConsumesCondition());
7374
assertThat(info.getProducesCondition()).isSameAs(result.getProducesCondition());
75+
assertThat(info.getCustomCondition()).isSameAs(result.getCustomCondition());
7476
}
7577

7678
@Test

0 commit comments

Comments
 (0)