Polishing

Author: sbrannen

spring-expression/src/test/java/org/springframework/expression/spel/IndexingTests.java

@@ -524,13 +524,15 @@ static class RootContextWithIndexedProperties {
 	@Nested
 	class IndexAccessorTests {  // gh-26478
 
+		private final StandardEvaluationContext context = new StandardEvaluationContext();
+		private final SpelExpressionParser parser = new SpelExpressionParser();
+
 		@Test
 		void addingAndRemovingIndexAccessors() {
 			ObjectMapper objectMapper = new ObjectMapper();
 			IndexAccessor accessor1 = new JacksonArrayNodeIndexAccessor(objectMapper);
 			IndexAccessor accessor2 = new JacksonArrayNodeIndexAccessor(objectMapper);
 
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			List<IndexAccessor> indexAccessors = context.getIndexAccessors();
 			assertThat(indexAccessors).isEmpty();
 
@@ -551,10 +553,8 @@ void addingAndRemovingIndexAccessors() {
 
 		@Test
 		void noSuitableIndexAccessorResultsInException() {
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			assertThat(context.getIndexAccessors()).isEmpty();
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThatExceptionOfType(SpelEvaluationException.class)
 					.isThrownBy(() -> expr.getValue(context, this))
@@ -564,15 +564,13 @@ void noSuitableIndexAccessorResultsInException() {
 
 		@Test
 		void canReadThrowsException() throws Exception {
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			RuntimeException exception = new RuntimeException("Boom!");
 
 			IndexAccessor mock = mock();
 			given(mock.getSpecificTargetClasses()).willReturn(null);
 			given(mock.canRead(any(), eq(this), any())).willThrow(exception);
 			context.addIndexAccessor(mock);
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThatExceptionOfType(SpelEvaluationException.class)
 					.isThrownBy(() -> expr.getValue(context, this))
@@ -588,7 +586,6 @@ void canReadThrowsException() throws Exception {
 
 		@Test
 		void readThrowsException() throws Exception {
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			RuntimeException exception = new RuntimeException("Boom!");
 
 			IndexAccessor mock = mock();
@@ -597,7 +594,6 @@ void readThrowsException() throws Exception {
 			given(mock.read(any(), eq(this), any())).willThrow(exception);
 			context.addIndexAccessor(mock);
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThatExceptionOfType(SpelEvaluationException.class)
 					.isThrownBy(() -> expr.getValue(context, this))
@@ -614,15 +610,13 @@ void readThrowsException() throws Exception {
 
 		@Test
 		void canWriteThrowsException() throws Exception {
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			RuntimeException exception = new RuntimeException("Boom!");
 
 			IndexAccessor mock = mock();
 			given(mock.getSpecificTargetClasses()).willReturn(null);
 			given(mock.canWrite(eq(context), eq(this), eq(0))).willThrow(exception);
 			context.addIndexAccessor(mock);
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThatExceptionOfType(SpelEvaluationException.class)
 					.isThrownBy(() -> expr.setValue(context, this, 999))
@@ -638,7 +632,6 @@ void canWriteThrowsException() throws Exception {
 
 		@Test
 		void writeThrowsException() throws Exception {
-			StandardEvaluationContext context = new StandardEvaluationContext();
 			RuntimeException exception = new RuntimeException("Boom!");
 
 			IndexAccessor mock = mock();
@@ -647,7 +640,6 @@ void writeThrowsException() throws Exception {
 			doThrow(exception).when(mock).write(any(), any(), any(), any());
 			context.addIndexAccessor(mock);
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThatExceptionOfType(SpelEvaluationException.class)
 					.isThrownBy(() -> expr.setValue(context, this, 999))
@@ -664,8 +656,6 @@ void writeThrowsException() throws Exception {
 
 		@Test
 		void readAndWriteIndex() {
-			StandardEvaluationContext context = new StandardEvaluationContext();
-
 			ObjectMapper objectMapper = new ObjectMapper();
 			context.addIndexAccessor(new JacksonArrayNodeIndexAccessor(objectMapper));
 
@@ -674,7 +664,6 @@ void readAndWriteIndex() {
 			ArrayNode arrayNode = objectMapper.createArrayNode();
 			arrayNode.addAll(List.of(node0, node1));
 
-			SpelExpressionParser parser = new SpelExpressionParser();
 			Expression expr = parser.parseExpression("[0]");
 			assertThat(expr.getValue(context, arrayNode)).isSameAs(node0);
 
@@ -703,7 +692,6 @@ void readAndWriteIndexWithSimpleEvaluationContext() {
 			SimpleEvaluationContext context = SimpleEvaluationContext.forReadWriteDataBinding()
 					.withIndexAccessors(new JacksonArrayNodeIndexAccessor(objectMapper))
 					.build();
-			SpelExpressionParser parser = new SpelExpressionParser();
 
 			TextNode node0 = new TextNode("node0");
 			TextNode node1 = new TextNode("node1");