Skip to content

Commit 9e144af

Browse files
committed
Merge pull request #31328 from vpavic
* pr/31328: Polish "Fix regression in JmsAccessor#setSessionAcknowledgeMode" Fix regression in JmsAccessor#setSessionAcknowledgeMode Closes gh-31328
2 parents ce9ca70 + 95e6902 commit 9e144af

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

spring-jms/src/main/java/org/springframework/jms/support/JmsAccessor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,6 @@ public void setSessionAcknowledgeModeName(String constantName) {
167167
* @see jakarta.jms.Connection#createSession(boolean, int)
168168
*/
169169
public void setSessionAcknowledgeMode(int sessionAcknowledgeMode) {
170-
Assert.isTrue(sessionConstants.containsValue(sessionAcknowledgeMode),
171-
"Only values of acknowledge mode constants allowed");
172170
this.sessionAcknowledgeMode = sessionAcknowledgeMode;
173171
}
174172

spring-jms/src/test/java/org/springframework/jms/support/JmsAccessorTests.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ void setSessionAcknowledgeModeNameToAllSupportedValues() {
9898

9999
@Test
100100
void setSessionAcknowledgeMode() {
101-
assertThatIllegalArgumentException().isThrownBy(() -> accessor.setSessionAcknowledgeMode(999));
102-
103101
accessor.setSessionAcknowledgeMode(Session.AUTO_ACKNOWLEDGE);
104102
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.AUTO_ACKNOWLEDGE);
105103

@@ -113,6 +111,12 @@ void setSessionAcknowledgeMode() {
113111
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.SESSION_TRANSACTED);
114112
}
115113

114+
@Test
115+
void setCustomSessionAcknowledgeMode() {
116+
accessor.setSessionAcknowledgeMode(999);
117+
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(999);
118+
}
119+
116120
@Test
117121
void customAcknowledgeModeIsConsideredClientAcknowledge() throws Exception {
118122
Session session = mock();

0 commit comments

Comments
 (0)