Don't expose RetentionPolicy.CLASS annotations

Update ASM based metadata readers so that only RetentionPolicy.RUNTIME
annotations are exposed. This aligned behavior with the reflection based
implementation.

Closes gh-22886

Author: philwebb

spring-context/src/test/java/example/scannable_scoped/MyScope.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,9 +16,13 @@
 
 package example.scannable_scoped;
 
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
 import org.springframework.beans.factory.config.BeanDefinition;
 import org.springframework.context.annotation.ScopedProxyMode;
 
+@Retention(RetentionPolicy.RUNTIME)
 public @interface MyScope {
 	String value() default BeanDefinition.SCOPE_SINGLETON;
 	ScopedProxyMode proxyMode() default ScopedProxyMode.DEFAULT;

spring-context/src/test/java/org/springframework/context/annotation/configuration/spr9031/Spr9031Tests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -16,6 +16,9 @@
 
 package org.springframework.context.annotation.configuration.spr9031;
 
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
 import org.junit.Test;
 
 import org.springframework.beans.factory.annotation.Autowired;
@@ -75,5 +78,6 @@ static class LowLevelConfig {
 		@Autowired Spr9031Component scanned;
 	}
 
+	@Retention(RetentionPolicy.RUNTIME)
 	public @interface MarkerAnnotation {}
 }

spring-core/src/main/java/org/springframework/core/type/classreading/AnnotationMetadataReadingVisitor.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -85,6 +85,9 @@ public MethodVisitor visitMethod(int access, String name, String desc, String si
 
 	@Override
 	public AnnotationVisitor visitAnnotation(String desc, boolean visible) {
+		if (!visible) {
+			return null;
+		}
 		String className = Type.getType(desc).getClassName();
 		this.annotationSet.add(className);
 		return new AnnotationAttributesReadingVisitor(

spring-core/src/main/java/org/springframework/core/type/classreading/MethodMetadataReadingVisitor.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -79,6 +79,9 @@ public MethodMetadataReadingVisitor(String methodName, int access, String declar
 
 	@Override
 	public AnnotationVisitor visitAnnotation(final String desc, boolean visible) {
+		if (!visible) {
+			return null;
+		}
 		this.methodMetadataSet.add(this);
 		String className = Type.getType(desc).getClassName();
 		return new AnnotationAttributesReadingVisitor(

spring-core/src/test/java/org/springframework/core/type/AnnotationTypeFilterTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,6 +17,8 @@
 package org.springframework.core.type;
 
 import java.lang.annotation.Inherited;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
 
 import org.junit.Test;
 
@@ -108,6 +110,7 @@ public void testMatchesInterfacesIfConfigured() throws Exception {
 	// and interfering with ClassloadingAssertions.assertClassNotLoaded()
 
 	@Inherited
+	@Retention(RetentionPolicy.RUNTIME)
 	private @interface InheritedAnnotation {
 	}
 
@@ -132,6 +135,7 @@ private static class SomeSubclassOfSomeComponent extends SomeComponent {
 	}
 
 
+	@Retention(RetentionPolicy.RUNTIME)
 	private @interface NonInheritedAnnotation {
 	}