Merge pull request #22836 from izeye

snicoll · snicoll · commit 7cc132b2a975 · 2019-04-25T17:35:19.000+03:00
* pr/22836:
  Add missing fail() calls in MockRestServiceServerTests
diff --git a/spring-test/src/test/java/org/springframework/test/web/client/MockRestServiceServerTests.java b/spring-test/src/test/java/org/springframework/test/web/client/MockRestServiceServerTests.java
@@ -126,6 +126,7 @@ public void followUpRequestAfterFailure() {
 
 		try {
 			this.restTemplate.getForEntity("/some-service/some-endpoint", String.class);
+			fail("Expected exception to be thrown.");
 		}
 		catch (Exception ex) {
 			this.restTemplate.postForEntity("/reporting-service/report-error", ex.toString(), String.class);
@@ -142,6 +143,7 @@ public void verifyShouldFailIfRequestsFailed() {
 		this.restTemplate.postForEntity("/remoteurl", null, String.class);
 		try {
 			this.restTemplate.postForEntity("/remoteurl", null, String.class);
+			fail("Expected error to be thrown.");
 		}
 		catch (AssertionError error) {
 			assertThat(error.getMessage()).startsWith("No further requests expected");

Original file line number	Diff line number	Diff line change
`@@ -126,6 +126,7 @@ public void followUpRequestAfterFailure() {`
`126`	`126`
`127`	`127`	`try {`
`128`	`128`	`this.restTemplate.getForEntity("/some-service/some-endpoint", String.class);`
	`129`	`+ fail("Expected exception to be thrown.");`
`129`	`130`	`}`
`130`	`131`	`catch (Exception ex) {`
`131`	`132`	`this.restTemplate.postForEntity("/reporting-service/report-error", ex.toString(), String.class);`
`@@ -142,6 +143,7 @@ public void verifyShouldFailIfRequestsFailed() {`
`142`	`143`	`this.restTemplate.postForEntity("/remoteurl", null, String.class);`
`143`	`144`	`try {`
`144`	`145`	`this.restTemplate.postForEntity("/remoteurl", null, String.class);`
	`146`	`+ fail("Expected error to be thrown.");`
`145`	`147`	`}`
`146`	`148`	`catch (AssertionError error) {`
`147`	`149`	`assertThat(error.getMessage()).startsWith("No further requests expected");`