Skip to content

Commit 79cf554

Browse files
committed
Merge branch '6.1.x'
2 parents c0c41dd + 8ffbafd commit 79cf554

File tree

3 files changed

+11
-1
lines changed

3 files changed

+11
-1
lines changed

spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactory.java

-1
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ private static AspectJAnnotation findAnnotation(Method method, Class<? extends A
136136

137137
private static boolean compiledByAjc(Class<?> clazz) {
138138
for (Field field : clazz.getDeclaredFields()) {
139-
System.out.println(clazz + ": " + field.getName());
140139
if (field.getName().startsWith(AJC_MAGIC)) {
141140
return true;
142141
}

src/checkstyle/checkstyle-suppressions.xml

+3
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]" checks="AnnotationLocation|AnnotationUseStyle|AtclauseOrder|AvoidNestedBlocks|FinalClass|HideUtilityClassConstructor|InnerTypeLast|JavadocStyle|JavadocType|JavadocVariable|LeftCurly|MultipleVariableDeclarations|NeedBraces|OneTopLevelClass|OuterTypeFilename|RequireThis|SpringCatch|SpringJavadoc|SpringNoThis"/>
1515
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]" checks="RegexpSinglelineJava" id="toLowerCaseWithoutLocale"/>
1616
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]" checks="RegexpSinglelineJava" id="toUpperCaseWithoutLocale"/>
17+
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]" checks="RegexpSinglelineJava" id="systemOutPrintln"/>
1718
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]org[\\/]springframework[\\/].+(Tests|Suite)" checks="IllegalImport" id="bannedJUnitJupiterImports"/>
1819
<suppress files="[\\/]src[\\/](test|testFixtures)[\\/](java|java21)[\\/]" checks="SpringJUnit5" message="should not be public"/>
1920

@@ -42,6 +43,7 @@
4243

4344
<!-- spring-core -->
4445
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/](asm|cglib|objenesis|javapoet)[\\/]" checks=".*"/>
46+
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/]aot[\\/]nativex[\\/]feature[\\/]" checks="RegexpSinglelineJava" id="systemOutPrintln"/>
4547
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/]lang[\\/]" checks="IllegalImport" id="bannedImports" message="javax"/>
4648
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/]lang[\\/]" checks="RegexpSinglelineJava" id="packageLevelNonNullApiAnnotation" />
4749
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]springframework[\\/]lang[\\/]" checks="RegexpSinglelineJava" id="packageLevelNonNullFieldsAnnotation" />
@@ -64,6 +66,7 @@
6466

6567
<!-- spring-jcl -->
6668
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]apache[\\/]commons[\\/]logging[\\/]" checks="Header|SpringNoThis|IllegalImport"/>
69+
<suppress files="[\\/]src[\\/]main[\\/]java[\\/]org[\\/]apache[\\/]commons[\\/]logging[\\/]" checks="RegexpSinglelineJava" id="systemOutPrintln"/>
6770

6871
<!-- spring-jdbc -->
6972
<suppress files="ResultSetWrappingSqlRowSet" checks="JavadocStyle"/>

src/checkstyle/checkstyle.xml

+8
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,14 @@
245245
value="String.toUpperCase() should be String.toUpperCase(Locale.ROOT)"/>
246246
<property name="ignoreComments" value="true"/>
247247
</module>
248+
<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
249+
<property name="id" value="systemOutPrintln"/>
250+
<property name="format" value="System\.out\.println"/>
251+
<property name="maximum" value="0"/>
252+
<property name="message"
253+
value="System.out.println calls are forbidden in the main codebase"/>
254+
<property name="ignoreComments" value="true"/>
255+
</module>
248256
<module
249257
name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
250258
<property name="maximum" value="0"/>

0 commit comments

Comments
 (0)