Simplify SourceFileAssert assertion methods

Remove assertion methods that turned out not to be needed when
testing Spring Framework's AOT generated code.

Closes gh-28556

Author: philwebb

spring-core-test/src/main/java/org/springframework/aot/test/generator/file/MethodAssert.java

@@ -23,14 +23,15 @@
 
 import com.thoughtworks.qdox.JavaProjectBuilder;
 import com.thoughtworks.qdox.model.JavaClass;
-import com.thoughtworks.qdox.model.JavaPackage;
 import com.thoughtworks.qdox.model.JavaSource;
 import org.assertj.core.api.AssertProvider;
-import org.assertj.core.util.Strings;
 
 import org.springframework.core.io.InputStreamSource;
 import org.springframework.lang.Nullable;
+import org.springframework.util.Assert;
+import org.springframework.util.ClassUtils;
 import org.springframework.util.FileCopyUtils;
+import org.springframework.util.StringUtils;
 
 /**
  * {@link DynamicFile} that holds Java source code and provides
@@ -48,12 +49,12 @@ public final class SourceFile extends DynamicFile
 		implements AssertProvider<SourceFileAssert> {
 
 
-	private final JavaSource javaSource;
+	private final String className;
 
 
-	private SourceFile(String path, String content, JavaSource javaSource) {
+	private SourceFile(String path, String content, String className) {
 		super(path, content);
-		this.javaSource = javaSource;
+		this.className = className;
 	}
 
 
@@ -126,53 +127,38 @@ public static SourceFile of(WritableContent writableContent) {
 	 */
 	public static SourceFile of(@Nullable String path, WritableContent writableContent) {
 		String content = toString(writableContent);
-		if (Strings.isNullOrEmpty(content)) {
-			throw new IllegalStateException("WritableContent did not append any content");
+		Assert.state(StringUtils.hasLength(content), "WritableContent did not append any content");
+		String className = getClassName(content);
+		if (!StringUtils.hasLength(path)) {
+			path = ClassUtils.convertClassNameToResourcePath(className) + ".java";
 		}
-		JavaSource javaSource = parse(content);
-		if (path == null || path.isEmpty()) {
-			path = deducePath(javaSource);
-		}
-		return new SourceFile(path, content, javaSource);
+		return new SourceFile(path, content, className);
 	}
 
-	private static JavaSource parse(String content) {
+	/**
+	 * Return the fully-qualified class name.
+	 * @return the fully qualified class name
+	 */
+	public String getClassName() {
+		return this.className;
+	}
+
+	private static String getClassName(String content) {
 		JavaProjectBuilder builder = new JavaProjectBuilder();
 		try {
 			JavaSource javaSource = builder.addSource(new StringReader(content));
-			if (javaSource.getClasses().size() != 1) {
-				throw new IllegalStateException("Source must define a single class");
-			}
-			return javaSource;
+			Assert.state(javaSource.getClasses().size() == 1, "Source must define a single class");
+			JavaClass javaClass = javaSource.getClasses().get(0);
+			return (javaSource.getPackage() != null)
+					? javaSource.getPackageName() + "." + javaClass.getName()
+					: javaClass.getName();
 		}
 		catch (Exception ex) {
 			throw new IllegalStateException(
 					"Unable to parse source file content:\n\n" + content, ex);
 		}
 	}
 
-	private static String deducePath(JavaSource javaSource) {
-		JavaPackage javaPackage = javaSource.getPackage();
-		JavaClass javaClass = javaSource.getClasses().get(0);
-		String path = javaClass.getName() + ".java";
-		if (javaPackage != null) {
-			path = javaPackage.getName().replace('.', '/') + "/" + path;
-		}
-		return path;
-	}
-
-	JavaSource getJavaSource() {
-		return this.javaSource;
-	}
-
-	/**
-	 * Return the class name of the source file.
-	 * @return the class name
-	 */
-	public String getClassName() {
-		return this.javaSource.getClasses().get(0).getFullyQualifiedName();
-	}
-
 	/**
 	 * AssertJ {@code assertThat} support.
 	 * @deprecated use {@code assertThat(sourceFile)} rather than calling this
@@ -184,4 +170,6 @@ public SourceFileAssert assertThat() {
 		return new SourceFileAssert(this);
 	}
 
+
+
 }

spring-core-test/src/main/java/org/springframework/aot/test/generator/file/SourceFile.java

@@ -16,21 +16,6 @@
 
 package org.springframework.aot.test.generator.file;
 
-import java.util.Arrays;
-import java.util.List;
-import java.util.stream.Collectors;
-
-import com.thoughtworks.qdox.model.JavaClass;
-import com.thoughtworks.qdox.model.JavaMethod;
-import com.thoughtworks.qdox.model.JavaParameter;
-import com.thoughtworks.qdox.model.JavaType;
-import org.assertj.core.error.BasicErrorMessageFactory;
-import org.assertj.core.internal.Failures;
-
-import org.springframework.lang.Nullable;
-
-import static org.assertj.core.api.Assertions.assertThat;
-
 /**
  * Assertion methods for {@code SourceFile} instances.
  *
@@ -44,87 +29,4 @@ public class SourceFileAssert extends DynamicFileAssert<SourceFileAssert, Source
 		super(actual, SourceFileAssert.class);
 	}
 
-
-	public SourceFileAssert implementsInterface(@Nullable Class<?> type) {
-		return implementsInterface((type != null ? type.getName() : null));
-	}
-
-	public SourceFileAssert implementsInterface(@Nullable String name) {
-		JavaClass javaClass = getJavaClass();
-		assertThat(javaClass.getImplements()).as("implements").map(
-				JavaType::getFullyQualifiedName).contains(name);
-		return this;
-	}
-
-	public MethodAssert hasMethodNamed(String name) {
-		JavaClass javaClass = getJavaClass();
-		JavaMethod method = null;
-		for (JavaMethod candidate : javaClass.getMethods()) {
-			if (candidate.getName().equals(name)) {
-				if (method != null) {
-					throw Failures.instance().failure(this.info,
-							new BasicErrorMessageFactory(String.format(
-									"%nExpecting actual:%n  %s%nto contain unique method:%n  %s%n",
-									this.actual.getContent(), name)));
-				}
-				method = candidate;
-			}
-		}
-		if (method == null) {
-			throw Failures.instance().failure(this.info,
-					new BasicErrorMessageFactory(String.format(
-							"%nExpecting actual:%n  %s%nto contain method:%n  %s%n",
-							this.actual.getContent(), name)));
-		}
-		return new MethodAssert(method);
-	}
-
-	public MethodAssert hasMethod(String name, Class<?>... parameters) {
-		JavaClass javaClass = getJavaClass();
-		JavaMethod method = null;
-		for (JavaMethod candidate : javaClass.getMethods()) {
-			if (candidate.getName().equals(name)
-					&& hasParameters(candidate, parameters)) {
-				if (method != null) {
-					throw Failures.instance().failure(this.info,
-							new BasicErrorMessageFactory(String.format(
-									"%nExpecting actual:%n  %s%nto contain unique method:%n  %s%n",
-									this.actual.getContent(), name)));
-				}
-				method = candidate;
-			}
-		}
-		if (method == null) {
-			String methodDescription = getMethodDescription(name, parameters);
-			throw Failures.instance().failure(this.info,
-					new BasicErrorMessageFactory(String.format(
-							"%nExpecting actual:%n  %s%nto contain method:%n  %s%n",
-							this.actual.getContent(), methodDescription)));
-		}
-		return new MethodAssert(method);
-	}
-
-	private boolean hasParameters(JavaMethod method, Class<?>[] requiredParameters) {
-		List<JavaParameter> parameters = method.getParameters();
-		if (parameters.size() != requiredParameters.length) {
-			return false;
-		}
-		for (int i = 0; i < requiredParameters.length; i++) {
-			if (!requiredParameters[i].getName().equals(
-					parameters.get(i).getFullyQualifiedName())) {
-				return false;
-			}
-		}
-		return true;
-	}
-
-	private String getMethodDescription(String name, Class<?>... parameters) {
-		return name + "(" + Arrays.stream(parameters).map(Class::getName).collect(
-				Collectors.joining(", ")) + ")";
-	}
-
-	private JavaClass getJavaClass() {
-		return this.actual.getJavaSource().getClasses().get(0);
-	}
-
 }

spring-core-test/src/main/java/org/springframework/aot/test/generator/file/SourceFileAssert.java

@@ -22,6 +22,7 @@
 import java.util.stream.Stream;
 
 import org.springframework.lang.Nullable;
+import org.springframework.util.ClassUtils;
 
 /**
  * An immutable collection of {@link SourceFile} instances.
@@ -155,7 +156,7 @@ private SourceFile getSingle(Pattern pattern) {
 	 */
 	public SourceFile getSingleFromPackage(String packageName) {
 		return this.files.getSingle(candidate -> Objects.equals(packageName,
-				candidate.getJavaSource().getPackageName()));
+				ClassUtils.getPackageName(candidate.getClassName())));
 	}
 
 	@Override

spring-core-test/src/main/java/org/springframework/aot/test/generator/file/SourceFiles.java

@@ -100,8 +100,7 @@ void compileWhenHasDifferentClassesWithSameClassNameCompilesBoth() {
 	@Test
 	void compileAndGetSourceFile() {
 		TestCompiler.forSystem().withSources(SourceFile.of(HELLO_SPRING)).compile(
-				compiled -> assertThat(compiled.getSourceFile()).hasMethodNamed(
-						"get").withBodyContaining("// !!"));
+				compiled -> assertThat(compiled.getSourceFile()).contains("// !!"));
 	}
 
 	@Test