Skip to content

Commit 7055ddb

Browse files
committed
Upgrade to R2DBC 1.0
Includes Reactor 2022.0.0-M4, Netty 4.1.79, Jetty 11.0.11, Undertow 2.2.18, Hibernate ORM 5.6.10, Checkstyle 10.3.1 Closes gh-28787
1 parent b135cbe commit 7055ddb

File tree

3 files changed

+17
-27
lines changed

3 files changed

+17
-27
lines changed

build.gradle

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ configure(allprojects) { project ->
2828
dependencyManagement {
2929
imports {
3030
mavenBom "com.fasterxml.jackson:jackson-bom:2.13.3"
31-
mavenBom "io.netty:netty-bom:4.1.77.Final"
32-
mavenBom "io.projectreactor:reactor-bom:2022.0.0-SNAPSHOT"
33-
mavenBom "io.r2dbc:r2dbc-bom:Borca-SR1"
31+
mavenBom "io.netty:netty-bom:4.1.79.Final"
32+
mavenBom "io.projectreactor:reactor-bom:2022.0.0-M4"
3433
mavenBom "io.rsocket:rsocket-bom:1.1.2"
35-
mavenBom "org.eclipse.jetty:jetty-bom:11.0.9"
34+
mavenBom "org.eclipse.jetty:jetty-bom:11.0.11"
3635
mavenBom "org.jetbrains.kotlin:kotlin-bom:1.7.10"
3736
mavenBom "org.jetbrains.kotlinx:kotlinx-coroutines-bom:1.6.2"
3837
mavenBom "org.jetbrains.kotlinx:kotlinx-serialization-bom:1.3.3"
@@ -66,6 +65,9 @@ configure(allprojects) { project ->
6665
dependency "io.reactivex.rxjava3:rxjava:3.1.4"
6766
dependency "io.smallrye.reactive:mutiny:1.4.0"
6867
dependency "io.projectreactor.tools:blockhound:1.0.6.RELEASE"
68+
dependency "io.r2dbc:r2dbc-spi:1.0.0.RELEASE"
69+
dependency "io.r2dbc:r2dbc-spi-test:1.0.0.RELEASE"
70+
dependency "io.r2dbc:r2dbc-h2:1.0.0.RC1"
6971

7072
dependency "com.fasterxml:aalto-xml:1.3.1"
7173
dependency("com.fasterxml.woodstox:woodstox-core:6.2.8") {
@@ -112,7 +114,7 @@ configure(allprojects) { project ->
112114
dependency "org.quartz-scheduler:quartz:2.3.2"
113115
dependency "org.ehcache:jcache:1.0.1"
114116
dependency "org.ehcache:ehcache:3.4.0"
115-
dependency "org.hibernate:hibernate-core-jakarta:5.6.8.Final"
117+
dependency "org.hibernate:hibernate-core-jakarta:5.6.10.Final"
116118
dependency "org.hibernate:hibernate-validator:7.0.4.Final"
117119
dependency "org.webjars:webjars-locator-core:0.48"
118120
dependency "org.webjars:underscorejs:1.8.3"
@@ -128,7 +130,7 @@ configure(allprojects) { project ->
128130
entry 'tomcat-embed-core'
129131
entry 'tomcat-embed-websocket'
130132
}
131-
dependencySet(group: 'io.undertow', version: '2.2.17.Final') {
133+
dependencySet(group: 'io.undertow', version: '2.2.18.Final') {
132134
entry 'undertow-core'
133135
entry 'undertow-servlet-jakarta'
134136
entry 'undertow-websockets-jsr-jakarta'
@@ -253,7 +255,6 @@ configure(allprojects) { project ->
253255
mavenCentral()
254256
maven { url "https://repo.spring.io/libs-spring-framework-build" }
255257
maven { url "https://repo.spring.io/milestone" } // temporarily for context-propagation via Reactor Netty
256-
maven { url "https://repo.spring.io/snapshot" } // Reactor
257258
}
258259
}
259260
configurations.all {
@@ -302,7 +303,7 @@ configure([rootProject] + javaProjects) { project ->
302303
}
303304

304305
checkstyle {
305-
toolVersion = "10.3"
306+
toolVersion = "10.3.1"
306307
configDirectory.set(rootProject.file("src/checkstyle"))
307308
}
308309

@@ -351,7 +352,7 @@ configure([rootProject] + javaProjects) { project ->
351352
// "https://junit.org/junit5/docs/5.8.2/api/",
352353
"https://www.reactive-streams.org/reactive-streams-1.0.3-javadoc/",
353354
"https://javadoc.io/static/io.rsocket/rsocket-core/1.1.1/",
354-
"https://r2dbc.io/spec/0.9.1.RELEASE/api/",
355+
"https://r2dbc.io/spec/1.0.0.RELEASE/api/",
355356
// The external Javadoc link for JSR 305 must come last to ensure that types from
356357
// JSR 250 (such as @PostConstruct) are still supported. This is due to the fact
357358
// that JSR 250 and JSR 305 both define types in javax.annotation, which results

spring-r2dbc/spring-r2dbc.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ dependencies {
1717
testImplementation(testFixtures(project(":spring-context")))
1818
testImplementation("io.projectreactor:reactor-test")
1919
testImplementation("io.r2dbc:r2dbc-h2")
20-
testImplementation("io.r2dbc:r2dbc-spi-test:0.9.1.RELEASE") {
20+
testImplementation("io.r2dbc:r2dbc-spi-test") {
2121
exclude group: "org.springframework", module: "spring-jdbc"
2222
}
2323
}

spring-r2dbc/src/test/java/org/springframework/r2dbc/core/DefaultDatabaseClientUnitTests.java

Lines changed: 6 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ class DefaultDatabaseClientUnitTests {
7272

7373
private DatabaseClient.Builder databaseClientBuilder;
7474

75+
7576
@BeforeEach
7677
@SuppressWarnings({ "rawtypes", "unchecked" })
7778
void before() {
@@ -84,6 +85,7 @@ void before() {
8485
connectionFactory).bindMarkers(BindMarkersFactory.indexed("$", 1));
8586
}
8687

88+
8789
@Test
8890
void connectionFactoryIsExposed() {
8991
ConnectionFactory connectionFactory = mock(ConnectionFactory.class);
@@ -96,7 +98,6 @@ void connectionFactoryIsExposed() {
9698
@Test
9799
void shouldCloseConnectionOnlyOnce() {
98100
DefaultDatabaseClient databaseClient = (DefaultDatabaseClient) databaseClientBuilder.build();
99-
100101
Flux<Object> flux = databaseClient.inConnectionMany(connection -> Flux.empty());
101102

102103
flux.subscribe(new CoreSubscriber<Object>() {
@@ -147,7 +148,6 @@ void executeShouldBindNullValues() {
147148
@SuppressWarnings("deprecation")
148149
void executeShouldBindSettableValues() {
149150
Statement statement = mockStatementFor("SELECT * FROM table WHERE key = $1");
150-
151151
DatabaseClient databaseClient = databaseClientBuilder.namedParameters(false).build();
152152

153153
databaseClient.sql("SELECT * FROM table WHERE key = $1").bind(0,
@@ -165,7 +165,6 @@ void executeShouldBindSettableValues() {
165165

166166
@Test
167167
void executeShouldBindNamedNullValues() {
168-
169168
Statement statement = mockStatementFor("SELECT * FROM table WHERE key = $1");
170169
DatabaseClient databaseClient = databaseClientBuilder.build();
171170

@@ -198,7 +197,6 @@ void executeShouldBindNamedValuesFromIndexes() {
198197
@SuppressWarnings("deprecation")
199198
void executeShouldBindValues() {
200199
Statement statement = mockStatementFor("SELECT * FROM table WHERE key = $1");
201-
202200
DatabaseClient databaseClient = databaseClientBuilder.build();
203201

204202
databaseClient.sql("SELECT * FROM table WHERE key = $1").bind(0,
@@ -214,7 +212,6 @@ void executeShouldBindValues() {
214212

215213
@Test
216214
void executeShouldBindNamedValuesByIndex() {
217-
218215
Statement statement = mockStatementFor("SELECT * FROM table WHERE key = $1");
219216
DatabaseClient databaseClient = databaseClientBuilder.build();
220217

@@ -227,9 +224,8 @@ void executeShouldBindNamedValuesByIndex() {
227224
@Test
228225
@SuppressWarnings("unchecked")
229226
void rowsUpdatedShouldEmitSingleValue() {
230-
231227
Result result = mock(Result.class);
232-
when(result.getRowsUpdated()).thenReturn(Mono.empty(), Mono.just(2), Flux.just(1, 2, 3));
228+
when(result.getRowsUpdated()).thenReturn(Mono.empty(), Mono.just(2L), Flux.just(1L, 2L, 3L));
233229
mockStatementFor("DROP TABLE tab;", result);
234230

235231
DatabaseClient databaseClient = databaseClientBuilder.build();
@@ -355,9 +351,7 @@ public void bindTo(BindTarget target) {
355351
@Test
356352
void shouldApplyStatementFilterFunctions() {
357353
MockResult result = MockResult.builder().build();
358-
359354
Statement statement = mockStatement(result);
360-
361355
DatabaseClient databaseClient = databaseClientBuilder.build();
362356

363357
databaseClient.sql("SELECT").filter(
@@ -376,9 +370,7 @@ void shouldApplyStatementFilterFunctions() {
376370
@Test
377371
void shouldApplySimpleStatementFilterFunctions() {
378372
MockResult result = mockSingleColumnEmptyResult();
379-
380373
Statement statement = mockStatement(result);
381-
382374
DatabaseClient databaseClient = databaseClientBuilder.build();
383375

384376
databaseClient.sql("SELECT").filter(
@@ -393,6 +385,7 @@ void shouldApplySimpleStatementFilterFunctions() {
393385
inOrder.verifyNoMoreInteractions();
394386
}
395387

388+
396389
private Statement mockStatement() {
397390
return mockStatementFor(null, null);
398391
}
@@ -407,14 +400,10 @@ private Statement mockStatementFor(String sql) {
407400

408401
private Statement mockStatementFor(@Nullable String sql, @Nullable Result result) {
409402
Statement statement = mock(Statement.class);
410-
when(connection.createStatement(sql == null ? anyString() : eq(sql))).thenReturn(
411-
statement);
403+
when(connection.createStatement(sql == null ? anyString() : eq(sql))).thenReturn(statement);
412404
when(statement.returnGeneratedValues(anyString())).thenReturn(statement);
413405
when(statement.returnGeneratedValues()).thenReturn(statement);
414-
415-
doReturn(result == null ? Mono.empty() : Flux.just(result)).when(
416-
statement).execute();
417-
406+
doReturn(result == null ? Mono.empty() : Flux.just(result)).when(statement).execute();
418407
return statement;
419408
}
420409

0 commit comments

Comments
 (0)