Skip to content

Commit 6f1acdd

Browse files
committed
Optimize ResolvableType cache
Prior to this commit, the ResolvableType static cache was holding a lot of duplicates for simple types. We are using too much metadata to compute the key when the class has no generic information. so setFoo(String foo) and setBar(String bar) would result in two entries in the cache because the TypeProvider is different. On a very simple application 65% of the entries in the cache were duplicate. When the type is a Class with no generic information, the ResolvableType instance is a simple wrapper around it so we might just as well not cache it at all as the cost of finding it back from the cache is higher than creating that simple wrapper. This commit adds an explicit check; if the type is a simple Class we just return a "resolved" ResolvableType instance for it. On a few test cases, this reduces the size of the cache by 85% Issue: SPR-12275
1 parent 62fc39c commit 6f1acdd

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

spring-core/src/main/java/org/springframework/core/ResolvableType.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1194,6 +1194,10 @@ static ResolvableType forType(Type type, TypeProvider typeProvider, VariableReso
11941194
}
11951195
// Check the cache, we may have a ResolvableType that may have already been resolved
11961196
cache.purgeUnreferencedEntries();
1197+
1198+
if (type instanceof Class<?>) {
1199+
return new ResolvableType(type, typeProvider, variableResolver, null);
1200+
}
11971201
ResolvableType key = new ResolvableType(type, typeProvider, variableResolver);
11981202
ResolvableType resolvableType = cache.get(key);
11991203
if (resolvableType == null) {

0 commit comments

Comments
 (0)