Skip to content

Commit 6d86b23

Browse files
izeyesdeleuze
authored andcommitted
Apply Checkstyle MethodParamPadCheck module
This commit also fixes its violations. Closes gh-34173
1 parent 0f38c28 commit 6d86b23

File tree

7 files changed

+9
-8
lines changed

7 files changed

+9
-8
lines changed

spring-context/src/test/java/org/springframework/context/event/ApplicationListenerMethodAdapterTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,8 @@ void invokeListenerWithGenericPayload() {
213213

214214
@Test
215215
void invokeListenerWithWrongGenericPayload() {
216-
Method method = ReflectionUtils.findMethod
217-
(SampleEvents.class, "handleGenericStringPayload", EntityWrapper.class);
216+
Method method = ReflectionUtils.findMethod(
217+
SampleEvents.class, "handleGenericStringPayload", EntityWrapper.class);
218218
EntityWrapper<Integer> payload = new EntityWrapper<>(123);
219219
invokeListener(method, new PayloadApplicationEvent<>(this, payload));
220220
verify(this.sampleEvents, times(0)).handleGenericStringPayload(any());

spring-context/src/test/java/org/springframework/context/support/ConversionServiceFactoryBeanTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public Foo convert(String source) {
6767
converters.add(new ConverterFactory<String, Bar>() {
6868
@Override
6969
public <T extends Bar> Converter<String, T> getConverter(Class<T> targetType) {
70-
return new Converter<> () {
70+
return new Converter<>() {
7171
@SuppressWarnings("unchecked")
7272
@Override
7373
public T convert(String source) {

spring-core/src/test/java/org/springframework/aot/generate/GeneratedClassesTests.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,8 @@ void getOrAddForFeatureComponentWhenHasFeatureNamePrefix() {
148148
"one", TestComponent.class, emptyTypeCustomizer);
149149
GeneratedClass generatedClass2 = this.generatedClasses.getOrAddForFeatureComponent(
150150
"one", TestComponent.class, emptyTypeCustomizer);
151-
GeneratedClass generatedClass3 = prefixed.getOrAddForFeatureComponent
152-
("one", TestComponent.class, emptyTypeCustomizer);
151+
GeneratedClass generatedClass3 = prefixed.getOrAddForFeatureComponent(
152+
"one", TestComponent.class, emptyTypeCustomizer);
153153
GeneratedClass generatedClass4 = prefixed.getOrAddForFeatureComponent(
154154
"one", TestComponent.class, emptyTypeCustomizer);
155155
assertThat(generatedClass1).isSameAs(generatedClass2).isNotSameAs(generatedClass3);

spring-messaging/src/main/java/org/springframework/messaging/handler/CompositeMessageCondition.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public int compareTo(CompositeMessageCondition other, Message<?> message) {
9898
checkCompatible(other);
9999
List<MessageCondition<?>> otherConditions = other.getMessageConditions();
100100
for (int i = 0; i < this.messageConditions.size(); i++) {
101-
int result = compare (this.messageConditions.get(i), otherConditions.get(i), message);
101+
int result = compare(this.messageConditions.get(i), otherConditions.get(i), message);
102102
if (result != 0) {
103103
return result;
104104
}

spring-web/src/main/java/org/springframework/web/bind/ServletRequestDataBinder.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ public final Object resolveValue(String name, Class<?> paramType) {
244244
@Nullable
245245
protected Object getRequestParameter(String name, Class<?> type) {
246246
Object value = this.request.getParameterValues(name);
247-
if (value == null && !name.endsWith ("[]") &&
247+
if (value == null && !name.endsWith("[]") &&
248248
(List.class.isAssignableFrom(type) || type.isArray())) {
249249
value = this.request.getParameterValues(name + "[]");
250250
}

spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/UriTemplateServletAnnotationControllerHandlerMethodTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@ public ModelValidatingViewResolver(Map<String, Object> attrsToValidate) {
665665

666666
@Override
667667
public View resolveViewName(final String viewName, Locale locale) {
668-
return new AbstractView () {
668+
return new AbstractView() {
669669
@Override
670670
public String getContentType() {
671671
return null;

src/checkstyle/checkstyle.xml

+1
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@
191191
<module name="com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck"/>
192192

193193
<!-- Whitespace -->
194+
<module name="com.puppycrawl.tools.checkstyle.checks.whitespace.MethodParamPadCheck"/>
194195
<module name="com.puppycrawl.tools.checkstyle.checks.whitespace.SingleSpaceSeparatorCheck"/>
195196

196197
<!-- Miscellaneous -->

0 commit comments

Comments
 (0)