Skip to content

Commit 604361e

Browse files
stsypanovjhoeller
authored andcommitted
Use concatenation instead of torn StringBuilder::append chain
1 parent cd0b517 commit 604361e

File tree

3 files changed

+6
-13
lines changed

3 files changed

+6
-13
lines changed

spring-aop/src/main/java/org/springframework/aop/interceptor/AbstractMonitoringInterceptor.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,12 @@ public void setLogTargetClassInvocation(boolean logTargetClassInvocation) {
9898
* @see #setSuffix
9999
*/
100100
protected String createInvocationTraceName(MethodInvocation invocation) {
101-
StringBuilder sb = new StringBuilder(getPrefix());
102101
Method method = invocation.getMethod();
103102
Class<?> clazz = method.getDeclaringClass();
104103
if (this.logTargetClassInvocation && clazz.isInstance(invocation.getThis())) {
105104
clazz = invocation.getThis().getClass();
106105
}
107-
sb.append(clazz.getName());
108-
sb.append('.').append(method.getName());
109-
sb.append(getSuffix());
110-
return sb.toString();
106+
return getPrefix() + clazz.getName() + '.' + method.getName() + getSuffix();
111107
}
112108

113109
}

spring-beans/src/main/java/org/springframework/beans/factory/support/GenericBeanDefinition.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,10 @@ public boolean equals(Object other) {
8989

9090
@Override
9191
public String toString() {
92-
StringBuilder sb = new StringBuilder("Generic bean");
9392
if (this.parentName != null) {
94-
sb.append(" with parent '").append(this.parentName).append("'");
93+
return "Generic bean with parent '" + this.parentName + "': " + super.toString();
9594
}
96-
sb.append(": ").append(super.toString());
97-
return sb.toString();
95+
return "Generic bean: " + super.toString();
9896
}
9997

10098
}

spring-context-support/src/main/java/org/springframework/cache/jcache/interceptor/AnnotationJCacheOperationSource.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,10 +212,9 @@ protected String generateDefaultCacheName(Method method) {
212212
parameters.add(parameterType.getName());
213213
}
214214

215-
StringBuilder sb = new StringBuilder(method.getDeclaringClass().getName());
216-
sb.append(".").append(method.getName());
217-
sb.append("(").append(StringUtils.collectionToCommaDelimitedString(parameters)).append(")");
218-
return sb.toString();
215+
return method.getDeclaringClass().getName()
216+
+ '.' + method.getName()
217+
+ '(' + StringUtils.collectionToCommaDelimitedString(parameters) + ')';
219218
}
220219

221220
private int countNonNull(Object... instances) {

0 commit comments

Comments
 (0)