Refine null-safety in the spring-web module

sdeleuze · sdeleuze · commit 5fba926ab63f · 2024-12-26T18:50:17.000+01:00
Closes gh-34162
diff --git a/spring-web/src/main/java/org/springframework/http/client/AbstractStreamingClientHttpRequest.java b/spring-web/src/main/java/org/springframework/http/client/AbstractStreamingClientHttpRequest.java
@@ -62,7 +62,7 @@ public final void setBody(Body body) {
 	}
 
 	@Override
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	protected final ClientHttpResponse executeInternal(HttpHeaders headers) throws IOException {
 		if (this.body == null && this.bodyStream != null) {
 			this.body = outputStream -> this.bodyStream.writeTo(outputStream);
diff --git a/spring-web/src/main/java/org/springframework/http/client/JdkClientHttpRequest.java b/spring-web/src/main/java/org/springframework/http/client/JdkClientHttpRequest.java
@@ -94,7 +94,6 @@ public URI getURI() {
 
 
 	@Override
-	@SuppressWarnings("NullAway")
 	protected ClientHttpResponse executeInternal(HttpHeaders headers, @Nullable Body body) throws IOException {
 		CompletableFuture<HttpResponse<InputStream>> responseFuture = null;
 		try {
@@ -133,7 +132,8 @@ else if (cause instanceof IOException ioEx) {
 				throw ioEx;
 			}
 			else {
-				throw new IOException(cause.getMessage(), cause);
+				String message = (cause == null ? null : cause.getMessage());
+				throw (message == null ? new IOException(cause) : new IOException(message, cause));
 			}
 		}
 	}
diff --git a/spring-web/src/main/java/org/springframework/http/client/JettyClientHttpRequest.java b/spring-web/src/main/java/org/springframework/http/client/JettyClientHttpRequest.java
@@ -69,7 +69,6 @@ public URI getURI() {
 	}
 
 	@Override
-	@SuppressWarnings("NullAway")
 	protected ClientHttpResponse executeInternal(HttpHeaders headers, @Nullable Body body) throws IOException {
 		if (!headers.isEmpty()) {
 			this.request.headers(httpFields -> {
@@ -118,7 +117,8 @@ else if (cause instanceof IOException ioEx) {
 				throw ioEx;
 			}
 			else {
-				throw new IOException(cause.getMessage(), cause);
+				String message = (cause == null ? null : cause.getMessage());
+				throw (message == null ? new IOException(cause) : new IOException(message, cause));
 			}
 		}
 		catch (TimeoutException ex) {
diff --git a/spring-web/src/main/java/org/springframework/http/codec/ServerSentEventHttpMessageReader.java b/spring-web/src/main/java/org/springframework/http/codec/ServerSentEventHttpMessageReader.java
@@ -135,7 +135,7 @@ public Flux<Object> read(
 				});
 	}
 
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	private @Nullable Object buildEvent(List<String> lines, ResolvableType valueType, boolean shouldWrap,
 			Map<String, Object> hints) {
 
diff --git a/spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartParser.java b/spring-web/src/main/java/org/springframework/http/codec/multipart/MultipartParser.java
@@ -49,7 +49,6 @@
  * @author Arjen Poutsma
  * @since 5.3
  */
-@SuppressWarnings("NullAway")
 final class MultipartParser extends BaseSubscriber<DataBuffer> {
 
 	private static final byte CR = '\r';
@@ -117,12 +116,14 @@ protected void hookOnSubscribe(Subscription subscription) {
 	}
 
 	@Override
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	protected void hookOnNext(DataBuffer value) {
 		this.requestOutstanding.set(false);
 		this.state.get().onNext(value);
 	}
 
 	@Override
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	protected void hookOnComplete() {
 		this.state.get().onComplete();
 	}
diff --git a/spring-web/src/main/java/org/springframework/http/codec/multipart/PartGenerator.java b/spring-web/src/main/java/org/springframework/http/codec/multipart/PartGenerator.java
@@ -57,7 +57,7 @@
  * @author Arjen Poutsma
  * @since 5.3
  */
-@SuppressWarnings("NullAway")
+@SuppressWarnings("NullAway") // Dataflow analysis limitation
 final class PartGenerator extends BaseSubscriber<MultipartParser.Token> {
 
 	private static final Log logger = LogFactory.getLog(PartGenerator.class);
diff --git a/spring-web/src/main/java/org/springframework/http/converter/ResourceRegionHttpMessageConverter.java b/spring-web/src/main/java/org/springframework/http/converter/ResourceRegionHttpMessageConverter.java
@@ -189,7 +189,7 @@ protected void writeResourceRegion(ResourceRegion region, HttpOutputMessage outp
 		}
 	}
 
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Not null assertion performed in StreamUtils#copyRange
 	private void writeResourceRegionCollection(Collection<ResourceRegion> resourceRegions,
 			HttpOutputMessage outputMessage) throws IOException {
 
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerReadPublisher.java b/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerReadPublisher.java
@@ -47,7 +47,7 @@
  * @since 5.0
  * @param <T> the type of element signaled
  */
-@SuppressWarnings("NullAway")
+@SuppressWarnings("NullAway") // Dataflow analysis limitation
 public abstract class AbstractListenerReadPublisher<T> implements Publisher<T> {
 
 	/**
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteFlushProcessor.java b/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteFlushProcessor.java
@@ -40,7 +40,7 @@
  * @since 5.0
  * @param <T> the type of element signaled to the {@link Subscriber}
  */
-@SuppressWarnings("NullAway")
+@SuppressWarnings("NullAway") // Dataflow analysis limitation
 public abstract class AbstractListenerWriteFlushProcessor<T> implements Processor<Publisher<? extends T>, Void> {
 
 	/**
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java b/spring-web/src/main/java/org/springframework/http/server/reactive/AbstractListenerWriteProcessor.java
@@ -43,7 +43,7 @@
  * @since 5.0
  * @param <T> the type of element signaled to the {@link Subscriber}
  */
-@SuppressWarnings("NullAway")
+@SuppressWarnings("NullAway") // Dataflow analysis limitation
 public abstract class AbstractListenerWriteProcessor<T> implements Processor<T, Void> {
 
 	/**
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java b/spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java
@@ -159,7 +159,7 @@ private static URI initUri(HttpServletRequest servletRequest) {
 		}
 	}
 
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	private static HttpHeaders initHeaders(HttpHeaders headerValues, HttpServletRequest request) {
 
 		HttpHeaders headers = null;
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/WriteResultPublisher.java b/spring-web/src/main/java/org/springframework/http/server/reactive/WriteResultPublisher.java
@@ -36,7 +36,7 @@
  * @author Rossen Stoyanchev
  * @since 5.0
  */
-@SuppressWarnings("NullAway")
+@SuppressWarnings("NullAway") // Dataflow analysis limitation
 class WriteResultPublisher implements Publisher<Void> {
 
 	/**
diff --git a/spring-web/src/main/java/org/springframework/web/client/DefaultResponseErrorHandler.java b/spring-web/src/main/java/org/springframework/web/client/DefaultResponseErrorHandler.java
@@ -243,7 +243,7 @@ private String getErrorMessage(
 	 * {@link RestClientResponseException#setBodyConvertFunction(Function)}.
 	 * @since 6.0
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	protected Function<ResolvableType, ?> initBodyConvertFunction(ClientHttpResponse response, byte[] body) {
 		Assert.state(!CollectionUtils.isEmpty(this.messageConverters), "Expected message converters");
 		return resolvableType -> {
diff --git a/spring-web/src/main/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequest.java b/spring-web/src/main/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequest.java
@@ -83,7 +83,7 @@ public StandardServletAsyncWebRequest(HttpServletRequest request, HttpServletRes
 	 * @param previousRequest the existing request from the last dispatch
 	 * @since 5.3.33
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	StandardServletAsyncWebRequest(HttpServletRequest request, HttpServletResponse response,
 			@Nullable StandardServletAsyncWebRequest previousRequest) {
 
@@ -272,7 +272,7 @@ public void setAsyncWebRequest(StandardServletAsyncWebRequest asyncWebRequest) {
 		}
 
 		@Override
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		public ServletOutputStream getOutputStream() throws IOException {
 			int level = obtainLockOrRaiseException();
 			try {
@@ -292,7 +292,7 @@ public ServletOutputStream getOutputStream() throws IOException {
 		}
 
 		@Override
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		public PrintWriter getWriter() throws IOException {
 			int level = obtainLockOrRaiseException();
 			try {
diff --git a/spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncManager.java b/spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncManager.java
@@ -298,7 +298,7 @@ public void startCallableProcessing(Callable<?> callable, Object... processingCo
 	 * via {@link #getConcurrentResultContext()}
 	 * @throws Exception if concurrent processing failed to start
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	public void startCallableProcessing(final WebAsyncTask<?> webAsyncTask, Object... processingContext)
 			throws Exception {
 
@@ -419,7 +419,7 @@ private void setConcurrentResultAndDispatch(@Nullable Object result) {
 	 * @see #getConcurrentResult()
 	 * @see #getConcurrentResultContext()
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	public void startDeferredResultProcessing(
 			final DeferredResult<?> deferredResult, Object... processingContext) throws Exception {
 
diff --git a/spring-web/src/main/java/org/springframework/web/context/support/ServletContextResourcePatternResolver.java b/spring-web/src/main/java/org/springframework/web/context/support/ServletContextResourcePatternResolver.java
@@ -104,7 +104,7 @@ protected Set<Resource> doFindPathMatchingFileResources(Resource rootDirResource
 	 * @see ServletContextResource
 	 * @see jakarta.servlet.ServletContext#getResourcePaths
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Dataflow analysis limitation
 	protected void doRetrieveMatchingServletContextResources(
 			ServletContext servletContext, String fullPattern, String dir, Set<Resource> result)
 			throws IOException {
diff --git a/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java b/spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java
@@ -162,7 +162,7 @@ private String trimTrailingSlash(String origin) {
 	/**
 	 * Variant of {@link #setAllowedOrigins} for adding one origin at a time.
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	public void addAllowedOrigin(@Nullable String origin) {
 		if (origin == null) {
 			return;
@@ -235,7 +235,7 @@ public CorsConfiguration setAllowedOriginPatterns(@Nullable List<String> allowed
 	 * Variant of {@link #setAllowedOriginPatterns} for adding one origin at a time.
 	 * @since 5.3
 	 */
-	@SuppressWarnings("NullAway")
+	@SuppressWarnings("NullAway") // Lambda
 	public void addAllowedOriginPattern(@Nullable String originPattern) {
 		if (originPattern == null) {
 			return;
diff --git a/spring-web/src/main/java/org/springframework/web/multipart/support/AbstractMultipartHttpServletRequest.java b/spring-web/src/main/java/org/springframework/web/multipart/support/AbstractMultipartHttpServletRequest.java
@@ -44,7 +44,8 @@
 public abstract class AbstractMultipartHttpServletRequest extends HttpServletRequestWrapper
 		implements MultipartHttpServletRequest {
 
-	private @Nullable MultiValueMap<String, MultipartFile> multipartFiles;
+	@SuppressWarnings("NullAway.Init")
+	private MultiValueMap<String, MultipartFile> multipartFiles;
 
 
 	/**
@@ -135,7 +136,6 @@ protected final void setMultipartFiles(MultiValueMap<String, MultipartFile> mult
 	 * lazily initializing it if necessary.
 	 * @see #initializeMultipart()
 	 */
-	@SuppressWarnings("NullAway")
 	protected MultiValueMap<String, MultipartFile> getMultipartFiles() {
 		if (this.multipartFiles == null) {
 			initializeMultipart();
diff --git a/spring-web/src/main/java/org/springframework/web/multipart/support/DefaultMultipartHttpServletRequest.java b/spring-web/src/main/java/org/springframework/web/multipart/support/DefaultMultipartHttpServletRequest.java
@@ -45,9 +45,11 @@ public class DefaultMultipartHttpServletRequest extends AbstractMultipartHttpSer
 
 	private static final String CONTENT_TYPE = "Content-Type";
 
-	private @Nullable Map<String, String[]> multipartParameters;
+	@SuppressWarnings("NullAway.Init")
+	private Map<String, String[]> multipartParameters;
 
-	private @Nullable Map<String, String> multipartParameterContentTypes;
+	@SuppressWarnings("NullAway.Init")
+	private Map<String, String> multipartParameterContentTypes;
 
 
 	/**
@@ -164,7 +166,6 @@ protected final void setMultipartParameters(Map<String, String[]> multipartParam
 	 * lazily initializing it if necessary.
 	 * @see #initializeMultipart()
 	 */
-	@SuppressWarnings("NullAway")
 	protected Map<String, String[]> getMultipartParameters() {
 		if (this.multipartParameters == null) {
 			initializeMultipart();
@@ -185,7 +186,6 @@ protected final void setMultipartParameterContentTypes(Map<String, String> multi
 	 * lazily initializing it if necessary.
 	 * @see #initializeMultipart()
 	 */
-	@SuppressWarnings("NullAway")
 	protected Map<String, String> getMultipartParameterContentTypes() {
 		if (this.multipartParameterContentTypes == null) {
 			initializeMultipart();
diff --git a/spring-web/src/main/java/org/springframework/web/multipart/support/StandardMultipartHttpServletRequest.java b/spring-web/src/main/java/org/springframework/web/multipart/support/StandardMultipartHttpServletRequest.java
@@ -58,7 +58,8 @@
  */
 public class StandardMultipartHttpServletRequest extends AbstractMultipartHttpServletRequest {
 
-	private @Nullable Set<String> multipartParameterNames;
+	@SuppressWarnings("NullAway.Init")
+	private Set<String> multipartParameterNames;
 
 
 	/**
@@ -138,7 +139,6 @@ protected void initializeMultipart() {
 	}
 
 	@Override
-	@SuppressWarnings("NullAway")
 	public Enumeration<String> getParameterNames() {
 		if (this.multipartParameterNames == null) {
 			initializeMultipart();
@@ -159,7 +159,6 @@ public Enumeration<String> getParameterNames() {
 	}
 
 	@Override
-	@SuppressWarnings("NullAway")
 	public Map<String, String[]> getParameterMap() {
 		if (this.multipartParameterNames == null) {
 			initializeMultipart();
diff --git a/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java b/spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java
@@ -86,7 +86,8 @@ public class HttpWebHandlerAdapter extends WebHandlerDecorator implements HttpHa
 
 	private WebSessionManager sessionManager = new DefaultWebSessionManager();
 
-	private @Nullable ServerCodecConfigurer codecConfigurer;
+	@SuppressWarnings("NullAway.Init")
+	private ServerCodecConfigurer codecConfigurer;
 
 	private LocaleContextResolver localeContextResolver = new AcceptHeaderLocaleContextResolver();
 
@@ -149,7 +150,6 @@ public void setCodecConfigurer(ServerCodecConfigurer codecConfigurer) {
 	/**
 	 * Return the configured {@link ServerCodecConfigurer}.
 	 */
-	@SuppressWarnings("NullAway")
 	public ServerCodecConfigurer getCodecConfigurer() {
 		if (this.codecConfigurer == null) {
 			setCodecConfigurer(ServerCodecConfigurer.create());
diff --git a/spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java b/spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java
@@ -189,7 +189,7 @@ public InMemoryWebSession(Instant creationTime) {
 		}
 
 		@Override
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		public String getId() {
 			return this.id.get();
 		}
@@ -225,7 +225,7 @@ public void start() {
 		}
 
 		@Override
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		public boolean isStarted() {
 			return this.state.get().equals(State.STARTED) || !getAttributes().isEmpty();
 		}
@@ -254,7 +254,7 @@ public Mono<Void> invalidate() {
 		}
 
 		@Override
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		public Mono<Void> save() {
 
 			checkMaxSessionsLimit();
@@ -292,7 +292,7 @@ public boolean isExpired() {
 			return isExpired(clock.instant());
 		}
 
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		private boolean isExpired(Instant now) {
 			if (this.state.get().equals(State.EXPIRED)) {
 				return true;
diff --git a/spring-web/src/main/java/org/springframework/web/service/invoker/HttpServiceMethod.java b/spring-web/src/main/java/org/springframework/web/service/invoker/HttpServiceMethod.java
@@ -236,7 +236,7 @@ public static HttpRequestValuesInitializer create(
 			return null;
 		}
 
-		@SuppressWarnings("NullAway")
+		@SuppressWarnings("NullAway") // Dataflow analysis limitation
 		private static @Nullable String initUrl(
 				@Nullable HttpExchange typeAnnotation, HttpExchange methodAnnotation,
 				@Nullable StringValueResolver embeddedValueResolver) {

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public final void setBody(Body body) {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`@Override`
`65`		`- @SuppressWarnings("NullAway")`
	`65`	`+ @SuppressWarnings("NullAway") // Lambda`
`66`	`66`	`protected final ClientHttpResponse executeInternal(HttpHeaders headers) throws IOException {`
`67`	`67`	`if (this.body == null && this.bodyStream != null) {`
`68`	`68`	`this.body = outputStream -> this.bodyStream.writeTo(outputStream);`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,6 @@ public URI getURI() {`
`94`	`94`
`95`	`95`
`96`	`96`	`@Override`
`97`		`- @SuppressWarnings("NullAway")`
`98`	`97`	`protected ClientHttpResponse executeInternal(HttpHeaders headers, @Nullable Body body) throws IOException {`
`99`	`98`	`CompletableFuture<HttpResponse<InputStream>> responseFuture = null;`
`100`	`99`	`try {`
`@@ -133,7 +132,8 @@ else if (cause instanceof IOException ioEx) {`
`133`	`132`	`throw ioEx;`
`134`	`133`	`}`
`135`	`134`	`else {`
`136`		`- throw new IOException(cause.getMessage(), cause);`
	`135`	`+ String message = (cause == null ? null : cause.getMessage());`
	`136`	`+ throw (message == null ? new IOException(cause) : new IOException(message, cause));`
`137`	`137`	`}`
`138`	`138`	`}`
`139`	`139`	`}`
Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ public URI getURI() {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`@Override`
`72`		`- @SuppressWarnings("NullAway")`
`73`	`72`	`protected ClientHttpResponse executeInternal(HttpHeaders headers, @Nullable Body body) throws IOException {`
`74`	`73`	`if (!headers.isEmpty()) {`
`75`	`74`	`this.request.headers(httpFields -> {`
`@@ -118,7 +117,8 @@ else if (cause instanceof IOException ioEx) {`
`118`	`117`	`throw ioEx;`
`119`	`118`	`}`
`120`	`119`	`else {`
`121`		`- throw new IOException(cause.getMessage(), cause);`
	`120`	`+ String message = (cause == null ? null : cause.getMessage());`
	`121`	`+ throw (message == null ? new IOException(cause) : new IOException(message, cause));`
`122`	`122`	`}`
`123`	`123`	`}`
`124`	`124`	`catch (TimeoutException ex) {`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public Flux<Object> read(`
`135`	`135`	`});`
`136`	`136`	`}`
`137`	`137`
`138`		`- @SuppressWarnings("NullAway")`
	`138`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`139`	`139`	`private @Nullable Object buildEvent(List<String> lines, ResolvableType valueType, boolean shouldWrap,`
`140`	`140`	`Map<String, Object> hints) {`
`141`	`141`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,6 @@`
`49`	`49`	`* @author Arjen Poutsma`
`50`	`50`	`* @since 5.3`
`51`	`51`	`*/`
`52`		`-@SuppressWarnings("NullAway")`
`53`	`52`	`final class MultipartParser extends BaseSubscriber<DataBuffer> {`
`54`	`53`
`55`	`54`	`private static final byte CR = '\r';`
`@@ -117,12 +116,14 @@ protected void hookOnSubscribe(Subscription subscription) {`
`117`	`116`	`}`
`118`	`117`
`119`	`118`	`@Override`
	`119`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`120`	`120`	`protected void hookOnNext(DataBuffer value) {`
`121`	`121`	`this.requestOutstanding.set(false);`
`122`	`122`	`this.state.get().onNext(value);`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`@Override`
	`126`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`126`	`127`	`protected void hookOnComplete() {`
`127`	`128`	`this.state.get().onComplete();`
`128`	`129`	`}`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ protected void writeResourceRegion(ResourceRegion region, HttpOutputMessage outp`
`189`	`189`	`}`
`190`	`190`	`}`
`191`	`191`
`192`		`- @SuppressWarnings("NullAway")`
	`192`	`+ @SuppressWarnings("NullAway") // Not null assertion performed in StreamUtils#copyRange`
`193`	`193`	`private void writeResourceRegionCollection(Collection<ResourceRegion> resourceRegions,`
`194`	`194`	`HttpOutputMessage outputMessage) throws IOException {`
`195`	`195`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ private static URI initUri(HttpServletRequest servletRequest) {`
`159`	`159`	`}`
`160`	`160`	`}`
`161`	`161`
`162`		`- @SuppressWarnings("NullAway")`
	`162`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`163`	`163`	`private static HttpHeaders initHeaders(HttpHeaders headerValues, HttpServletRequest request) {`
`164`	`164`
`165`	`165`	`HttpHeaders headers = null;`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ public InMemoryWebSession(Instant creationTime) {`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`@Override`
`192`		`- @SuppressWarnings("NullAway")`
	`192`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`193`	`193`	`public String getId() {`
`194`	`194`	`return this.id.get();`
`195`	`195`	`}`
`@@ -225,7 +225,7 @@ public void start() {`
`225`	`225`	`}`
`226`	`226`
`227`	`227`	`@Override`
`228`		`- @SuppressWarnings("NullAway")`
	`228`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`229`	`229`	`public boolean isStarted() {`
`230`	`230`	`return this.state.get().equals(State.STARTED) \|\| !getAttributes().isEmpty();`
`231`	`231`	`}`
`@@ -254,7 +254,7 @@ public Mono<Void> invalidate() {`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`@Override`
`257`		`- @SuppressWarnings("NullAway")`
	`257`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`258`	`258`	`public Mono<Void> save() {`
`259`	`259`
`260`	`260`	`checkMaxSessionsLimit();`
`@@ -292,7 +292,7 @@ public boolean isExpired() {`
`292`	`292`	`return isExpired(clock.instant());`
`293`	`293`	`}`
`294`	`294`
`295`		`- @SuppressWarnings("NullAway")`
	`295`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`296`	`296`	`private boolean isExpired(Instant now) {`
`297`	`297`	`if (this.state.get().equals(State.EXPIRED)) {`
`298`	`298`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ public static HttpRequestValuesInitializer create(`
`236`	`236`	`return null;`
`237`	`237`	`}`
`238`	`238`
`239`		`- @SuppressWarnings("NullAway")`
	`239`	`+ @SuppressWarnings("NullAway") // Dataflow analysis limitation`
`240`	`240`	`private static @Nullable String initUrl(`
`241`	`241`	`@Nullable HttpExchange typeAnnotation, HttpExchange methodAnnotation,`
`242`	`242`	`@Nullable StringValueResolver embeddedValueResolver) {`