Skip to content

Commit 49593f5

Browse files
committed
Revise DependencyDescriptor etc to avoid MethodParameter deprecations
See gh-23385
1 parent b67dbe6 commit 49593f5

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

spring-beans/src/main/java/org/springframework/beans/GenericTypeAwarePropertyDescriptor.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ public GenericTypeAwarePropertyDescriptor(Class<?> beanClass, String propertyNam
102102
this.ambiguousWriteMethods = ambiguousCandidates;
103103
}
104104
}
105-
this.writeMethodParameter = new MethodParameter(this.writeMethod, 0);
106-
GenericTypeResolver.resolveParameterType(this.writeMethodParameter, this.beanClass);
105+
this.writeMethodParameter = new MethodParameter(this.writeMethod, 0).withContainingClass(this.beanClass);
107106
}
108107

109108
if (this.readMethod != null) {

spring-beans/src/main/java/org/springframework/beans/factory/config/DependencyDescriptor.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.springframework.beans.factory.BeanFactory;
3434
import org.springframework.beans.factory.InjectionPoint;
3535
import org.springframework.beans.factory.NoUniqueBeanDefinitionException;
36-
import org.springframework.core.GenericTypeResolver;
3736
import org.springframework.core.KotlinDetector;
3837
import org.springframework.core.MethodParameter;
3938
import org.springframework.core.ParameterNameDiscoverer;
@@ -280,13 +279,12 @@ public Object resolveCandidate(String beanName, Class<?> requiredType, BeanFacto
280279

281280
/**
282281
* Increase this descriptor's nesting level.
283-
* @see MethodParameter#increaseNestingLevel()
284282
*/
285283
public void increaseNestingLevel() {
286284
this.nestingLevel++;
287285
this.resolvableType = null;
288286
if (this.methodParameter != null) {
289-
this.methodParameter.increaseNestingLevel();
287+
this.methodParameter = this.methodParameter.nested();
290288
}
291289
}
292290

@@ -300,7 +298,7 @@ public void setContainingClass(Class<?> containingClass) {
300298
this.containingClass = containingClass;
301299
this.resolvableType = null;
302300
if (this.methodParameter != null) {
303-
GenericTypeResolver.resolveParameterType(this.methodParameter, containingClass);
301+
this.methodParameter = this.methodParameter.withContainingClass(containingClass);
304302
}
305303
}
306304

@@ -457,7 +455,7 @@ private void readObject(ObjectInputStream ois) throws IOException, ClassNotFound
457455
this.declaringClass.getDeclaredConstructor(this.parameterTypes), this.parameterIndex);
458456
}
459457
for (int i = 1; i < this.nestingLevel; i++) {
460-
this.methodParameter.increaseNestingLevel();
458+
this.methodParameter = this.methodParameter.nested();
461459
}
462460
}
463461
}

spring-beans/src/main/java/org/springframework/beans/factory/support/ConstructorResolver.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
import org.springframework.beans.factory.config.ConstructorArgumentValues.ValueHolder;
5454
import org.springframework.beans.factory.config.DependencyDescriptor;
5555
import org.springframework.core.CollectionFactory;
56-
import org.springframework.core.GenericTypeResolver;
5756
import org.springframework.core.MethodParameter;
5857
import org.springframework.core.NamedThreadLocal;
5958
import org.springframework.core.ParameterNameDiscoverer;
@@ -810,7 +809,6 @@ private Object[] resolvePreparedArguments(String beanName, RootBeanDefinition mb
810809
for (int argIndex = 0; argIndex < argsToResolve.length; argIndex++) {
811810
Object argValue = argsToResolve[argIndex];
812811
MethodParameter methodParam = MethodParameter.forExecutable(executable, argIndex);
813-
GenericTypeResolver.resolveParameterType(methodParam, executable.getDeclaringClass());
814812
if (argValue instanceof AutowiredArgumentMarker) {
815813
argValue = resolveAutowiredArgument(methodParam, beanName, null, converter, fallback);
816814
}

0 commit comments

Comments
 (0)