Skip to content

Commit 48ad7b1

Browse files
committed
Remove unused code in WebHttpHandlerBuilder
The code was necessary while ForwardedHeaderFilter was deprecated but still possible to use. When the filter was removed, this code could have been removed as well.
1 parent a3b62a8 commit 48ad7b1

File tree

1 file changed

+1
-22
lines changed

1 file changed

+1
-22
lines changed

spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2023 the original author or authors.
2+
* Copyright 2002-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -243,7 +243,6 @@ public static WebHttpHandlerBuilder applicationContext(ApplicationContext contex
243243
public WebHttpHandlerBuilder filter(WebFilter... filters) {
244244
if (!ObjectUtils.isEmpty(filters)) {
245245
this.filters.addAll(Arrays.asList(filters));
246-
updateFilters();
247246
}
248247
return this;
249248
}
@@ -254,29 +253,9 @@ public WebHttpHandlerBuilder filter(WebFilter... filters) {
254253
*/
255254
public WebHttpHandlerBuilder filters(Consumer<List<WebFilter>> consumer) {
256255
consumer.accept(this.filters);
257-
updateFilters();
258256
return this;
259257
}
260258

261-
private void updateFilters() {
262-
if (this.filters.isEmpty()) {
263-
return;
264-
}
265-
266-
List<WebFilter> filtersToUse = this.filters.stream()
267-
.peek(filter -> {
268-
if (filter instanceof ForwardedHeaderTransformer forwardedHeaderTransformerFilter
269-
&& this.forwardedHeaderTransformer == null) {
270-
this.forwardedHeaderTransformer = forwardedHeaderTransformerFilter;
271-
}
272-
})
273-
.filter(filter -> !(filter instanceof ForwardedHeaderTransformer))
274-
.toList();
275-
276-
this.filters.clear();
277-
this.filters.addAll(filtersToUse);
278-
}
279-
280259
/**
281260
* Add the given exception handler(s).
282261
* @param handlers the exception handler(s)

0 commit comments

Comments
 (0)