Skip to content

Commit 43a60a7

Browse files
committed
Polishing
1 parent 9e1ef83 commit 43a60a7

File tree

1 file changed

+25
-33
lines changed

1 file changed

+25
-33
lines changed

spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/MethodValidationTests.java

+25-33
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package org.springframework.web.servlet.mvc.method.annotation;
1818

1919
import java.lang.reflect.Method;
20-
import java.util.Collections;
2120
import java.util.HashMap;
2221
import java.util.List;
2322
import java.util.Set;
@@ -134,14 +133,13 @@ void modelAttribute() {
134133
assertThat(this.jakartaValidator.getValidationCount()).isEqualTo(1);
135134
assertThat(this.jakartaValidator.getMethodValidationCount()).as("Method validation unexpected").isEqualTo(0);
136135

137-
assertBeanResult(ex.getBindingResult(), "student", Collections.singletonList(
138-
"""
136+
assertBeanResult(ex.getBindingResult(), "student", List.of("""
139137
Field error in object 'student' on field 'name': rejected value [name=Faustino1234]; \
140138
codes [Size.student.name,Size.name,Size.java.lang.String,Size]; \
141139
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
142140
codes [student.name,name]; arguments []; default message [name],10,1]; \
143-
default message [size must be between 1 and 10]"""));
144-
141+
default message [size must be between 1 and 10]"""
142+
));
145143
}
146144

147145
@Test
@@ -154,8 +152,7 @@ void modelAttributeWithBindingResult() throws Exception {
154152
assertThat(this.jakartaValidator.getValidationCount()).isEqualTo(1);
155153
assertThat(this.jakartaValidator.getMethodValidationCount()).as("Method validation unexpected").isEqualTo(0);
156154

157-
assertThat(response.getContentAsString()).isEqualTo(
158-
"""
155+
assertThat(response.getContentAsString()).isEqualTo("""
159156
org.springframework.validation.BeanPropertyBindingResult: 1 errors
160157
Field error in object 'student' on field 'name': rejected value [name=Faustino1234]; \
161158
codes [Size.student.name,Size.name,Size.java.lang.String,Size]; \
@@ -179,16 +176,15 @@ void modelAttributeWithBindingResultAndRequestHeader() {
179176

180177
assertThat(ex.getAllValidationResults()).hasSize(2);
181178

182-
assertBeanResult(ex.getBeanResults().get(0), "student", Collections.singletonList(
183-
"""
179+
assertBeanResult(ex.getBeanResults().get(0), "student", List.of("""
184180
Field error in object 'student' on field 'name': rejected value [name=Faustino1234]; \
185181
codes [Size.student.name,Size.name,Size.java.lang.String,Size]; \
186182
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
187183
codes [student.name,name]; arguments []; default message [name],10,1]; \
188-
default message [size must be between 1 and 10]"""));
184+
default message [size must be between 1 and 10]"""
185+
));
189186

190-
assertValueResult(ex.getValueResults().get(0), 2, "123", Collections.singletonList(
191-
"""
187+
assertValueResult(ex.getValueResults().get(0), 2, "123", List.of("""
192188
org.springframework.context.support.DefaultMessageSourceResolvable: \
193189
codes [Size.validController#handle.myHeader,Size.myHeader,Size.java.lang.String,Size]; \
194190
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
@@ -212,8 +208,7 @@ void validatedWithMethodValidation() throws Exception {
212208
assertThat(jakartaValidator.getValidationCount()).isEqualTo(2);
213209
assertThat(jakartaValidator.getMethodValidationCount()).isEqualTo(1);
214210

215-
assertThat(response.getContentAsString()).isEqualTo(
216-
"""
211+
assertThat(response.getContentAsString()).isEqualTo("""
217212
org.springframework.validation.BeanPropertyBindingResult: 1 errors
218213
Field error in object 'person' on field 'name': rejected value [name=Faustino1234]; \
219214
codes [Size.person.name,Size.name,Size.java.lang.String,Size]; \
@@ -237,21 +232,20 @@ void validateList() {
237232

238233
assertThat(ex.getAllValidationResults()).hasSize(2);
239234

240-
assertBeanResult(ex.getBeanResults().get(0), "personList", Collections.singletonList(
241-
"""
242-
Field error in object 'personList' on field 'name': rejected value [Faustino1234]; \
243-
codes [Size.personList.name,Size.name,Size.java.lang.String,Size]; \
244-
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
245-
codes [personList.name,name]; arguments []; default message [name],10,1]; \
246-
default message [size must be between 1 and 10]"""));
247-
248-
assertBeanResult(ex.getBeanResults().get(1), "personList", Collections.singletonList(
249-
"""
250-
Field error in object 'personList' on field 'name': rejected value [Cayetana6789]; \
251-
codes [Size.personList.name,Size.name,Size.java.lang.String,Size]; \
252-
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
253-
codes [personList.name,name]; arguments []; default message [name],10,1]; \
254-
default message [size must be between 1 and 10]"""
235+
assertBeanResult(ex.getBeanResults().get(0), "personList", List.of("""
236+
Field error in object 'personList' on field 'name': rejected value [Faustino1234]; \
237+
codes [Size.personList.name,Size.name,Size.java.lang.String,Size]; \
238+
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
239+
codes [personList.name,name]; arguments []; default message [name],10,1]; \
240+
default message [size must be between 1 and 10]"""
241+
));
242+
243+
assertBeanResult(ex.getBeanResults().get(1), "personList", List.of("""
244+
Field error in object 'personList' on field 'name': rejected value [Cayetana6789]; \
245+
codes [Size.personList.name,Size.name,Size.java.lang.String,Size]; \
246+
arguments [org.springframework.context.support.DefaultMessageSourceResolvable: \
247+
codes [personList.name,name]; arguments []; default message [name],10,1]; \
248+
default message [size must be between 1 and 10]"""
255249
));
256250

257251
}
@@ -267,8 +261,7 @@ void jakartaAndSpringValidator() throws Exception {
267261
assertThat(jakartaValidator.getValidationCount()).isEqualTo(1);
268262
assertThat(jakartaValidator.getMethodValidationCount()).isEqualTo(1);
269263

270-
assertThat(response.getContentAsString()).isEqualTo(
271-
"""
264+
assertThat(response.getContentAsString()).isEqualTo("""
272265
org.springframework.validation.BeanPropertyBindingResult: 2 errors
273266
Field error in object 'person' on field 'name': rejected value [name=Faustino1234]; \
274267
codes [TOO_LONG.person.name,TOO_LONG.name,TOO_LONG.java.lang.String,TOO_LONG]; \
@@ -289,8 +282,7 @@ void springValidator() throws Exception {
289282
RequestMappingHandlerAdapter springValidatorHandlerAdapter = initHandlerAdapter(new PersonValidator());
290283
springValidatorHandlerAdapter.handle(this.request, this.response, hm);
291284

292-
assertThat(response.getContentAsString()).isEqualTo(
293-
"""
285+
assertThat(response.getContentAsString()).isEqualTo("""
294286
org.springframework.validation.BeanPropertyBindingResult: 1 errors
295287
Field error in object 'student' on field 'name': rejected value [name=Faustino1234]; \
296288
codes [TOO_LONG.student.name,TOO_LONG.name,TOO_LONG.java.lang.String,TOO_LONG]; \

0 commit comments

Comments
 (0)