NettyHeadersAdapter::putAll does not overwrite headers

poutsma · poutsma · commit 4078b73cec8e · 2022-01-10T10:54:04.000+01:00
NettyHeadersAdapter::putAll uses HttpHeaders::add, which does not overwrite existing headers. putAll should use HttpHeaders::set instead, just like NettyHeadersAdapter::put does. Closes gh-27887
diff --git a/spring-web/src/main/java/org/springframework/http/server/reactive/NettyHeadersAdapter.java b/spring-web/src/main/java/org/springframework/http/server/reactive/NettyHeadersAdapter.java
@@ -147,7 +147,7 @@ public List<String> remove(Object key) {
 
 	@Override
 	public void putAll(Map<? extends String, ? extends List<String>> map) {
-		map.forEach(this.headers::add);
+		map.forEach(this.headers::set);
 	}
 
 	@Override

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,7 @@ public List<String> remove(Object key) {`
`147`	`147`
`148`	`148`	`@Override`
`149`	`149`	`public void putAll(Map<? extends String, ? extends List<String>> map) {`
`150`		`- map.forEach(this.headers::add);`
	`150`	`+ map.forEach(this.headers::set);`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`@Override`