Skip to content

Commit 1ce22bd

Browse files
committed
Remove MethodArgumentNotValidException(Executable, BindingResult)
Closes gh-30559
1 parent 4e67847 commit 1ce22bd

File tree

1 file changed

+3
-31
lines changed

1 file changed

+3
-31
lines changed

spring-web/src/main/java/org/springframework/web/bind/MethodArgumentNotValidException.java

Lines changed: 3 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package org.springframework.web.bind;
1818

19-
import java.lang.reflect.Executable;
2019
import java.util.ArrayList;
2120
import java.util.LinkedHashMap;
2221
import java.util.List;
@@ -49,12 +48,8 @@
4948
@SuppressWarnings("serial")
5049
public class MethodArgumentNotValidException extends BindException implements ErrorResponse {
5150

52-
@Nullable
5351
private final MethodParameter parameter;
5452

55-
@Nullable
56-
private final Executable executable;
57-
5853
private final ProblemDetail body;
5954

6055

@@ -66,22 +61,6 @@ public class MethodArgumentNotValidException extends BindException implements Er
6661
public MethodArgumentNotValidException(MethodParameter parameter, BindingResult bindingResult) {
6762
super(bindingResult);
6863
this.parameter = parameter;
69-
this.executable = null;
70-
this.body = ProblemDetail.forStatusAndDetail(getStatusCode(), "Invalid request content.");
71-
}
72-
73-
/**
74-
* Constructor for {@link MethodArgumentNotValidException}.
75-
* @param executable the executable that failed validation
76-
* @param bindingResult the results of the validation
77-
* @since 6.0.5
78-
* @deprecated in favor of {@link #MethodArgumentNotValidException(MethodParameter, BindingResult)}
79-
*/
80-
@Deprecated(since = "6.0.10", forRemoval = true)
81-
public MethodArgumentNotValidException(Executable executable, BindingResult bindingResult) {
82-
super(bindingResult);
83-
this.parameter = null;
84-
this.executable = executable;
8564
this.body = ProblemDetail.forStatusAndDetail(getStatusCode(), "Invalid request content.");
8665
}
8766

@@ -105,16 +84,9 @@ public final MethodParameter getParameter() {
10584

10685
@Override
10786
public String getMessage() {
108-
StringBuilder sb = new StringBuilder("Validation failed ");
109-
if (this.parameter != null) {
110-
sb.append("for argument [")
111-
.append(this.parameter.getParameterIndex()).append("] in ")
112-
.append(this.parameter.getExecutable().toGenericString());
113-
}
114-
else {
115-
sb.append("in ")
116-
.append(this.executable.toGenericString());
117-
}
87+
StringBuilder sb = new StringBuilder("Validation failed for argument [")
88+
.append(this.parameter.getParameterIndex()).append("] in ")
89+
.append(this.parameter.getExecutable().toGenericString());
11890
BindingResult bindingResult = getBindingResult();
11991
if (bindingResult.getErrorCount() > 1) {
12092
sb.append(" with ").append(bindingResult.getErrorCount()).append(" errors");

0 commit comments

Comments
 (0)