Skip to content

Commit 16ff05e

Browse files
committed
Polish
1 parent 3b36171 commit 16ff05e

File tree

1 file changed

+11
-22
lines changed

1 file changed

+11
-22
lines changed

spring-context/src/test/java/org/springframework/context/generator/ApplicationContextAotGeneratorRuntimeHintsTests.java

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,10 @@
2828
import org.springframework.aot.test.agent.RuntimeHintsInvocations;
2929
import org.springframework.aot.test.agent.RuntimeHintsRecorder;
3030
import org.springframework.aot.test.generator.compile.TestCompiler;
31-
import org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor;
32-
import org.springframework.beans.factory.config.BeanDefinition;
3331
import org.springframework.beans.factory.support.BeanDefinitionBuilder;
3432
import org.springframework.beans.factory.support.RootBeanDefinition;
3533
import org.springframework.context.ApplicationContextInitializer;
36-
import org.springframework.context.annotation.AnnotationConfigUtils;
37-
import org.springframework.context.annotation.CommonAnnotationBeanPostProcessor;
34+
import org.springframework.context.annotation.AnnotationConfigApplicationContext;
3835
import org.springframework.context.aot.ApplicationContextAotGenerator;
3936
import org.springframework.context.support.GenericApplicationContext;
4037
import org.springframework.context.testfixture.context.generator.SimpleComponent;
@@ -45,7 +42,7 @@
4542
import static org.assertj.core.api.Assertions.assertThat;
4643

4744
/**
48-
* Tests the {@link org.springframework.aot.hint.RuntimeHints} generation in {@link ApplicationContextAotGenerator}.
45+
* Tests the {@link RuntimeHints} generation in {@link ApplicationContextAotGenerator}.
4946
*
5047
* @author Brian Clozel
5148
* @author Stephane Nicoll
@@ -55,17 +52,14 @@ class ApplicationContextAotGeneratorRuntimeHintsTests {
5552

5653
@Test
5754
void generateApplicationContextWithSimpleBean() {
58-
GenericApplicationContext context = new GenericApplicationContext();
55+
GenericApplicationContext context = new AnnotationConfigApplicationContext();
5956
context.registerBeanDefinition("test", new RootBeanDefinition(SimpleComponent.class));
6057
compile(context, (hints, invocations) -> assertThat(invocations).match(hints));
6158
}
6259

6360
@Test
6461
void generateApplicationContextWithAutowiring() {
65-
GenericApplicationContext context = new GenericApplicationContext();
66-
context.registerBeanDefinition(AnnotationConfigUtils.AUTOWIRED_ANNOTATION_PROCESSOR_BEAN_NAME,
67-
BeanDefinitionBuilder.rootBeanDefinition(AutowiredAnnotationBeanPostProcessor.class)
68-
.setRole(BeanDefinition.ROLE_INFRASTRUCTURE).getBeanDefinition());
62+
GenericApplicationContext context = new AnnotationConfigApplicationContext();
6963
context.registerBeanDefinition("autowiredComponent", new RootBeanDefinition(AutowiredComponent.class));
7064
context.registerBeanDefinition("number", BeanDefinitionBuilder.rootBeanDefinition(Integer.class, "valueOf")
7165
.addConstructorArgValue("42").getBeanDefinition());
@@ -74,28 +68,23 @@ void generateApplicationContextWithAutowiring() {
7468

7569
@Test
7670
void generateApplicationContextWithInitDestroyMethods() {
77-
GenericApplicationContext context = new GenericApplicationContext();
78-
context.registerBeanDefinition(AnnotationConfigUtils.COMMON_ANNOTATION_PROCESSOR_BEAN_NAME,
79-
BeanDefinitionBuilder.rootBeanDefinition(CommonAnnotationBeanPostProcessor.class)
80-
.setRole(BeanDefinition.ROLE_INFRASTRUCTURE).getBeanDefinition());
71+
GenericApplicationContext context = new AnnotationConfigApplicationContext();
8172
context.registerBeanDefinition("initDestroyComponent", new RootBeanDefinition(InitDestroyComponent.class));
82-
compile(context, (hints, invocations) -> assertThat(invocations).withRegistrar(new InitDestroyIssueRegistrar()).match(hints));
73+
compile(context, (hints, invocations) -> assertThat(invocations).match(hints));
8374
}
8475

8576
@Test
8677
void generateApplicationContextWithMultipleInitDestroyMethods() {
87-
GenericApplicationContext context = new GenericApplicationContext();
88-
context.registerBeanDefinition(AnnotationConfigUtils.COMMON_ANNOTATION_PROCESSOR_BEAN_NAME,
89-
BeanDefinitionBuilder.rootBeanDefinition(CommonAnnotationBeanPostProcessor.class)
90-
.setRole(BeanDefinition.ROLE_INFRASTRUCTURE).getBeanDefinition());
78+
GenericApplicationContext context = new AnnotationConfigApplicationContext();
9179
RootBeanDefinition beanDefinition = new RootBeanDefinition(InitDestroyComponent.class);
9280
beanDefinition.setInitMethodName("customInit");
9381
beanDefinition.setDestroyMethodName("customDestroy");
9482
context.registerBeanDefinition("initDestroyComponent", beanDefinition);
95-
compile(context, (hints, invocations) -> assertThat(invocations).withRegistrar(new InitDestroyIssueRegistrar()).match(hints));
83+
compile(context, (hints, invocations) -> assertThat(invocations)
84+
.withRegistrar(new InitDestroyIssueRegistrar()).match(hints));
9685
}
9786

98-
// TODO: Remove once https://github.com/spring-projects/spring-framework/issues/28215 is fixed
87+
// TODO: Remove once https://github.com/spring-projects/spring-framework/issues/29077 is fixed
9988
static class InitDestroyIssueRegistrar implements RuntimeHintsRegistrar {
10089
@Override
10190
public void registerHints(RuntimeHints hints, ClassLoader classLoader) {
@@ -105,7 +94,7 @@ public void registerHints(RuntimeHints hints, ClassLoader classLoader) {
10594
}
10695
}
10796

108-
@SuppressWarnings({"rawtypes", "unchecked"})
97+
@SuppressWarnings({ "rawtypes", "unchecked" })
10998
private void compile(GenericApplicationContext applicationContext, BiConsumer<RuntimeHints, RuntimeHintsInvocations> initializationResult) {
11099
ApplicationContextAotGenerator generator = new ApplicationContextAotGenerator();
111100
TestGenerationContext generationContext = new TestGenerationContext();

0 commit comments

Comments
 (0)