Skip to content

Commit 162e533

Browse files
committed
Merge branch '6.2.x'
# Conflicts: # spring-context/src/test/java/org/springframework/scheduling/concurrent/AbstractSchedulingTaskExecutorTests.java # spring-web/src/main/java/org/springframework/http/MediaType.java # spring-websocket/spring-websocket.gradle # spring-websocket/src/main/java/org/springframework/web/socket/messaging/WebSocketStompClient.java # spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/DefaultTransportRequest.java
2 parents 2b9010c + edf7f3c commit 162e533

File tree

9 files changed

+24
-10
lines changed

9 files changed

+24
-10
lines changed

spring-jdbc/src/main/java/org/springframework/jdbc/datasource/JdbcTransactionObjectSupport.java

+4
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package org.springframework.jdbc.datasource;
1818

1919
import java.sql.SQLException;
20+
import java.sql.SQLFeatureNotSupportedException;
2021
import java.sql.Savepoint;
2122

2223
import org.springframework.lang.Nullable;
@@ -179,6 +180,9 @@ public void releaseSavepoint(Object savepoint) throws TransactionException {
179180
try {
180181
conHolder.getConnection().releaseSavepoint((Savepoint) savepoint);
181182
}
183+
catch (SQLFeatureNotSupportedException ex) {
184+
// typically on Oracle - ignore
185+
}
182186
catch (Throwable ex) {
183187
throw new TransactionSystemException("Could not explicitly release JDBC savepoint", ex);
184188
}

spring-test/src/main/java/org/springframework/test/context/jdbc/SqlScriptsTestExecutionListener.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,10 @@ public void afterTestMethod(TestContext testContext) {
182182
@Override
183183
public void processAheadOfTime(RuntimeHints runtimeHints, Class<?> testClass, ClassLoader classLoader) {
184184
getSqlAnnotationsFor(testClass).forEach(sql ->
185-
registerClasspathResources(getScripts(sql, testClass, null, true), runtimeHints, classLoader));
185+
registerClasspathResources(getScripts(sql, testClass, null, true), runtimeHints, classLoader));
186186
getSqlMethods(testClass).forEach(testMethod ->
187-
getSqlAnnotationsFor(testMethod).forEach(sql ->
188-
registerClasspathResources(getScripts(sql, testClass, testMethod, false), runtimeHints, classLoader)));
187+
getSqlAnnotationsFor(testMethod).forEach(sql ->
188+
registerClasspathResources(getScripts(sql, testClass, testMethod, false), runtimeHints, classLoader)));
189189
}
190190

191191
/**

spring-webflux/spring-webflux.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ dependencies {
2727
optional("org.eclipse.jetty.ee10.websocket:jetty-ee10-websocket-jetty-server") {
2828
exclude group: "jakarta.servlet", module: "jakarta.servlet-api"
2929
}
30-
optional("org.eclipse.jetty.websocket:jetty-websocket-jetty-server")
3130
optional("org.eclipse.jetty.websocket:jetty-websocket-jetty-client")
31+
optional("org.eclipse.jetty.websocket:jetty-websocket-jetty-server")
3232
optional("org.freemarker:freemarker")
3333
optional("org.jetbrains.kotlin:kotlin-reflect")
3434
optional("org.jetbrains.kotlin:kotlin-stdlib")

spring-webflux/src/main/java/org/springframework/web/reactive/config/WebFluxConfigurationSupport.java

+9-3
Original file line numberDiff line numberDiff line change
@@ -485,9 +485,9 @@ private WebSocketService initWebSocketService() {
485485
try {
486486
service = new HandshakeWebSocketService();
487487
}
488-
catch (IllegalStateException ex) {
488+
catch (Throwable ex) {
489489
// Don't fail, test environment perhaps
490-
service = new NoUpgradeStrategyWebSocketService();
490+
service = new NoUpgradeStrategyWebSocketService(ex);
491491
}
492492
}
493493
return service;
@@ -608,9 +608,15 @@ public void validate(@Nullable Object target, Errors errors) {
608608

609609
private static final class NoUpgradeStrategyWebSocketService implements WebSocketService {
610610

611+
private final Throwable ex;
612+
613+
public NoUpgradeStrategyWebSocketService(Throwable ex) {
614+
this.ex = ex;
615+
}
616+
611617
@Override
612618
public Mono<Void> handleRequest(ServerWebExchange exchange, WebSocketHandler webSocketHandler) {
613-
return Mono.error(new IllegalStateException("No suitable RequestUpgradeStrategy"));
619+
return Mono.error(new IllegalStateException("No suitable RequestUpgradeStrategy", this.ex));
614620
}
615621
}
616622

spring-webflux/src/main/java/org/springframework/web/reactive/resource/LiteWebJarsResourceResolver.java

+2
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public class LiteWebJarsResourceResolver extends AbstractResourceResolver {
4949

5050
private final WebJarVersionLocator webJarVersionLocator;
5151

52+
5253
/**
5354
* Create a {@code LiteWebJarsResourceResolver} with a default {@code WebJarVersionLocator} instance.
5455
*/
@@ -64,6 +65,7 @@ public LiteWebJarsResourceResolver(WebJarVersionLocator webJarVersionLocator) {
6465
this.webJarVersionLocator = webJarVersionLocator;
6566
}
6667

68+
6769
@Override
6870
protected Mono<Resource> resolveResourceInternal(@Nullable ServerWebExchange exchange,
6971
String requestPath, List<? extends Resource> locations, ResourceResolverChain chain) {

spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultAsyncServerResponse.java

+1
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ final class DefaultAsyncServerResponse extends ErrorHandlingServerResponse imple
6363
this.timeout = timeout;
6464
}
6565

66+
6667
@Override
6768
public ServerResponse block() {
6869
try {

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/LiteWebJarsResourceResolver.java

+2
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public class LiteWebJarsResourceResolver extends AbstractResourceResolver {
4949

5050
private final WebJarVersionLocator webJarVersionLocator;
5151

52+
5253
/**
5354
* Create a {@code LiteWebJarsResourceResolver} with a default {@code WebJarVersionLocator} instance.
5455
*/
@@ -64,6 +65,7 @@ public LiteWebJarsResourceResolver(WebJarVersionLocator webJarVersionLocator) {
6465
this.webJarVersionLocator = webJarVersionLocator;
6566
}
6667

68+
6769
@Override
6870
@Nullable
6971
protected Resource resolveResourceInternal(@Nullable HttpServletRequest request, String requestPath,

spring-websocket/src/main/java/org/springframework/web/socket/adapter/standard/StandardToWebSocketExtensionAdapter.java

-2
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,10 @@
3434
*/
3535
public class StandardToWebSocketExtensionAdapter extends WebSocketExtension {
3636

37-
3837
public StandardToWebSocketExtensionAdapter(Extension extension) {
3938
super(extension.getName(), initParameters(extension));
4039
}
4140

42-
4341
private static Map<String, String> initParameters(Extension extension) {
4442
List<Extension.Parameter> parameters = extension.getParameters();
4543
Map<String, String> result = new LinkedCaseInsensitiveMap<>(parameters.size(), Locale.ROOT);

spring-websocket/src/main/java/org/springframework/web/socket/adapter/standard/WebSocketToStandardExtensionAdapter.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright 2002-2016 the original author or authors.
2+
* Copyright 2002-2024 the original author or authors.
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -55,6 +55,7 @@ public String getValue() {
5555
}
5656
}
5757

58+
5859
@Override
5960
public String getName() {
6061
return this.name;

0 commit comments

Comments
 (0)