Skip to content

Commit 11c2cde

Browse files
vpavicsnicoll
authored andcommitted
Fix regression in JmsAccessor#setSessionAcknowledgeMode
This commit partially reverts 3b8dd0a, which introduced a strict validation in JmsAccessor#setSessionAcknowledgeMode that prevents use of vendor-specific acknowledge modes. See gh-31328
1 parent ce9ca70 commit 11c2cde

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

spring-jms/src/main/java/org/springframework/jms/support/JmsAccessor.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,6 @@ public void setSessionAcknowledgeModeName(String constantName) {
167167
* @see jakarta.jms.Connection#createSession(boolean, int)
168168
*/
169169
public void setSessionAcknowledgeMode(int sessionAcknowledgeMode) {
170-
Assert.isTrue(sessionConstants.containsValue(sessionAcknowledgeMode),
171-
"Only values of acknowledge mode constants allowed");
172170
this.sessionAcknowledgeMode = sessionAcknowledgeMode;
173171
}
174172

spring-jms/src/test/java/org/springframework/jms/support/JmsAccessorTests.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,6 @@ void setSessionAcknowledgeModeNameToAllSupportedValues() {
9898

9999
@Test
100100
void setSessionAcknowledgeMode() {
101-
assertThatIllegalArgumentException().isThrownBy(() -> accessor.setSessionAcknowledgeMode(999));
102-
103101
accessor.setSessionAcknowledgeMode(Session.AUTO_ACKNOWLEDGE);
104102
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.AUTO_ACKNOWLEDGE);
105103

@@ -111,6 +109,9 @@ void setSessionAcknowledgeMode() {
111109

112110
accessor.setSessionAcknowledgeMode(Session.SESSION_TRANSACTED);
113111
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(Session.SESSION_TRANSACTED);
112+
113+
accessor.setSessionAcknowledgeMode(999);
114+
assertThat(accessor.getSessionAcknowledgeMode()).isEqualTo(999);
114115
}
115116

116117
@Test

0 commit comments

Comments
 (0)