Skip to content

Commit e0b6b98

Browse files
committed
Polishing.
Improve readability. See #97
1 parent d7affa8 commit e0b6b98

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/main/java/org/springframework/data/release/infra/DependencyOperations.java

+7-2
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,15 @@
2929
import java.time.LocalDateTime;
3030
import java.time.format.DateTimeFormatter;
3131
import java.util.ArrayList;
32+
import java.util.Arrays;
3233
import java.util.Collections;
34+
import java.util.HashSet;
3335
import java.util.LinkedHashMap;
3436
import java.util.List;
3537
import java.util.Map;
3638
import java.util.Optional;
3739
import java.util.Properties;
40+
import java.util.Set;
3841
import java.util.concurrent.ExecutorService;
3942
import java.util.function.BiConsumer;
4043
import java.util.function.Consumer;
@@ -468,6 +471,9 @@ DependencyVersions getCurrentDependencies(SupportedProject supportedProject) {
468471
File pom = getPomFile(supportedProject);
469472
ProjectDependencies dependencies = ProjectDependencies.get(supportedProject);
470473

474+
Set<Project> skipDependencyDeclarationCheck = new HashSet<>(
475+
Arrays.asList(Projects.NEO4J, Projects.BUILD, Projects.JPA, Projects.RELATIONAL));
476+
471477
return doWithPom(pom, Pom.class, it -> {
472478

473479
Map<Dependency, DependencyVersion> versions = new LinkedHashMap<>();
@@ -477,8 +483,7 @@ DependencyVersions getCurrentDependencies(SupportedProject supportedProject) {
477483
Dependency dependency = projectDependency.getDependency();
478484

479485
if (!(project == Projects.MONGO_DB && projectDependency.getProperty().equals("mongo.reactivestreams")
480-
|| project == Projects.NEO4J || project == Projects.BUILD || project == Projects.JPA
481-
|| project == Projects.RELATIONAL)) {
486+
|| skipDependencyDeclarationCheck.contains(project))) {
482487

483488
if (it.getDependencyVersion(dependency.getArtifactId()) == null
484489
&& it.getManagedDependency(dependency.getArtifactId()) == null) {

0 commit comments

Comments
 (0)