From 28c06079a3bd5fb66136275f2b2d5e78907f09c9 Mon Sep 17 00:00:00 2001 From: Diego Krupitza Date: Thu, 17 Feb 2022 16:26:06 +0100 Subject: [PATCH] `StringBuilder` can be replaced with String concatenation. In this case the usage of `StringBuilder` has no additional benefit, since it is not inside a loop where the jvm may have problems detecting String concatenation that can be optimized. The usage of "simple" String concatenation makes the code more readable and the code will be automatically optimized by the compiler. (So the final result may use `StringBuilder`). --- .../springframework/data/relational/core/sql/AssignValue.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java index 3cbc44fcc1..5bd222592b 100644 --- a/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java +++ b/spring-data-relational/src/main/java/org/springframework/data/relational/core/sql/AssignValue.java @@ -72,7 +72,6 @@ public Expression getValue() { @Override public String toString() { - StringBuilder builder = new StringBuilder(); - return builder.append(this.column).append(" = ").append(this.value).toString(); + return this.column + " = " + this.value; } }