Implement RepositoryFactorySupport.getEntityInformation(RepositoryMetadata) instead of private overload.

Overriding the proper variant of EntityInformation is now possible because we no longer utilize a private method in addition to the public one leading to partial customization of EntityInformation.

Closes #2053

Author: mp911de

spring-data-jdbc/src/main/java/org/springframework/data/jdbc/repository/support/JdbcRepositoryFactory.java

@@ -27,10 +27,10 @@
 import org.springframework.data.relational.core.dialect.Dialect;
 import org.springframework.data.relational.core.mapping.RelationalMappingContext;
 import org.springframework.data.relational.core.mapping.RelationalPersistentEntity;
-import org.springframework.data.repository.core.EntityInformation;
+import org.springframework.data.relational.repository.query.RelationalEntityInformation;
+import org.springframework.data.relational.repository.support.MappingRelationalEntityInformation;
 import org.springframework.data.repository.core.RepositoryInformation;
 import org.springframework.data.repository.core.RepositoryMetadata;
-import org.springframework.data.repository.core.support.PersistentEntityInformation;
 import org.springframework.data.repository.core.support.RepositoryFactorySupport;
 import org.springframework.data.repository.query.CachingValueExpressionDelegate;
 import org.springframework.data.repository.query.QueryLookupStrategy;
@@ -104,13 +104,12 @@ public void setQueryMappingConfiguration(QueryMappingConfiguration queryMappingC
 		this.queryMappingConfiguration = queryMappingConfiguration;
 	}
 
-	@SuppressWarnings("unchecked")
 	@Override
-	public <T, ID> EntityInformation<T, ID> getEntityInformation(Class<T> aClass) {
+	public RelationalEntityInformation<?, ?> getEntityInformation(RepositoryMetadata metadata) {
 
-		RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(aClass);
+		RelationalPersistentEntity<?> entity = context.getRequiredPersistentEntity(metadata.getDomainType());
 
-		return (EntityInformation<T, ID>) new PersistentEntityInformation<>(entity);
+		return new MappingRelationalEntityInformation<>(entity);
 	}
 
 	@Override

spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/repository/support/R2dbcRepositoryFactory.java

@@ -104,8 +104,7 @@ protected Class<?> getRepositoryBaseClass(RepositoryMetadata metadata) {
 	@Override
 	protected Object getTargetRepository(RepositoryInformation information) {
 
-		RelationalEntityInformation<?, ?> entityInformation = getEntityInformation(information.getDomainType(),
-				information);
+		RelationalEntityInformation<?, ?> entityInformation = getEntityInformation(information);
 
 		return getTargetRepositoryViaReflection(information, entityInformation, operations, this.converter);
 	}
@@ -117,17 +116,12 @@ protected Optional<QueryLookupStrategy> getQueryLookupStrategy(@Nullable Key key
 				new CachingValueExpressionDelegate(valueExpressionDelegate), converter, dataAccessStrategy));
 	}
 
-	public <T, ID> RelationalEntityInformation<T, ID> getEntityInformation(Class<T> domainClass) {
-		return getEntityInformation(domainClass, null);
-	}
-
-	@SuppressWarnings("unchecked")
-	private <T, ID> RelationalEntityInformation<T, ID> getEntityInformation(Class<T> domainClass,
-			@Nullable RepositoryInformation information) {
+	@Override
+	public RelationalEntityInformation<?, ?> getEntityInformation(RepositoryMetadata metadata) {
 
-		RelationalPersistentEntity<?> entity = this.mappingContext.getRequiredPersistentEntity(domainClass);
+		RelationalPersistentEntity<?> entity = this.mappingContext.getRequiredPersistentEntity(metadata.getDomainType());
 
-		return new MappingRelationalEntityInformation<>((RelationalPersistentEntity<T>) entity);
+		return new MappingRelationalEntityInformation<>(entity);
 	}
 
 	/**

spring-data-r2dbc/src/test/java/org/springframework/data/r2dbc/repository/support/R2dbcRepositoryFactoryUnitTests.java

@@ -33,6 +33,7 @@
 import org.springframework.data.relational.repository.query.RelationalEntityInformation;
 import org.springframework.data.relational.repository.support.MappingRelationalEntityInformation;
 import org.springframework.data.repository.Repository;
+import org.springframework.data.repository.core.support.AbstractRepositoryMetadata;
 import org.springframework.r2dbc.core.DatabaseClient;
 
 /**
@@ -60,7 +61,8 @@ public void before() {
 	public void usesMappingRelationalEntityInformationIfMappingContextSet() {
 
 		R2dbcRepositoryFactory factory = new R2dbcRepositoryFactory(databaseClient, dataAccessStrategy);
-		RelationalEntityInformation<Person, Long> entityInformation = factory.getEntityInformation(Person.class);
+		RelationalEntityInformation<?, ?> entityInformation = factory
+				.getEntityInformation(AbstractRepositoryMetadata.getMetadata(MyPersonRepository.class));
 
 		assertThat(entityInformation).isInstanceOf(MappingRelationalEntityInformation.class);
 	}